)]}'
{"jenkins/jobs/ironic.yaml":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"cac6bd0d953fa61251c235e5d039bd8857a5fb0a","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"IRONIC_BOOT_MODE\u003duefi\""},{"line_number":294,"context_line":"          fi"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"          if [ \"{storage-interface}\" \u003d\u003d \"cinder\" ] ; then"},{"line_number":297,"context_line":"            export IRONIC_ENABLED_STORAGE_INTERFACES\u003dcinder,noop"},{"line_number":298,"context_line":"            export IRONIC_STORAGE_INTERFACE\u003dcinder"},{"line_number":299,"context_line":"            export ENABLED_SERVICES\u003dcinder,c-sch,c-api,c-vol"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f1a1f67_e02310a6","line":296,"updated":"2017-07-18 17:16:32.000000000","message":"Instead of doing it like this, please create an ironic-cinder \"builder\". Look at line 135 for how the ironic-multitenant \u0027builder\u0027 does it.","commit_id":"6ffaa55fc12225a6e0d4f9c4ef7b8b90df03161b"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"cac6bd0d953fa61251c235e5d039bd8857a5fb0a","unresolved":false,"context_lines":[{"line_number":296,"context_line":"          if [ \"{storage-interface}\" \u003d\u003d \"cinder\" ] ; then"},{"line_number":297,"context_line":"            export IRONIC_ENABLED_STORAGE_INTERFACES\u003dcinder,noop"},{"line_number":298,"context_line":"            export IRONIC_STORAGE_INTERFACE\u003dcinder"},{"line_number":299,"context_line":"            export ENABLED_SERVICES\u003dcinder,c-sch,c-api,c-vol"},{"line_number":300,"context_line":"          fi"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"          export DEVSTACK_PROJECT_FROM_GIT\u003d\"\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f1a1f67_2537da01","line":299,"updated":"2017-07-18 17:16:32.000000000","message":"I think this should be:\n\n export DEVSTACK_GATE_CINDER\u003d1\n\nthen devstack-gate will set the services correctly using features.yaml.\n\nhttps://github.com/openstack-infra/devstack-gate/blob/fdce8e71d529ad39d14dfae525495f2ef06620d4/features.yaml#L124-L126","commit_id":"6ffaa55fc12225a6e0d4f9c4ef7b8b90df03161b"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"96b2c2e355f0ebc424e70cd29932888637882878","unresolved":false,"context_lines":[{"line_number":296,"context_line":"          if [ \"{storage-interface}\" \u003d\u003d \"cinder\" ] ; then"},{"line_number":297,"context_line":"            export IRONIC_ENABLED_STORAGE_INTERFACES\u003dcinder,noop"},{"line_number":298,"context_line":"            export IRONIC_STORAGE_INTERFACE\u003dcinder"},{"line_number":299,"context_line":"            export ENABLED_SERVICES\u003dcinder,c-sch,c-api,c-vol"},{"line_number":300,"context_line":"          fi"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"          export DEVSTACK_PROJECT_FROM_GIT\u003d\"\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f1a1f67_20e348db","line":299,"in_reply_to":"1f1a1f67_2537da01","updated":"2017-07-18 17:31:41.000000000","message":"Never mind on this. Since DEVSTACK_GATE_IRONIC is set, it removes the cinder ones.\n\nSo this is correct.","commit_id":"6ffaa55fc12225a6e0d4f9c4ef7b8b90df03161b"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"cac6bd0d953fa61251c235e5d039bd8857a5fb0a","unresolved":false,"context_lines":[{"line_number":653,"context_line":"          deploy_driver: \u0027{driver}\u0027"},{"line_number":654,"context_line":"          image-type: \u0027{image-type}\u0027"},{"line_number":655,"context_line":"          boot-mode: \u0027{boot-mode}\u0027"},{"line_number":656,"context_line":"          storage-interface: \u0027\u0027"},{"line_number":657,"context_line":"          branch-override: \u0027{branch-override}\u0027"},{"line_number":658,"context_line":"          bm-vm-count: 1"},{"line_number":659,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f1a1f67_451d3672","line":656,"updated":"2017-07-18 17:16:32.000000000","message":"If have an ironic-cinder builder we won\u0027t need these.","commit_id":"6ffaa55fc12225a6e0d4f9c4ef7b8b90df03161b"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"31a9b06194e52b92be3c237be71e611aaa47d9b9","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    builders:"},{"line_number":43,"context_line":"      - ironic-extra-vars:"},{"line_number":44,"context_line":"          script: |"},{"line_number":45,"context_line":"            export IRONIC_ENABLED_STORAGE_INTERFACES\u003dcinder,noop"},{"line_number":46,"context_line":"            export IRONIC_STORAGE_INTERFACE\u003dcinder"},{"line_number":47,"context_line":"            # We have to enable cinder this way, as normally when"},{"line_number":48,"context_line":"            # DEVSTACK_GATE_IRONIC\u003d1 it disables all the cinder services."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f1a1f67_560812d8","line":45,"updated":"2017-07-20 04:19:41.000000000","message":"This probably needs to be in DEVSTACK_LOCAL_CONFIG\n\nSee:\nhttps://review.openstack.org/#/c/485348/1..2/devstack-vm-gate-wrap.sh","commit_id":"aaad12a8884330c99e7bf7407510f049f5ba604e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"630c081b13d8068c497f9d75da50ace25bbf86fd","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    builders:"},{"line_number":43,"context_line":"      - ironic-extra-vars:"},{"line_number":44,"context_line":"          script: |"},{"line_number":45,"context_line":"            export IRONIC_ENABLED_STORAGE_INTERFACES\u003dcinder,noop"},{"line_number":46,"context_line":"            export IRONIC_STORAGE_INTERFACE\u003dcinder"},{"line_number":47,"context_line":"            # We have to enable cinder this way, as normally when"},{"line_number":48,"context_line":"            # DEVSTACK_GATE_IRONIC\u003d1 it disables all the cinder services."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f1a1f67_16ae1a98","line":45,"in_reply_to":"1f1a1f67_560812d8","updated":"2017-07-20 04:28:58.000000000","message":"++","commit_id":"aaad12a8884330c99e7bf7407510f049f5ba604e"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"31a9b06194e52b92be3c237be71e611aaa47d9b9","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      - ironic-extra-vars:"},{"line_number":44,"context_line":"          script: |"},{"line_number":45,"context_line":"            export IRONIC_ENABLED_STORAGE_INTERFACES\u003dcinder,noop"},{"line_number":46,"context_line":"            export IRONIC_STORAGE_INTERFACE\u003dcinder"},{"line_number":47,"context_line":"            # We have to enable cinder this way, as normally when"},{"line_number":48,"context_line":"            # DEVSTACK_GATE_IRONIC\u003d1 it disables all the cinder services."},{"line_number":49,"context_line":"            export ENABLED_SERVICES\u003dcinder,c-sch,c-api,c-vol"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f1a1f67_360d96e8","line":46,"updated":"2017-07-20 04:19:41.000000000","message":"Ditto","commit_id":"aaad12a8884330c99e7bf7407510f049f5ba604e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"630c081b13d8068c497f9d75da50ace25bbf86fd","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      - ironic-extra-vars:"},{"line_number":44,"context_line":"          script: |"},{"line_number":45,"context_line":"            export IRONIC_ENABLED_STORAGE_INTERFACES\u003dcinder,noop"},{"line_number":46,"context_line":"            export IRONIC_STORAGE_INTERFACE\u003dcinder"},{"line_number":47,"context_line":"            # We have to enable cinder this way, as normally when"},{"line_number":48,"context_line":"            # DEVSTACK_GATE_IRONIC\u003d1 it disables all the cinder services."},{"line_number":49,"context_line":"            export ENABLED_SERVICES\u003dcinder,c-sch,c-api,c-vol"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f1a1f67_f6927e58","line":46,"in_reply_to":"1f1a1f67_360d96e8","updated":"2017-07-20 04:28:58.000000000","message":"++","commit_id":"aaad12a8884330c99e7bf7407510f049f5ba604e"}],"zuul/layout.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"91eed4f236e9f83942c7a226d28e93a46a8fe09d","unresolved":false,"context_lines":[{"line_number":3296,"context_line":""},{"line_number":3297,"context_line":"  # Only run the Boot-From-Volume (BFV) job starting in Pike"},{"line_number":3298,"context_line":"  - name: ^gate-tempest-dsvm-ironic-bfv-ubuntu-xenial-nv$"},{"line_number":3299,"context_line":"    branch: ^(?!stable/(mitaka|newton|ocata)).*$"},{"line_number":3300,"context_line":""},{"line_number":3301,"context_line":"  - name: ^gate-senlin-dsvm-tempest-(py27|py35)-(functional|api|integration)"},{"line_number":3302,"context_line":"    skip-if:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f1a1f67_3487bcb9","line":3299,"range":{"start_line":3299,"start_character":24,"end_line":3299,"end_character":30},"updated":"2017-07-20 15:02:33.000000000","message":"nit: I think mitaka is dead","commit_id":"252f5eec7caeef2e3ea287c9828aefb09c5646dc"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"a05eefa0edeb2693f25f8fb11ea526aeef956233","unresolved":false,"context_lines":[{"line_number":3296,"context_line":""},{"line_number":3297,"context_line":"  # Only run the Boot-From-Volume (BFV) job starting in Pike"},{"line_number":3298,"context_line":"  - name: ^gate-tempest-dsvm-ironic-bfv-ubuntu-xenial-nv$"},{"line_number":3299,"context_line":"    branch: ^(?!stable/(mitaka|newton|ocata)).*$"},{"line_number":3300,"context_line":""},{"line_number":3301,"context_line":"  - name: ^gate-senlin-dsvm-tempest-(py27|py35)-(functional|api|integration)"},{"line_number":3302,"context_line":"    skip-if:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff346bd7_49294988","line":3299,"range":{"start_line":3299,"start_character":24,"end_line":3299,"end_character":30},"in_reply_to":"1f1a1f67_3487bcb9","updated":"2017-07-25 17:55:34.000000000","message":"It is - please remove.","commit_id":"252f5eec7caeef2e3ea287c9828aefb09c5646dc"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"dbf5e366f2f131ab51f3fa2fc4ee86e814b22660","unresolved":false,"context_lines":[{"line_number":3296,"context_line":""},{"line_number":3297,"context_line":"  # Only run the Boot-From-Volume (BFV) job starting in Pike"},{"line_number":3298,"context_line":"  - name: ^gate-tempest-dsvm-ironic-bfv-ubuntu-xenial-nv$"},{"line_number":3299,"context_line":"    branch: ^(?!stable/(mitaka|newton|ocata)).*$"},{"line_number":3300,"context_line":""},{"line_number":3301,"context_line":"  - name: ^gate-senlin-dsvm-tempest-(py27|py35)-(functional|api|integration)"},{"line_number":3302,"context_line":"    skip-if:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff346bd7_69464d52","line":3299,"range":{"start_line":3299,"start_character":24,"end_line":3299,"end_character":30},"in_reply_to":"ff346bd7_49294988","updated":"2017-07-25 17:57:32.000000000","message":"Done","commit_id":"252f5eec7caeef2e3ea287c9828aefb09c5646dc"}]}