)]}'
{"jenkins/jobs/heat.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"2c4425cf48e31bc724e71227d420eb23e51882c2","unresolved":false,"context_lines":[{"line_number":260,"context_line":"          export PROJECTS\u003d\"openstack-dev/grenade $PROJECTS\""},{"line_number":261,"context_line":"          export PYTHONUNBUFFERED\u003dtrue"},{"line_number":262,"context_line":"          export GRENADE_PLUGINRC\u003d\"enable_grenade_plugin heat https://git.openstack.org/openstack/heat\""},{"line_number":263,"context_line":"          export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"enable_plugin heat git://git.openstack.org/openstack/heat\""},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"          export ENABLED_SERVICES"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_042d9745","line":263,"range":{"start_line":263,"start_character":16,"end_line":263,"end_character":40},"updated":"2017-07-10 12:02:44.000000000","message":"Use the new local_conf stanza instead.","commit_id":"221a4b75a6c06e6c8170113b860efb7b8214fefd"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"2c4425cf48e31bc724e71227d420eb23e51882c2","unresolved":false,"context_lines":[{"line_number":262,"context_line":"          export GRENADE_PLUGINRC\u003d\"enable_grenade_plugin heat https://git.openstack.org/openstack/heat\""},{"line_number":263,"context_line":"          export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"enable_plugin heat git://git.openstack.org/openstack/heat\""},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"          export ENABLED_SERVICES"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"          export DEVSTACK_GATE_NEUTRON\u003d1"},{"line_number":268,"context_line":"          export DEVSTACK_GATE_TEMPEST\u003d1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_c4267f69","line":265,"range":{"start_line":265,"start_character":17,"end_line":265,"end_character":33},"updated":"2017-07-10 12:02:44.000000000","message":"unused, remove","commit_id":"221a4b75a6c06e6c8170113b860efb7b8214fefd"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"5fc5eacad0f4418e8334539d20272d5b00b9a140","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"- job-template:"},{"line_number":246,"context_line":"    name: \u0027{pipeline}-grenade-dsvm-heat-multinode-{node-release}{suffix}\u0027"},{"line_number":247,"context_line":"    node: \u0027{node}\u0027"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    wrappers:"},{"line_number":250,"context_line":"      - build-timeout:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f1a1f67_20914348","line":247,"range":{"start_line":246,"start_character":0,"end_line":247,"end_character":18},"updated":"2017-07-17 09:00:43.000000000","message":"This job template seems almost same as the exiting grenade job other than DEVSTACK_GATE_TOPOLOGY\u003dmultinode. You could probably use a \u0027special\u0027 flag to enable multinode, rather than having two almost similar job templates?\n\nDoes this upgrade the nodes one at a time and run some tests in-between? Else this would be just a multinode cold upgrade job I assume. At present we don\u0027t do any testing with the existing grenade job after the upgrade. I\u0027ve a patch in the queue to run heat gabbi api tests after the upgrade[1].\n\n[1] https://review.openstack.org/#/c/460542/","commit_id":"724f6127e3c1fcbbc21ec8e34ec3f979c8fd26e0"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"0ddd33a4a93de47681657f6317ffd9ab139d825a","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"- job-template:"},{"line_number":246,"context_line":"    name: \u0027{pipeline}-grenade-dsvm-heat-multinode-{node-release}{suffix}\u0027"},{"line_number":247,"context_line":"    node: \u0027{node}\u0027"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    wrappers:"},{"line_number":250,"context_line":"      - build-timeout:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f1a1f67_6664d722","line":247,"range":{"start_line":246,"start_character":0,"end_line":247,"end_character":18},"in_reply_to":"1f1a1f67_20914348","updated":"2017-07-18 02:34:28.000000000","message":"Hi, Rabi. Thanks for reviewing. Yes, at this time, we have two almost similar job templates, but IMO if we merged multi-node patch, maybe we can remove the old one (the single-node)?\n\nI have seen your patch. It is the 1st option, run functional tests before and after upgrade process. The 2nd is adding script to run tests in heat/heat_upgradetests/. But seems like, this directory haven\u0027t used for 2 years (I think we can remove it if we decide to take the 1st option), so the 1st is better.","commit_id":"724f6127e3c1fcbbc21ec8e34ec3f979c8fd26e0"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2bbc278936400b07c5767ef9ab6f23ead1936616","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"- job-template:"},{"line_number":246,"context_line":"    name: \u0027{pipeline}-grenade-dsvm-heat-multinode-{node-release}{suffix}\u0027"},{"line_number":247,"context_line":"    node: \u0027{node}\u0027"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    wrappers:"},{"line_number":250,"context_line":"      - build-timeout:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f1a1f67_dbe01029","line":247,"range":{"start_line":246,"start_character":0,"end_line":247,"end_character":18},"in_reply_to":"1f1a1f67_6664d722","updated":"2017-07-18 12:49:45.000000000","message":"\u003e Yes, at this time, we have two almost similar job templates, but IMO if we merged multi-node patch, maybe we can remove the old one (the single-node)?\n\nHmm.. My preference would be to have 2 jobs to start with (single/multinode), but have a single job template with a \u0027topology\u0027 flag in the job name?","commit_id":"724f6127e3c1fcbbc21ec8e34ec3f979c8fd26e0"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"9e5f2bd8ac71abb82c1dab73b79f1d8d244d4da7","unresolved":false,"context_lines":[{"line_number":176,"context_line":"          export PYTHONUNBUFFERED\u003dtrue"},{"line_number":177,"context_line":"          export BRANCH_OVERRIDE\u003d{branch-override}"},{"line_number":178,"context_line":"          export DEVSTACK_PROJECT_FROM_GIT\u003dpython-heatclient"},{"line_number":179,"context_line":"    "},{"line_number":180,"context_line":"          if [ \"$BRANCH_OVERRIDE\" !\u003d \"default\" ] ; then"},{"line_number":181,"context_line":"              export OVERRIDE_ZUUL_BRANCH\u003d$BRANCH_OVERRIDE"},{"line_number":182,"context_line":"          fi"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"df3967d1_9ce68d16","side":"PARENT","line":179,"range":{"start_line":179,"start_character":0,"end_line":179,"end_character":4},"updated":"2017-07-31 10:43:21.000000000","message":"These changes are not needed.","commit_id":"679ff3b650bfd90013baaaaee394945063b9f8f0"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"dc317c7d1b3bc57bd962b75952a50c7d14ae7ff2","unresolved":false,"context_lines":[{"line_number":176,"context_line":"          export PYTHONUNBUFFERED\u003dtrue"},{"line_number":177,"context_line":"          export BRANCH_OVERRIDE\u003d{branch-override}"},{"line_number":178,"context_line":"          export DEVSTACK_PROJECT_FROM_GIT\u003dpython-heatclient"},{"line_number":179,"context_line":"    "},{"line_number":180,"context_line":"          if [ \"$BRANCH_OVERRIDE\" !\u003d \"default\" ] ; then"},{"line_number":181,"context_line":"              export OVERRIDE_ZUUL_BRANCH\u003d$BRANCH_OVERRIDE"},{"line_number":182,"context_line":"          fi"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"df3967d1_53f0fd90","side":"PARENT","line":179,"range":{"start_line":179,"start_character":0,"end_line":179,"end_character":4},"in_reply_to":"df3967d1_9ce68d16","updated":"2017-08-01 01:15:55.000000000","message":"I will remove this.","commit_id":"679ff3b650bfd90013baaaaee394945063b9f8f0"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"07d7f012740dfe30fa963667e6d5da0e73538d59","unresolved":false,"context_lines":[{"line_number":230,"context_line":"              export OVERRIDE_ZUUL_BRANCH\u003d$BRANCH_OVERRIDE"},{"line_number":231,"context_line":"          fi"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"          function pre_test_hook {{"},{"line_number":234,"context_line":"              cd /opt/stack/new/heat/heat_upgradetests"},{"line_number":235,"context_line":"              ./pre_test_hook.sh"},{"line_number":236,"context_line":"          }}"},{"line_number":237,"context_line":"          export -f pre_test_hook"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"          function post_test_hook {{"},{"line_number":240,"context_line":"              cd /opt/stack/new/heat/heat_upgradetests"},{"line_number":241,"context_line":"              ./post_test_hook.sh"},{"line_number":242,"context_line":"          }}"},{"line_number":243,"context_line":"          export -f post_test_hook"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"          cp devstack-gate/devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh"},{"line_number":246,"context_line":"          ./safe-devstack-vm-gate-wrap.sh"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"df3967d1_d28ce280","side":"PARENT","line":243,"range":{"start_line":233,"start_character":0,"end_line":243,"end_character":34},"updated":"2017-08-01 06:41:44.000000000","message":"Will removing this not break the existing job?","commit_id":"90f48c1bce20d24c71d59c58c88ab305d48cc840"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"85d9a8a2d7f7a09034406b943d2f4ff0f5ef7133","unresolved":false,"context_lines":[{"line_number":230,"context_line":"              export OVERRIDE_ZUUL_BRANCH\u003d$BRANCH_OVERRIDE"},{"line_number":231,"context_line":"          fi"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"          function pre_test_hook {{"},{"line_number":234,"context_line":"              cd /opt/stack/new/heat/heat_upgradetests"},{"line_number":235,"context_line":"              ./pre_test_hook.sh"},{"line_number":236,"context_line":"          }}"},{"line_number":237,"context_line":"          export -f pre_test_hook"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"          function post_test_hook {{"},{"line_number":240,"context_line":"              cd /opt/stack/new/heat/heat_upgradetests"},{"line_number":241,"context_line":"              ./post_test_hook.sh"},{"line_number":242,"context_line":"          }}"},{"line_number":243,"context_line":"          export -f post_test_hook"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"          cp devstack-gate/devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh"},{"line_number":246,"context_line":"          ./safe-devstack-vm-gate-wrap.sh"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"df3967d1_324b2e2c","side":"PARENT","line":243,"range":{"start_line":233,"start_character":0,"end_line":243,"end_character":34},"in_reply_to":"df3967d1_d28ce280","updated":"2017-08-01 06:45:19.000000000","message":"No, I think. because these files are empty, don\u0027t define anything.\n\n[1] https://github.com/openstack/heat/tree/master/heat_upgradetests","commit_id":"90f48c1bce20d24c71d59c58c88ab305d48cc840"}],"jenkins/jobs/projects.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"9e5f2bd8ac71abb82c1dab73b79f1d8d244d4da7","unresolved":false,"context_lines":[{"line_number":5285,"context_line":"          lbaasversion: lbaasv2"},{"line_number":5286,"context_line":"      - \u0027{pipeline}-grenade-dsvm-heat-{topology}-{node-release}{suffix}\u0027:"},{"line_number":5287,"context_line":"          pipeline: gate"},{"line_number":5288,"context_line":"          topology: singlenode"},{"line_number":5289,"context_line":"          node-release: ubuntu-xenial"},{"line_number":5290,"context_line":"          node: ubuntu-xenial"},{"line_number":5291,"context_line":"          suffix: \u0027\u0027"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"df3967d1_5cc5c53b","line":5288,"range":{"start_line":5288,"start_character":20,"end_line":5288,"end_character":30},"updated":"2017-07-31 10:43:21.000000000","message":"I think we should keep the name of the existing job. You can use \u0027\u0027 and \u0027-multinode\u0027 for \u0027topology\u0027 respectively.\n\nyou\u0027ve to remove preceding hyphen for topology in the job name.","commit_id":"176033063e05ddd06c8e7c914cbf2aa58595bba8"}],"zuul/layout.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"9e5f2bd8ac71abb82c1dab73b79f1d8d244d4da7","unresolved":false,"context_lines":[{"line_number":3627,"context_line":"      - name: merge-check"},{"line_number":3628,"context_line":"    check:"},{"line_number":3629,"context_line":"      - gate-grenade-dsvm-neutron-ubuntu-xenial"},{"line_number":3630,"context_line":"      - gate-grenade-dsvm-heat-singlenode-ubuntu-xenial"},{"line_number":3631,"context_line":"      - gate-grenade-dsvm-neutron-multinode-ubuntu-xenial"},{"line_number":3632,"context_line":"      - gate-grenade-publish-docs"},{"line_number":3633,"context_line":"      - gate-grenade-dsvm-ironic-ubuntu-xenial-nv"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"df3967d1_bc04b17c","line":3630,"range":{"start_line":3630,"start_character":8,"end_line":3630,"end_character":55},"updated":"2017-07-31 10:43:21.000000000","message":"Changing it to a voting job?? With the changes I mentioned earlier you don\u0027t have to change this.","commit_id":"176033063e05ddd06c8e7c914cbf2aa58595bba8"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"dc317c7d1b3bc57bd962b75952a50c7d14ae7ff2","unresolved":false,"context_lines":[{"line_number":3627,"context_line":"      - name: merge-check"},{"line_number":3628,"context_line":"    check:"},{"line_number":3629,"context_line":"      - gate-grenade-dsvm-neutron-ubuntu-xenial"},{"line_number":3630,"context_line":"      - gate-grenade-dsvm-heat-singlenode-ubuntu-xenial"},{"line_number":3631,"context_line":"      - gate-grenade-dsvm-neutron-multinode-ubuntu-xenial"},{"line_number":3632,"context_line":"      - gate-grenade-publish-docs"},{"line_number":3633,"context_line":"      - gate-grenade-dsvm-ironic-ubuntu-xenial-nv"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"df3967d1_130b958e","line":3630,"range":{"start_line":3630,"start_character":8,"end_line":3630,"end_character":55},"in_reply_to":"df3967d1_bc04b17c","updated":"2017-08-01 01:15:55.000000000","message":"My mistake, will change back.","commit_id":"176033063e05ddd06c8e7c914cbf2aa58595bba8"}]}