)]}'
{"jenkins/jobs/ansible-role-jobs.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"e2fdcf184b6dbe42143d41bc6700b32bcc8a250a","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    builders:"},{"line_number":76,"context_line":"      - print-template-name:"},{"line_number":77,"context_line":"          template-name: \"{template-name}\""},{"line_number":78,"context_line":"      - zuul-git-prep-upper-constraints-cross:"},{"line_number":79,"context_line":"          project: openstack/{name}"},{"line_number":80,"context_line":"      - shell: |"},{"line_number":81,"context_line":"          # EPEL must be enabled because some deps from bindep.txt are"},{"line_number":82,"context_line":"          # otherwise not available"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f1d235d_4c8c917e","line":79,"range":{"start_line":78,"start_character":0,"end_line":79,"end_character":35},"updated":"2017-07-12 06:31:01.000000000","message":"why do you need this here? I don\u0027t see how this will make a difference in your jobs.","commit_id":"bf2def268e527e3093098663ef1af90c4f17305c"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"35e330ac36eea2c7781cf0a87821ce940acde944","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    builders:"},{"line_number":76,"context_line":"      - print-template-name:"},{"line_number":77,"context_line":"          template-name: \"{template-name}\""},{"line_number":78,"context_line":"      - zuul-git-prep-upper-constraints-cross:"},{"line_number":79,"context_line":"          project: openstack/{name}"},{"line_number":80,"context_line":"      - shell: |"},{"line_number":81,"context_line":"          # EPEL must be enabled because some deps from bindep.txt are"},{"line_number":82,"context_line":"          # otherwise not available"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f1a1f67_476f3ec5","line":79,"range":{"start_line":78,"start_character":0,"end_line":79,"end_character":35},"in_reply_to":"1f1a1f67_7c752d98","updated":"2017-07-12 09:37:54.000000000","message":"please ask on #openstack-infra for review of this, I have some problems getting my head around this. if this is correct, it needs a comment!","commit_id":"bf2def268e527e3093098663ef1af90c4f17305c"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3e4f17008d31dbeb760b003fb85f481b9402a145","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    builders:"},{"line_number":76,"context_line":"      - print-template-name:"},{"line_number":77,"context_line":"          template-name: \"{template-name}\""},{"line_number":78,"context_line":"      - zuul-git-prep-upper-constraints-cross:"},{"line_number":79,"context_line":"          project: openstack/{name}"},{"line_number":80,"context_line":"      - shell: |"},{"line_number":81,"context_line":"          # EPEL must be enabled because some deps from bindep.txt are"},{"line_number":82,"context_line":"          # otherwise not available"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f1a1f67_7c752d98","line":79,"range":{"start_line":78,"start_character":0,"end_line":79,"end_character":35},"in_reply_to":"3f1d235d_4c8c917e","updated":"2017-07-12 09:15:34.000000000","message":"This made more sense when I had the jenkins/jobs/projects.yaml entry in the previous patch set.\n\nThe idea is to ensure that it\u0027s the named project that gets checked out by zuul-cloner rather than the project that\u0027s the source of the event.\n\nie When the keystone repo kicks off the job, it\u0027s still the openstack-ansible-os_keystone repo that gets checked out, and that project\u0027s tests sort out where to place the keystone repo/patch using the zuul variables available.\n\nDoes that make sense?","commit_id":"bf2def268e527e3093098663ef1af90c4f17305c"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"becb0769b287a666536a146520842335aeeff3f2","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    builders:"},{"line_number":76,"context_line":"      - print-template-name:"},{"line_number":77,"context_line":"          template-name: \"{template-name}\""},{"line_number":78,"context_line":"      - zuul-git-prep-upper-constraints-cross:"},{"line_number":79,"context_line":"          project: openstack/{name}"},{"line_number":80,"context_line":"      - shell: |"},{"line_number":81,"context_line":"          # NOTE(mhayden): The CentOS CI image has many repositories enabled by"},{"line_number":82,"context_line":"          # default that can cause package conflicts. We must disable all of"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f2577a7_baaa6c82","line":79,"range":{"start_line":78,"start_character":0,"end_line":79,"end_character":35},"updated":"2017-09-11 17:35:54.000000000","message":"this will not make any difference, it will check out the same repo as previously.\n\nthis change is a nop -\u003e giving -1 since I don\u0027t expect that\u0027s what you want. Best to add a comment here as well.","commit_id":"23e580a4f35a050a9394223eb7b5485fd97ce415"}],"jenkins/jobs/projects.yaml":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"dc7be5b80af0506b1a6260bcfadb6b8c4bdd316c","unresolved":false,"context_lines":[{"line_number":5938,"context_line":"          node: ubuntu-xenial-2-node"},{"line_number":5939,"context_line":"          node-release: ubuntu-xenial"},{"line_number":5940,"context_line":"      - periodic-python-jobs-with-oslo-master"},{"line_number":5941,"context_line":"      - \u0027{pipeline}-keystone-osa-rolling-upgrade-{node-release}{suffix}\u0027:"},{"line_number":5942,"context_line":"          pipeline: gate"},{"line_number":5943,"context_line":"          suffix: \u0027-nv\u0027"},{"line_number":5944,"context_line":"          node: ubuntu-xenial-2-node"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f1d235d_0b78dc28","side":"PARENT","line":5941,"updated":"2017-07-11 13:16:50.000000000","message":"This isn\u0027t needed anymore?","commit_id":"d044b19c96bbd880d8445851661fe05e05857c01"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b45c0edcbbb7b239f462a2278ba6e98818246b62","unresolved":false,"context_lines":[{"line_number":5938,"context_line":"          node: ubuntu-xenial-2-node"},{"line_number":5939,"context_line":"          node-release: ubuntu-xenial"},{"line_number":5940,"context_line":"      - periodic-python-jobs-with-oslo-master"},{"line_number":5941,"context_line":"      - \u0027{pipeline}-keystone-osa-rolling-upgrade-{node-release}{suffix}\u0027:"},{"line_number":5942,"context_line":"          pipeline: gate"},{"line_number":5943,"context_line":"          suffix: \u0027-nv\u0027"},{"line_number":5944,"context_line":"          node: ubuntu-xenial-2-node"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f1d235d_ae0456c7","side":"PARENT","line":5941,"in_reply_to":"3f1d235d_0b78dc28","updated":"2017-07-11 13:39:16.000000000","message":"The job definition is in ansible-role-jobs, so it doesn\u0027t need to be redefined. I did think that it might need to still be here and tried that in PS5 but it failed. I\u0027m still waiting for expertise from infra to see if I\u0027m right with all of this.","commit_id":"d044b19c96bbd880d8445851661fe05e05857c01"}]}