)]}'
{"jenkins/scripts/run-tox.sh":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"90fadc443663ba08561bffba5c8fd5ed8f9202f9","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    fi"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    # By default stestr will fail if no tests are run."},{"line_number":65,"context_line":"    if [[ -d \".stestr\" ]] ; then"},{"line_number":66,"context_line":"        rancount\u003d$($bin_path/testr last | sed -ne \u0027s/Ran \\([0-9]\\+\\).*tests in.*/\\1/p\u0027)"},{"line_number":67,"context_line":"        if [ -z \"$rancount\" ] || [ \"$rancount\" -eq \"0\" ] ; then"},{"line_number":68,"context_line":"            echo"}],"source_content_type":"text/x-sh","patch_set":1,"id":"df3967d1_08ee40ec","line":65,"updated":"2017-08-04 08:38:42.000000000","message":"Should this be really -d - and not the negation \"! -d\"?\nthat would be the same code path as before","commit_id":"53c0b641f6a01b7ee0541a1e68684647e67cb4ae"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"3d37ea2c4a6cb1d88582d5dad699816d8e1254e8","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    fi"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    # By default stestr will fail if no tests are run."},{"line_number":65,"context_line":"    if [[ -d \".stestr\" ]] ; then"},{"line_number":66,"context_line":"        rancount\u003d$($bin_path/testr last | sed -ne \u0027s/Ran \\([0-9]\\+\\).*tests in.*/\\1/p\u0027)"},{"line_number":67,"context_line":"        if [ -z \"$rancount\" ] || [ \"$rancount\" -eq \"0\" ] ; then"},{"line_number":68,"context_line":"            echo"}],"source_content_type":"text/x-sh","patch_set":1,"id":"bf3e73b7_89f76af6","line":65,"in_reply_to":"df3967d1_08ee40ec","updated":"2017-08-07 17:45:16.000000000","message":"Yep, good catch","commit_id":"53c0b641f6a01b7ee0541a1e68684647e67cb4ae"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"249aae270d2210a68fb60fc9d59de628f0417f18","unresolved":false,"context_lines":[{"line_number":32,"context_line":"function process_testr_artifacts {"},{"line_number":33,"context_line":"    if [ -d \".stestr\" ] ; then"},{"line_number":34,"context_line":"        if [ -f \".stestr/0\" ] ; then"},{"line_number":35,"context_line":"            stestr\u003d1"},{"line_number":36,"context_line":"            $bin_path/stestr last --subunit \u003e ./testrepository.subunit"},{"line_number":37,"context_line":"        fi"},{"line_number":38,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7f287b81_e57a3575","line":35,"range":{"start_line":35,"start_character":12,"end_line":35,"end_character":20},"updated":"2017-09-06 21:01:22.000000000","message":"Is this needed?","commit_id":"5e4152259d4c4ee33890f373ea42b7a97fd80922"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"80f59141fa85f7c94ac4c34e69483dc7576dac93","unresolved":false,"context_lines":[{"line_number":32,"context_line":"function process_testr_artifacts {"},{"line_number":33,"context_line":"    if [ -d \".stestr\" ] ; then"},{"line_number":34,"context_line":"        if [ -f \".stestr/0\" ] ; then"},{"line_number":35,"context_line":"            stestr\u003d1"},{"line_number":36,"context_line":"            $bin_path/stestr last --subunit \u003e ./testrepository.subunit"},{"line_number":37,"context_line":"        fi"},{"line_number":38,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7f287b81_65bc0506","line":35,"range":{"start_line":35,"start_character":12,"end_line":35,"end_character":20},"in_reply_to":"7f287b81_e57a3575","updated":"2017-09-06 21:03:08.000000000","message":"nope, it\u0027s a leftover from an earlier rev.","commit_id":"5e4152259d4c4ee33890f373ea42b7a97fd80922"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"249aae270d2210a68fb60fc9d59de628f0417f18","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        exit 1"},{"line_number":62,"context_line":"    fi"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    # By default stestr will fail if no tests are run."},{"line_number":65,"context_line":"    if [[ ! -d \".stestr\" ]] ; then"},{"line_number":66,"context_line":"        rancount\u003d$($bin_path/testr last | sed -ne \u0027s/Ran \\([0-9]\\+\\).*tests in.*/\\1/p\u0027)"},{"line_number":67,"context_line":"        if [ -z \"$rancount\" ] || [ \"$rancount\" -eq \"0\" ] ; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7f287b81_458b4967","line":64,"range":{"start_line":64,"start_character":9,"end_line":64,"end_character":23},"updated":"2017-09-06 21:01:22.000000000","message":"Is there a non default behavior where no tests \u003d\u003d pass? If so we should probably keep this check here and swap out stestr/testr as appropriate.","commit_id":"5e4152259d4c4ee33890f373ea42b7a97fd80922"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"80f59141fa85f7c94ac4c34e69483dc7576dac93","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        exit 1"},{"line_number":62,"context_line":"    fi"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    # By default stestr will fail if no tests are run."},{"line_number":65,"context_line":"    if [[ ! -d \".stestr\" ]] ; then"},{"line_number":66,"context_line":"        rancount\u003d$($bin_path/testr last | sed -ne \u0027s/Ran \\([0-9]\\+\\).*tests in.*/\\1/p\u0027)"},{"line_number":67,"context_line":"        if [ -z \"$rancount\" ] || [ \"$rancount\" -eq \"0\" ] ; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7f287b81_85c37189","line":64,"range":{"start_line":64,"start_character":9,"end_line":64,"end_character":23},"in_reply_to":"7f287b81_458b4967","updated":"2017-09-06 21:03:08.000000000","message":"Hmm, let me check the code real quickly. But, I\u0027d view that as a bug in stestr that we should fix.","commit_id":"5e4152259d4c4ee33890f373ea42b7a97fd80922"}]}