)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"38d218aa2c3fb1c6774691ea3494bb571b6c1110","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Here are the test patches for reference:"},{"line_number":12,"context_line":"https://review.openstack.org/#/c/492664/"},{"line_number":13,"context_line":"https://review.openstack.org/#/c/469837/"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I9d1534cb63b6b26931212bb293278dd96c7ea809"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f436f4f_b2937aa3","line":13,"updated":"2017-08-10 23:05:34.000000000","message":"This patch isn\u0027t so useful in showing that it works. I think could delete this line.","commit_id":"040f95b1996ea771f05a0e7a312b77292c073c07"}],"jenkins/jobs/ironic.yaml":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"38d218aa2c3fb1c6774691ea3494bb571b6c1110","unresolved":false,"context_lines":[{"line_number":273,"context_line":"          if [ \"$BRANCH_OVERRIDE\" !\u003d \"default\" ] ; then"},{"line_number":274,"context_line":"              export OVERRIDE_ZUUL_BRANCH\u003d$BRANCH_OVERRIDE"},{"line_number":275,"context_line":"          fi"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"          if [ \"$ZUUL_BRANCH\" \u003d\u003d \"master\" ] ; then"},{"line_number":278,"context_line":"              export DEVSTACK_GATE_TLSPROXY\u003d1"},{"line_number":279,"context_line":"          fi"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_32ed4a25","line":276,"updated":"2017-08-10 23:05:34.000000000","message":"Can the devstack-gate test patch basically copy these lines into it?\n\nI want to make sure the test case here is tested. And likely do a test with stable/newton \u0026 stable/ocata too. To be thorough.","commit_id":"040f95b1996ea771f05a0e7a312b77292c073c07"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"38d218aa2c3fb1c6774691ea3494bb571b6c1110","unresolved":false,"context_lines":[{"line_number":274,"context_line":"              export OVERRIDE_ZUUL_BRANCH\u003d$BRANCH_OVERRIDE"},{"line_number":275,"context_line":"          fi"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"          if [ \"$ZUUL_BRANCH\" \u003d\u003d \"master\" ] ; then"},{"line_number":278,"context_line":"              export DEVSTACK_GATE_TLSPROXY\u003d1"},{"line_number":279,"context_line":"          fi"},{"line_number":280,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_5277aea1","line":277,"updated":"2017-08-10 23:05:34.000000000","message":"We should have a TODO or something. I imagine we will want this to be updated as time goes on.\n\nAnd I wonder if better to say if it isn\u0027t something. Like:\n\n if [[ \"$ZUUL_BRANCH\" !\u003d \"stable/newton\" \u0026\u0026 \"$ZUUL_BRANCH\" !\u003d \"stable/ocata\" \u0026\u0026 \"ZUUL_BRANCH\" !\u003d \"stable/ocata\" ]]; then\n\nOr something like that.","commit_id":"040f95b1996ea771f05a0e7a312b77292c073c07"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"a0ce7ced154a90243c382193bcb92a0ef9ae5f56","unresolved":false,"context_lines":[{"line_number":274,"context_line":"              export OVERRIDE_ZUUL_BRANCH\u003d$BRANCH_OVERRIDE"},{"line_number":275,"context_line":"          fi"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"          if [ \"$ZUUL_BRANCH\" \u003d\u003d \"master\" ] ; then"},{"line_number":278,"context_line":"              export DEVSTACK_GATE_TLSPROXY\u003d1"},{"line_number":279,"context_line":"          fi"},{"line_number":280,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f287b81_accf7154","line":277,"in_reply_to":"7f287b81_220f882f","updated":"2017-08-28 05:46:48.000000000","message":"Sorry Clark and I discussed this on IRC[1] I *think we decided that as ugly as is it is some form of the double handling of ZUUL_BRANCH will be needed as we\u0027re going to leave the defaults for DEVSTACK_GATE_TLSPROXY on for ocata, pike and master (queens)\n\nSo perhaps:\n\n if [[ ! \"stable/newton stable/ocata stable/pike\" \u003d~ $ZUUL_BRANCH ]] ; then\n    export DEVSTACK_GATE_TLSPROXY\u003d1\n fi\n\nThen as we clean up branches the list will get shorter, once it\u0027s empty we can just leave it on :)\n\n\n[1] http://eavesdrop.openstack.org/irclogs/%23openstack-infra/%23openstack-infra.2017-08-23.log.html#t2017-08-23T03:00:20","commit_id":"040f95b1996ea771f05a0e7a312b77292c073c07"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"1f886e9794672a3b6a0eb4e127f0dcaeb840ce34","unresolved":false,"context_lines":[{"line_number":274,"context_line":"              export OVERRIDE_ZUUL_BRANCH\u003d$BRANCH_OVERRIDE"},{"line_number":275,"context_line":"          fi"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"          if [ \"$ZUUL_BRANCH\" \u003d\u003d \"master\" ] ; then"},{"line_number":278,"context_line":"              export DEVSTACK_GATE_TLSPROXY\u003d1"},{"line_number":279,"context_line":"          fi"},{"line_number":280,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f287b81_220f882f","line":277,"in_reply_to":"9f436f4f_5277aea1","updated":"2017-08-22 18:24:32.000000000","message":"I\u0027d really like to remove this entire check completely. DEVSTACK_GATE_TLS_PROXY is only going to affect Pike and master today. I\u0027ve pinged tonyb about possibly updating that rule to only affect master instead. Mostly want to make sure the stable release team is ok with that. If not then this is probably the best option but it puts multiple layers of branch conditionals in place which is less than ideal.","commit_id":"040f95b1996ea771f05a0e7a312b77292c073c07"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"015e52def8548735640fa60f4bf1e08eba7719e1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            export DEVSTACK_GATE_OS_TEST_TIMEOUT\u003d2400"},{"line_number":37,"context_line":"            export DEVSTACK_GATE_TEMPEST_BAREMETAL_BUILD_TIMEOUT\u003d1200"},{"line_number":38,"context_line":"            export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"IRONIC_BUILD_DEPLOY_RAMDISK\u003dFalse\""},{"line_number":39,"context_line":"            export DEVSTACK_GATE_TLSPROXY\u003d0"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- builder:"},{"line_number":42,"context_line":"    name: ironic-cinder"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f287b81_9510ed58","line":39,"updated":"2017-08-30 15:20:52.000000000","message":"This actually gets applied before the devstack-virtual-ironic value below. So this is a noop.\n\nThis means that grenade jobs won\u0027t do quite what we expect. See comment  below for how to address this.","commit_id":"02afd30dd56517c822a8b3ba33db417ea3b508b6"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"b4e04ad2e7ea11997f32b6619d19eee684bf0c67","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            export DEVSTACK_GATE_OS_TEST_TIMEOUT\u003d2400"},{"line_number":37,"context_line":"            export DEVSTACK_GATE_TEMPEST_BAREMETAL_BUILD_TIMEOUT\u003d1200"},{"line_number":38,"context_line":"            export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"IRONIC_BUILD_DEPLOY_RAMDISK\u003dFalse\""},{"line_number":39,"context_line":"            export DEVSTACK_GATE_TLSPROXY\u003d0"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- builder:"},{"line_number":42,"context_line":"    name: ironic-cinder"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f287b81_50abb373","line":39,"in_reply_to":"7f287b81_9510ed58","updated":"2017-08-30 15:26:34.000000000","message":"Nope I am completely wrong here. We write this value to a file before devstack-virtual-ironic but we don\u0027t source and apply the values in that file until the end of devstack-virtual-ironic. So this is correct as is.","commit_id":"02afd30dd56517c822a8b3ba33db417ea3b508b6"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"015e52def8548735640fa60f4bf1e08eba7719e1","unresolved":false,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"          if [[ ! \"stable/newton stable/ocata stable/pike\" \u003d~ $ZUUL_BRANCH ]] ; then"},{"line_number":278,"context_line":"              export DEVSTACK_GATE_TLSPROXY\u003d1"},{"line_number":279,"context_line":"          fi"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"          if [ \"{deploy_driver}\" \u003d\u003d \"pxe_snmp\" ] ; then"},{"line_number":282,"context_line":"              # explicitly enable pxe_snmp driver"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f287b81_30e02726","line":279,"updated":"2017-08-30 15:20:52.000000000","message":"To handle the grenade case we actually what this check to be something like:\n\n  if [ -z \"$DEVSTACK_GATE_GRENADE] \u0026\u0026 [[ ! \"stable/newton stable/ocata stable/pike\" \u003d~ $ZUUL_BRANCH ]] ; then\n\nAnd we have to move the whole thing below line 326 where we source the ironic vars file (which will set the grenade value for us).","commit_id":"02afd30dd56517c822a8b3ba33db417ea3b508b6"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"b4e04ad2e7ea11997f32b6619d19eee684bf0c67","unresolved":false,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"          if [[ ! \"stable/newton stable/ocata stable/pike\" \u003d~ $ZUUL_BRANCH ]] ; then"},{"line_number":278,"context_line":"              export DEVSTACK_GATE_TLSPROXY\u003d1"},{"line_number":279,"context_line":"          fi"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"          if [ \"{deploy_driver}\" \u003d\u003d \"pxe_snmp\" ] ; then"},{"line_number":282,"context_line":"              # explicitly enable pxe_snmp driver"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f287b81_90d23b27","line":279,"in_reply_to":"7f287b81_30e02726","updated":"2017-08-30 15:26:34.000000000","message":"Actually the fact that we source the ironic vars file at the end of this bash script means that the TLSPROXY\u003d0 will override this and my initial reading of this was completely wrong.\n\nThis means we don\u0027t have to change anything.\n\nWhat confused me is we apply the grenade builder before this builder but we don\u0027t actually apply the side effects of that grenade builder until the end on line 326.","commit_id":"02afd30dd56517c822a8b3ba33db417ea3b508b6"}]}