)]}'
{"roles/submit-log-processor-jobs/library/submit_log_processor_jobs.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"5de48272e4be900115f68cba9e336ff93af48dad","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import re"},{"line_number":20,"context_line":"import logging"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from ansible.module_utils.six.moves import urllib"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import gear"},{"line_number":25,"context_line":"import yaml"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_dde8a017","line":22,"updated":"2017-09-10 22:02:39.000000000","message":"Good point; though, is there a harm for this?  If not, I think I\u0027d probably just leave it as-is -- slightly more future-proof.  If there\u0027s an advantage, I\u0027m happy to change.","commit_id":"0446393462f479802f9363e0d43e93b4bf1f2bba"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"52a47233a5b3632daecb81aa3c85904df995672d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import re"},{"line_number":20,"context_line":"import logging"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from ansible.module_utils.six.moves import urllib"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import gear"},{"line_number":25,"context_line":"import yaml"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_0fc83353","line":22,"updated":"2017-09-09 23:18:21.000000000","message":"You can just use six here - since this depends on gear anyway, and gear depends on six, you don\u0027t have to worry about making the module harder to consume with a six depend.","commit_id":"0446393462f479802f9363e0d43e93b4bf1f2bba"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"52a47233a5b3632daecb81aa3c85904df995672d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.success \u003d success"},{"line_number":56,"context_line":"        self.log_url \u003d log_url"},{"line_number":57,"context_line":"        self.matchers \u003d []"},{"line_number":58,"context_line":"        with open(config) as f:"},{"line_number":59,"context_line":"            conf \u003d yaml.safe_load(f)"},{"line_number":60,"context_line":"        for f in conf[\u0027files\u0027]:"},{"line_number":61,"context_line":"            self.matchers.append(FileMatcher(f[\u0027name\u0027], f.get(\u0027tags\u0027, [])))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_cfd6abf2","line":58,"updated":"2017-09-09 23:18:21.000000000","message":"Instead of taking this as a path, you could take it as a variable.","commit_id":"0446393462f479802f9363e0d43e93b4bf1f2bba"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"5de48272e4be900115f68cba9e336ff93af48dad","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.success \u003d success"},{"line_number":56,"context_line":"        self.log_url \u003d log_url"},{"line_number":57,"context_line":"        self.matchers \u003d []"},{"line_number":58,"context_line":"        with open(config) as f:"},{"line_number":59,"context_line":"            conf \u003d yaml.safe_load(f)"},{"line_number":60,"context_line":"        for f in conf[\u0027files\u0027]:"},{"line_number":61,"context_line":"            self.matchers.append(FileMatcher(f[\u0027name\u0027], f.get(\u0027tags\u0027, [])))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_bdedd426","line":58,"updated":"2017-09-10 22:02:39.000000000","message":"Yes, I think I would like that better.  Wasn\u0027t sure how big this would end up being -- answer: not big, so a var isn\u0027t crazy.  That may open up some interesting possibilities -- like being able to index files in certain jobs without changing project-config.","commit_id":"0446393462f479802f9363e0d43e93b4bf1f2bba"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"52a47233a5b3632daecb81aa3c85904df995672d","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                         **results)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"from ansible.module_utils.basic import *  # noqa"},{"line_number":171,"context_line":"from ansible.module_utils.basic import AnsibleModule"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_8fe1c3d3","line":170,"updated":"2017-09-09 23:18:21.000000000","message":"FWIW, you don\u0027t have to include this line if you\u0027re not using things from it anymore.","commit_id":"0446393462f479802f9363e0d43e93b4bf1f2bba"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"5de48272e4be900115f68cba9e336ff93af48dad","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"from ansible.module_utils.basic import *  # noqa"},{"line_number":171,"context_line":"from ansible.module_utils.basic import AnsibleModule"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_9df21806","line":171,"updated":"2017-09-10 22:02:39.000000000","message":"Ack and ack.","commit_id":"0446393462f479802f9363e0d43e93b4bf1f2bba"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"52a47233a5b3632daecb81aa3c85904df995672d","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"from ansible.module_utils.basic import *  # noqa"},{"line_number":171,"context_line":"from ansible.module_utils.basic import AnsibleModule"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_6fe697eb","line":171,"updated":"2017-09-09 23:18:21.000000000","message":"Also, both of these can go up with normal imports now - the import loader is much smarter than it used to be.","commit_id":"0446393462f479802f9363e0d43e93b4bf1f2bba"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"2b46aa344288b49e7251201a873e5f85d725dc20","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"# Copyright (C) 2017 Red Hat, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_380fb22f","line":1,"updated":"2017-09-11 00:28:25.000000000","message":"Could we consider using a more generic role name for this ? lib-zuul ? lib-zuul-openstack ?\nI ask because it might get messy if we start making a role for each module/plugin.","commit_id":"49ec70c0c50a7d6dd2d4439273edc3c94955fe88"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"d240deac54c79bebc1db16a171e0f476887f0020","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"# Copyright (C) 2017 Red Hat, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_eee2802f","line":1,"in_reply_to":"5f2577a7_380fb22f","updated":"2017-09-11 05:01:45.000000000","message":"I could see a generic role name like that - or leaving it for now and renaming later if we need a similar thing.","commit_id":"49ec70c0c50a7d6dd2d4439273edc3c94955fe88"}],"roles/submit-log-processor-jobs/logstash.yaml":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"2683db9b5f8aa8192c1ae1736781c4dc12e4974e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f2577a7_eff2879a","updated":"2017-09-09 23:19:41.000000000","message":"This seems to duplicate the other logstash.yaml","commit_id":"0446393462f479802f9363e0d43e93b4bf1f2bba"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"5de48272e4be900115f68cba9e336ff93af48dad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f2577a7_1d91889a","updated":"2017-09-10 22:02:39.000000000","message":"Yes, this file is an error and should be removed.","commit_id":"0446393462f479802f9363e0d43e93b4bf1f2bba"}],"roles/submit-log-processor-jobs/subunit.yaml":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"2683db9b5f8aa8192c1ae1736781c4dc12e4974e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f2577a7_8f2f83f5","updated":"2017-09-09 23:19:41.000000000","message":"This seems to duplicate the other subunit.yaml","commit_id":"0446393462f479802f9363e0d43e93b4bf1f2bba"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"5de48272e4be900115f68cba9e336ff93af48dad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f2577a7_fd8d9c7b","updated":"2017-09-10 22:02:39.000000000","message":"Yes, this file is an error and should be removed.","commit_id":"0446393462f479802f9363e0d43e93b4bf1f2bba"}],"roles/submit-logstash-jobs/README.rst":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"2b46aa344288b49e7251201a873e5f85d725dc20","unresolved":false,"context_lines":[{"line_number":8,"context_line":"**Role Variables**"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":".. zuul:rolevar:: logstash_gearman_server"},{"line_number":11,"context_line":"   :default: {{ logstash.openstack.org }}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"   The gearman server to use."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f2577a7_d8fe6e04","line":11,"range":{"start_line":11,"start_character":13,"end_line":11,"end_character":41},"updated":"2017-09-11 00:28:25.000000000","message":"Are those double moustaches supposed to do something ?","commit_id":"49ec70c0c50a7d6dd2d4439273edc3c94955fe88"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"d240deac54c79bebc1db16a171e0f476887f0020","unresolved":false,"context_lines":[{"line_number":8,"context_line":"**Role Variables**"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":".. zuul:rolevar:: logstash_gearman_server"},{"line_number":11,"context_line":"   :default: {{ logstash.openstack.org }}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"   The gearman server to use."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f2577a7_ee8de07b","line":11,"range":{"start_line":11,"start_character":13,"end_line":11,"end_character":41},"in_reply_to":"5f2577a7_d8fe6e04","updated":"2017-09-11 05:01:45.000000000","message":"Agree - in this case logstash.o.o is the actual value.","commit_id":"49ec70c0c50a7d6dd2d4439273edc3c94955fe88"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"1be36e485658fe5b850cb441ddabc3eab193f240","unresolved":false,"context_lines":[{"line_number":8,"context_line":"**Role Variables**"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":".. zuul:rolevar:: logstash_gearman_server"},{"line_number":11,"context_line":"   :default: {{ logstash.openstack.org }}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"   The gearman server to use."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f2577a7_85ae362c","line":11,"range":{"start_line":11,"start_character":13,"end_line":11,"end_character":41},"in_reply_to":"5f2577a7_ee8de07b","updated":"2017-09-11 14:37:38.000000000","message":"This is the only thing that needs changing then? Just trying to clarify the set of comments in this change.","commit_id":"49ec70c0c50a7d6dd2d4439273edc3c94955fe88"}],"roles/submit-logstash-jobs/logstash.yaml":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"52a47233a5b3632daecb81aa3c85904df995672d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# expressions (so if you need to match the root (i.e, the work/logs/"},{"line_number":7,"context_line":"# directory), be sure to anchor them with ^)."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"files:"},{"line_number":10,"context_line":"  - name: console\\.html"},{"line_number":11,"context_line":"    tags:"},{"line_number":12,"context_line":"      - console"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f2577a7_4f04fb7b","line":9,"updated":"2017-09-09 23:18:21.000000000","message":"FWIW, instead of making this a file that you pass by path to the module and then have the module open and read, you can make a vars/main.yaml and put this in there - maybe under a top-level key like \"submit_logstash_config\" or something. That way you can do the same for the subunit role: submit_logstash_config: {\u0027subunit-files\u0027: ...}","commit_id":"0446393462f479802f9363e0d43e93b4bf1f2bba"}],"roles/submit-logstash-jobs/meta/main.yaml":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"2b46aa344288b49e7251201a873e5f85d725dc20","unresolved":false,"context_lines":[{"line_number":1,"context_line":"dependencies:"},{"line_number":2,"context_line":"  - role: submit-log-processor-jobs"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f2577a7_7d3f6cd6","line":1,"updated":"2017-09-11 00:28:25.000000000","message":"This is the wrong format for this file and would crash galaxy (perhaps other things too, not sure), dependencies needs to be a key of galaxy_info.\n\nI found an example in one of our roles here:\n\n    https://github.com/openstack-infra/ansible-role-puppet/blob/master/meta/main.yml","commit_id":"49ec70c0c50a7d6dd2d4439273edc3c94955fe88"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"29d43404e7096420bacb1e37b15d9317a29f2aee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"dependencies:"},{"line_number":2,"context_line":"  - role: submit-log-processor-jobs"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f2577a7_85699626","line":1,"in_reply_to":"5f2577a7_0e914c9a","updated":"2017-09-11 14:23:56.000000000","message":"Ah you\u0027re right, I stand corrected :)","commit_id":"49ec70c0c50a7d6dd2d4439273edc3c94955fe88"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"d240deac54c79bebc1db16a171e0f476887f0020","unresolved":false,"context_lines":[{"line_number":1,"context_line":"dependencies:"},{"line_number":2,"context_line":"  - role: submit-log-processor-jobs"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f2577a7_0e914c9a","line":1,"in_reply_to":"5f2577a7_7d3f6cd6","updated":"2017-09-11 05:01:45.000000000","message":"Look again ... in that file you link dependencies is at the same level as galaxy_info. The meta dependencies are documented here: \n\n http://docs.ansible.com/ansible/latest/playbooks_reuse_roles.html#role-dependencies","commit_id":"49ec70c0c50a7d6dd2d4439273edc3c94955fe88"}],"roles/submit-logstash-jobs/tasks/main.yaml":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"52a47233a5b3632daecb81aa3c85904df995672d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- submit_log_processor_jobs:"},{"line_number":2,"context_line":"    gearman_server: \"{{ logstash_gearman_server }}\""},{"line_number":3,"context_line":"    job: \"push-log\""},{"line_number":4,"context_line":"    config: \"{{ role_path }}/logstash.yaml\""},{"line_number":5,"context_line":"    success: \"{{ success }}\""},{"line_number":6,"context_line":"    host_vars: \"{{ hostvars }}\""},{"line_number":7,"context_line":"    path: \"{{ zuul.executor.log_root }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f2577a7_2ff9af7f","line":4,"updated":"2017-09-09 23:18:21.000000000","message":"Then here just do:\n\n  config: \"{{ submit_logstash_config }}\"","commit_id":"0446393462f479802f9363e0d43e93b4bf1f2bba"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"2b46aa344288b49e7251201a873e5f85d725dc20","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- submit_log_processor_jobs:"},{"line_number":2,"context_line":"    gearman_server: \"{{ logstash_gearman_server }}\""},{"line_number":3,"context_line":"    job: \"push-log\""},{"line_number":4,"context_line":"    config: \"{{ logstash_processor_config }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f2577a7_5d0dd03c","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":27},"updated":"2017-09-11 00:28:25.000000000","message":"Can you please give the task a name ?","commit_id":"49ec70c0c50a7d6dd2d4439273edc3c94955fe88"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"d240deac54c79bebc1db16a171e0f476887f0020","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- submit_log_processor_jobs:"},{"line_number":2,"context_line":"    gearman_server: \"{{ logstash_gearman_server }}\""},{"line_number":3,"context_line":"    job: \"push-log\""},{"line_number":4,"context_line":"    config: \"{{ logstash_processor_config }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f2577a7_aeed9826","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":27},"in_reply_to":"5f2577a7_5d0dd03c","updated":"2017-09-11 05:01:45.000000000","message":"Yah - task name would be good.","commit_id":"49ec70c0c50a7d6dd2d4439273edc3c94955fe88"}],"roles/submit-subunit-jobs/meta/main.yaml":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"2b46aa344288b49e7251201a873e5f85d725dc20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f2577a7_3d21e4b5","line":3,"updated":"2017-09-11 00:28:25.000000000","message":"Ditto","commit_id":"49ec70c0c50a7d6dd2d4439273edc3c94955fe88"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"d240deac54c79bebc1db16a171e0f476887f0020","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f2577a7_6ef7b0f7","line":3,"in_reply_to":"5f2577a7_3d21e4b5","updated":"2017-09-11 05:01:45.000000000","message":"Ditto response ;)","commit_id":"49ec70c0c50a7d6dd2d4439273edc3c94955fe88"}],"roles/submit-subunit-jobs/tasks/main.yaml":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"2b46aa344288b49e7251201a873e5f85d725dc20","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- submit_log_processor_jobs:"},{"line_number":2,"context_line":"    gearman_server: \"{{ subunit_gearman_server }}\""},{"line_number":3,"context_line":"    job: \"push-subunit\""},{"line_number":4,"context_line":"    config: \"{{ subunit_processor_config }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f2577a7_3d0a0426","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":27},"updated":"2017-09-11 00:28:25.000000000","message":"Ditto","commit_id":"49ec70c0c50a7d6dd2d4439273edc3c94955fe88"}]}
