)]}'
{"playbooks/publish/manuals.yaml":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"2826bc5574f828d4a433a30eb45f947ada842a1e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  roles:"},{"line_number":10,"context_line":"    - create-afs-token"},{"line_number":11,"context_line":"    - role: upload-afs"},{"line_number":12,"context_line":"      afs_target: \"{{ afs.path }}/infra/{{ zuul.project.short_name }}\""},{"line_number":13,"context_line":"    - destroy-afs-token"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f515b1d_ee50b3d7","line":12,"updated":"2017-10-09 15:42:18.000000000","message":"Replace infra with developer-docs","commit_id":"e432f2733bf624ae12f7d7ad4d075c74a95565f5"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"bf536a1ddaeda916075d406eaa1ea675e864ed3d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  roles:"},{"line_number":10,"context_line":"    - create-afs-token"},{"line_number":11,"context_line":"    - role: upload-afs"},{"line_number":12,"context_line":"      afs_target: \"{{ afs.path }}/infra/{{ zuul.project.short_name }}\""},{"line_number":13,"context_line":"    - destroy-afs-token"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f515b1d_cee977e3","line":12,"range":{"start_line":12,"start_character":34,"end_line":12,"end_character":39},"updated":"2017-10-09 15:49:09.000000000","message":"Should be developer-docs","commit_id":"5e08313d8f8c5da772a43b05cfdffdbe244556cf"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"bf536a1ddaeda916075d406eaa1ea675e864ed3d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  roles:"},{"line_number":10,"context_line":"    - create-afs-token"},{"line_number":11,"context_line":"    - role: upload-afs"},{"line_number":12,"context_line":"      afs_target: \"{{ afs.path }}/infra/{{ zuul.project.short_name }}\""},{"line_number":13,"context_line":"    - destroy-afs-token"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f515b1d_4eb7c7f6","line":12,"range":{"start_line":12,"start_character":40,"end_line":12,"end_character":69},"updated":"2017-10-09 15:49:09.000000000","message":"don\u0027t need to append the short_name - manuals publishes directly to /afs/.openstack.org/developer-docs I believe, yeah?","commit_id":"5e08313d8f8c5da772a43b05cfdffdbe244556cf"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"c2a1f72c41ae13a85e41d76d5eda8f3af6d33193","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  roles:"},{"line_number":10,"context_line":"    - create-afs-token"},{"line_number":11,"context_line":"    - role: upload-afs"},{"line_number":12,"context_line":"      afs_target: \"{{ afs.path }}/infra/{{ zuul.project.short_name }}\""},{"line_number":13,"context_line":"    - destroy-afs-token"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f515b1d_8e193fd8","line":12,"range":{"start_line":12,"start_character":34,"end_line":12,"end_character":39},"in_reply_to":"7f515b1d_cee977e3","updated":"2017-10-09 15:54:04.000000000","message":"The secret contains docs, I\u0027ll add another secrete with developer-docs.","commit_id":"5e08313d8f8c5da772a43b05cfdffdbe244556cf"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"2826bc5574f828d4a433a30eb45f947ada842a1e","unresolved":false,"context_lines":[{"line_number":360,"context_line":""},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"- job:"},{"line_number":363,"context_line":"    name: publish-tox-manuals"},{"line_number":364,"context_line":"    description: |"},{"line_number":365,"context_line":"      Base job to publish manual related documents. These build jobs"},{"line_number":366,"context_line":"      invoke a tox command and expect the published content to be in"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f515b1d_43eb2077","line":363,"updated":"2017-10-09 15:42:18.000000000","message":"I\u0027d maybe call this one \"publish-openstack-manuals\" - just because it\u0027s a job that publishes openstack manuals and the fact that they\u0027re build using tox right now is an impl detail. (for instance, see https://review.openstack.org/#/c/508694 which doesn\u0027t strictly apply to this - but it\u0027s conceivable we might decide to change openstack-manuals to follow a similar pattern at some point)","commit_id":"e432f2733bf624ae12f7d7ad4d075c74a95565f5"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"12f6a551d6c965acd32667fe0cd469bac190c7a4","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"      Note that this build job does not create a root-marker file,"},{"line_number":371,"context_line":"      this has to be done by scripts called from tox."},{"line_number":372,"context_line":"    parent: openstack-tox"},{"line_number":373,"context_line":"    success-url: publish-docs/"},{"line_number":374,"context_line":"    post-run: playbooks/publish/manuals"},{"line_number":375,"context_line":"    roles:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f515b1d_438440d3","line":372,"range":{"start_line":372,"start_character":3,"end_line":372,"end_character":25},"updated":"2017-10-09 15:25:28.000000000","message":"\"Job openstack-tox not defined\" - what is missing?","commit_id":"e432f2733bf624ae12f7d7ad4d075c74a95565f5"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"2826bc5574f828d4a433a30eb45f947ada842a1e","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"      Note that this build job does not create a root-marker file,"},{"line_number":371,"context_line":"      this has to be done by scripts called from tox."},{"line_number":372,"context_line":"    parent: openstack-tox"},{"line_number":373,"context_line":"    success-url: publish-docs/"},{"line_number":374,"context_line":"    post-run: playbooks/publish/manuals"},{"line_number":375,"context_line":"    roles:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f515b1d_4e58e72f","line":372,"range":{"start_line":372,"start_character":3,"end_line":372,"end_character":25},"in_reply_to":"7f515b1d_438440d3","updated":"2017-10-09 15:42:18.000000000","message":"That is correct- you cannot use openstack-tox as a parent here. See publish-openstack-sphinx-docs. It is \u0027final\u0027 (that\u0027s important, we need for it to not be overridden) - so you can\u0027t use it as a parent - but if you just replace \n\n    parent: openstack-tox\n\nhere with:\n\n    pre-run: playbooks/python-docs/pre\n\nThen, at least for now, you\u0027ll need to either make a run playbook (just copy playbooks/python-docs/run.yaml and change the tox_envlist variable) OR - I just checked and I believe this is safe - update playbooks/python-docs/run.yaml and remove the line:\n\n    tox_envlist: venv\n\nThen add tox_envlist: venv to each of the jobs in jobs.yaml that is using playbooks/python-docs/run just to be sure (we currently default tox_envlist to venv in the tox role, but that\u0027s only temporary, so we should continue to be explicit here)","commit_id":"e432f2733bf624ae12f7d7ad4d075c74a95565f5"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"12f6a551d6c965acd32667fe0cd469bac190c7a4","unresolved":false,"context_lines":[{"line_number":370,"context_line":"      Note that this build job does not create a root-marker file,"},{"line_number":371,"context_line":"      this has to be done by scripts called from tox."},{"line_number":372,"context_line":"    parent: openstack-tox"},{"line_number":373,"context_line":"    success-url: publish-docs/"},{"line_number":374,"context_line":"    post-run: playbooks/publish/manuals"},{"line_number":375,"context_line":"    roles:"},{"line_number":376,"context_line":"      - zuul: openstack-infra/zuul-jobs"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f515b1d_c36f1026","line":373,"range":{"start_line":373,"start_character":3,"end_line":373,"end_character":30},"updated":"2017-10-09 15:25:28.000000000","message":"I will remove this","commit_id":"e432f2733bf624ae12f7d7ad4d075c74a95565f5"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"2826bc5574f828d4a433a30eb45f947ada842a1e","unresolved":false,"context_lines":[{"line_number":382,"context_line":"    parent: publish-tox-manuals"},{"line_number":383,"context_line":"    vars:"},{"line_number":384,"context_line":"      # XXX: what\u0027s the variable to use? "},{"line_number":385,"context_line":"      site: developer"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"- job:"},{"line_number":388,"context_line":"    name: publish-tox-manuals-lang"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f515b1d_8e3c9f93","line":385,"updated":"2017-10-09 15:42:18.000000000","message":"The post-playbook you have above is fine (once it\u0027s updated per the comment) - no need for a site var - upload-afs takes care of it.\n\nYou\u0027ll also likely want to mark all three of these \"final: true\" - and I\u0027d recommend moving the post playbook reference into each of these, so that they can\u0027t be hijacked.","commit_id":"e432f2733bf624ae12f7d7ad4d075c74a95565f5"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"bf536a1ddaeda916075d406eaa1ea675e864ed3d","unresolved":false,"context_lines":[{"line_number":369,"context_line":"      Note that this build job does not create a root-marker file,"},{"line_number":370,"context_line":"      this has to be done by scripts called from tox."},{"line_number":371,"context_line":"    # XXX: Needed here:"},{"line_number":372,"context_line":"    # final: True"},{"line_number":373,"context_line":"    pre-run: playbooks/python-docs/pre"},{"line_number":374,"context_line":"    run: playbooks/project-config/run-tox"},{"line_number":375,"context_line":"    post-run: playbooks/publish/manuals"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f515b1d_8ea6dfc0","line":372,"updated":"2017-10-09 15:49:09.000000000","message":"This will actually eventually want to be \"virtual: true\" - or \"protected: true\" (I can\u0027t remember which we decided to call that) but that hasn\u0027t been implemented yet.","commit_id":"5e08313d8f8c5da772a43b05cfdffdbe244556cf"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"bf536a1ddaeda916075d406eaa1ea675e864ed3d","unresolved":false,"context_lines":[{"line_number":374,"context_line":"    run: playbooks/project-config/run-tox"},{"line_number":375,"context_line":"    post-run: playbooks/publish/manuals"},{"line_number":376,"context_line":"    allowed-projects:"},{"line_number":377,"context_line":"      - openstack-infra/project-config"},{"line_number":378,"context_line":"    roles:"},{"line_number":379,"context_line":"      - zuul: openstack-infra/zuul-jobs"},{"line_number":380,"context_line":"      - zuul: openstack-infra/openstack-zuul-jobs"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f515b1d_2e7ecb18","line":377,"updated":"2017-10-09 15:49:09.000000000","message":"I\u0027d change this to be openstack/manuals - allowed-projects restricts the projects that the job can be added to.","commit_id":"5e08313d8f8c5da772a43b05cfdffdbe244556cf"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"c2a1f72c41ae13a85e41d76d5eda8f3af6d33193","unresolved":false,"context_lines":[{"line_number":374,"context_line":"    run: playbooks/project-config/run-tox"},{"line_number":375,"context_line":"    post-run: playbooks/publish/manuals"},{"line_number":376,"context_line":"    allowed-projects:"},{"line_number":377,"context_line":"      - openstack-infra/project-config"},{"line_number":378,"context_line":"    roles:"},{"line_number":379,"context_line":"      - zuul: openstack-infra/zuul-jobs"},{"line_number":380,"context_line":"      - zuul: openstack-infra/openstack-zuul-jobs"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f515b1d_6e7f23df","line":377,"in_reply_to":"7f515b1d_2e7ecb18","updated":"2017-10-09 15:54:04.000000000","message":"Ah, i see - will change","commit_id":"5e08313d8f8c5da772a43b05cfdffdbe244556cf"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"bf536a1ddaeda916075d406eaa1ea675e864ed3d","unresolved":false,"context_lines":[{"line_number":390,"context_line":""},{"line_number":391,"context_line":"- job:"},{"line_number":392,"context_line":"    name: publish-tox-manuals-developer"},{"line_number":393,"context_line":"    parent: publish-tox-manuals-base"},{"line_number":394,"context_line":"    secrets:"},{"line_number":395,"context_line":"      # XXX: developer.o.o secret missing???"},{"line_number":396,"context_line":"      - secret: afsdeveloper_secret"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f515b1d_aeb87bc7","line":393,"updated":"2017-10-09 15:49:09.000000000","message":"final: true","commit_id":"5e08313d8f8c5da772a43b05cfdffdbe244556cf"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"bf536a1ddaeda916075d406eaa1ea675e864ed3d","unresolved":false,"context_lines":[{"line_number":392,"context_line":"    name: publish-tox-manuals-developer"},{"line_number":393,"context_line":"    parent: publish-tox-manuals-base"},{"line_number":394,"context_line":"    secrets:"},{"line_number":395,"context_line":"      # XXX: developer.o.o secret missing???"},{"line_number":396,"context_line":"      - secret: afsdeveloper_secret"},{"line_number":397,"context_line":"        name: afs"},{"line_number":398,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f515b1d_eea8b378","line":395,"updated":"2017-10-09 15:49:09.000000000","message":"Same secrete - afsdocs_secret - it\u0027s just a different base path. So you\u0027ll want to move the post-run from the base and add it to each child job.","commit_id":"5e08313d8f8c5da772a43b05cfdffdbe244556cf"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"bf536a1ddaeda916075d406eaa1ea675e864ed3d","unresolved":false,"context_lines":[{"line_number":397,"context_line":"        name: afs"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"- job:"},{"line_number":400,"context_line":"    name: publish-tox-manuals-lang"},{"line_number":401,"context_line":"    parent: publish-tox-manuals-base"},{"line_number":402,"context_line":"    vars:"},{"line_number":403,"context_line":"      tox_envlist: publishlang"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f515b1d_8ebdbfb8","line":400,"updated":"2017-10-09 15:49:09.000000000","message":"final: true","commit_id":"5e08313d8f8c5da772a43b05cfdffdbe244556cf"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"bf536a1ddaeda916075d406eaa1ea675e864ed3d","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        name: afs"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"- job:"},{"line_number":409,"context_line":"    name: publish-tox-manuals-developer-lang"},{"line_number":410,"context_line":"    parent: publish-tox-manuals-base"},{"line_number":411,"context_line":"    vars:"},{"line_number":412,"context_line":"      tox_envlist: publishlang"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f515b1d_ae063b85","line":409,"updated":"2017-10-09 15:49:09.000000000","message":"same as above","commit_id":"5e08313d8f8c5da772a43b05cfdffdbe244556cf"}]}