)]}'
{"playbooks/publish/deploy-guide.yaml":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"89432230a46d0c1daeae00cd9a8f895c75325912","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  roles:"},{"line_number":3,"context_line":"    - prepare-docs-for-afs"},{"line_number":4,"context_line":"      # XXX: Do we need to change roles/prepare-docs-for-afs/tasks/main.yaml for this?"},{"line_number":5,"context_line":"      doc_build_dir: \"{{ zuul_work_dir }}/deploy-guide/build\""},{"line_number":6,"context_line":"    - fetch-tox-output"},{"line_number":7,"context_line":"    - role: write-root-marker"},{"line_number":8,"context_line":"      root_marker_dir: \"src/{{ zuul.project.canonical_name }}/deploy-guide/build/html\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f4e5783_e33f7384","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":61},"updated":"2017-10-17 19:09:31.000000000","message":"Maybe set doc_build_dir as a default in the role here [1] and remove the set_fact [2] ?\n\n[1]: https://github.com/openstack-infra/openstack-zuul-jobs/blob/master/roles/prepare-docs-for-afs/defaults/main.yaml\n[2]: https://github.com/openstack-infra/openstack-zuul-jobs/blob/82c05877f1d0688ef04c86e3fe3d16ace78f24ad/roles/prepare-docs-for-afs/tasks/main.yaml#L1","commit_id":"ad638069ef3a96c473bbb54c2ad98b7b06660a7b"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"bf7deebdcdc997f116e234a64b50223363f10329","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- hosts: all"},{"line_number":2,"context_line":"  roles:"},{"line_number":3,"context_line":"    - prepare-docs-for-afs"},{"line_number":4,"context_line":"      doc_build_dir: \"{{ zuul_work_dir }}/deploy-guide/build\""},{"line_number":5,"context_line":"    - fetch-tox-output"},{"line_number":6,"context_line":"    - role: write-root-marker"},{"line_number":7,"context_line":"      root_marker_dir: \"src/{{ zuul.project.canonical_name }}/deploy-guide/build/html\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f4e5783_e312d361","line":4,"range":{"start_line":4,"start_character":21,"end_line":4,"end_character":61},"updated":"2017-10-17 19:33:27.000000000","message":"While this would work, it\u0027s worth questioning whether we want the variable to be declared here rather than in the job vars [1].\nI don\u0027t have a strong opinion so long as we try to stay consistent in how we do it across different jobs/playbooks.\n\n[1]: http://git.openstack.org/cgit/openstack-infra/project-config/tree/zuul.d/jobs.yaml#n505","commit_id":"ce3c5825db4cc3afbbef13031cc61c41ca30f66c"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"2708ff3f20194fe2ad2e6ea00756fbc6bc236c04","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- hosts: all"},{"line_number":2,"context_line":"  roles:"},{"line_number":3,"context_line":"    - prepare-docs-for-afs"},{"line_number":4,"context_line":"      doc_build_dir: \"{{ zuul_work_dir }}/deploy-guide/build\""},{"line_number":5,"context_line":"    - fetch-tox-output"},{"line_number":6,"context_line":"    - role: write-root-marker"},{"line_number":7,"context_line":"      root_marker_dir: \"src/{{ zuul.project.canonical_name }}/deploy-guide/build/html\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4b6375_c101e5b1","line":4,"range":{"start_line":4,"start_character":21,"end_line":4,"end_character":61},"in_reply_to":"5f4e5783_e312d361","updated":"2017-10-18 12:30:56.000000000","message":"It\u0027s a judgement call - it really depends on whether or not we want someone to be able to override it in a pipeline or child job. In this case I\u0027m not sure we want to allow that - so this seems fine. (basically, sometimes it\u0027s important to set in playbook, sometimes it\u0027s important to set in job vars -sometimes it\u0027s a toss-up. I think this one is a toss-up)","commit_id":"ce3c5825db4cc3afbbef13031cc61c41ca30f66c"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"bf7deebdcdc997f116e234a64b50223363f10329","unresolved":false,"context_lines":[{"line_number":4,"context_line":"      doc_build_dir: \"{{ zuul_work_dir }}/deploy-guide/build\""},{"line_number":5,"context_line":"    - fetch-tox-output"},{"line_number":6,"context_line":"    - role: write-root-marker"},{"line_number":7,"context_line":"      root_marker_dir: \"src/{{ zuul.project.canonical_name }}/deploy-guide/build/html\""},{"line_number":8,"context_line":"    - role: fetch-sphinx-output"},{"line_number":9,"context_line":"      sphinx_output_src: \"{{ zuul.project.src_dir }}/deploy-guide/build/html\""},{"line_number":10,"context_line":"      zuul_executor_dest: \"{{ zuul.executor.work_root }}/artifacts\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f4e5783_de07ae17","line":7,"range":{"start_line":7,"start_character":6,"end_line":7,"end_character":86},"updated":"2017-10-17 19:33:27.000000000","message":"Ditto","commit_id":"ce3c5825db4cc3afbbef13031cc61c41ca30f66c"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"bf7deebdcdc997f116e234a64b50223363f10329","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    - role: write-root-marker"},{"line_number":7,"context_line":"      root_marker_dir: \"src/{{ zuul.project.canonical_name }}/deploy-guide/build/html\""},{"line_number":8,"context_line":"    - role: fetch-sphinx-output"},{"line_number":9,"context_line":"      sphinx_output_src: \"{{ zuul.project.src_dir }}/deploy-guide/build/html\""},{"line_number":10,"context_line":"      zuul_executor_dest: \"{{ zuul.executor.work_root }}/artifacts\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- hosts: localhost"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f4e5783_be0ab21c","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":77},"updated":"2017-10-17 19:33:27.000000000","message":"Ditto","commit_id":"ce3c5825db4cc3afbbef13031cc61c41ca30f66c"}]}
