)]}'
{"nodepool/elements/jenkins-slave/install.d/20-jenkins-slave":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"72d6540a3db53218de1f6c3b52d71435d2d087d8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    ln -sf /opt/cache/files /home/jenkins/cache/files"},{"line_number":25,"context_line":"    chown -R jenkins:jenkins /opt/cache/files"},{"line_number":26,"context_line":"    # but make sure the cache is readable by everyone"},{"line_number":27,"context_line":"    chmod -R a+rX /opt/cache/files/*"},{"line_number":28,"context_line":"fi"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# this was copied from outside the chroot by extras.d"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3f4b6375_4ee4873c","side":"PARENT","line":27,"updated":"2017-10-23 23:03:51.000000000","message":"it might be good to duplicate this chmod, in case it has grown dependencies such as the stack user accessing this","commit_id":"b770db0c21b7bf107eb04f1e6a485dad3258dc6b"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"55248803eb29915aec636f7262d6812d02f6006a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    ln -sf /opt/cache/files /home/jenkins/cache/files"},{"line_number":25,"context_line":"    chown -R jenkins:jenkins /opt/cache/files"},{"line_number":26,"context_line":"    # but make sure the cache is readable by everyone"},{"line_number":27,"context_line":"    chmod -R a+rX /opt/cache/files/*"},{"line_number":28,"context_line":"fi"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# this was copied from outside the chroot by extras.d"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa0c359_5aa1eba8","side":"PARENT","line":27,"in_reply_to":"3f4b6375_4ee4873c","updated":"2018-02-07 14:57:55.000000000","message":"Added to \nnodepool/elements/zuul-worker/install.d/60-zuul-worker","commit_id":"b770db0c21b7bf107eb04f1e6a485dad3258dc6b"}],"nodepool/elements/nodepool-base/post-install.d/89-jenkins-scripts":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"c55e03359ce5a0cb7b8c99663045fc99f81dca05","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# NOTE(pabelanger): Until zuulv3 lands, manually copy scripts / data into"},{"line_number":26,"context_line":"# /usr/local/jenkins."},{"line_number":27,"context_line":"mkdir -p /usr/local/jenkins"},{"line_number":28,"context_line":"cp -a /opt/git/openstack-infra/project-config/jenkins/data \\"},{"line_number":29,"context_line":"    /usr/local/jenkins/common_data"},{"line_number":30,"context_line":"cp -a /opt/git/openstack-infra/project-config/jenkins/scripts \\"},{"line_number":31,"context_line":"    /usr/local/jenkins/slave_scripts"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa0c359_d3238f04","side":"PARENT","line":29,"range":{"start_line":28,"start_character":0,"end_line":29,"end_character":34},"updated":"2018-02-08 07:50:38.000000000","message":"We cannot remove this, it will break bindep. We first need a replacement.","commit_id":"16725f6e89caccca367fe07038084ea72d4e38a4"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"70a4e0e1b04c3eb59c0dadbb2884705bc1b3dcc6","unresolved":false,"context_lines":[{"line_number":23,"context_line":"set -o pipefail"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# NOTE(pabelanger): Until zuulv3 lands, manually copy scripts / data into"},{"line_number":26,"context_line":"# /usr/local/jenkins."},{"line_number":27,"context_line":"mkdir -p /usr/local/jenkins"},{"line_number":28,"context_line":"cp -a /opt/git/openstack-infra/project-config/jenkins/data \\"},{"line_number":29,"context_line":"    /usr/local/jenkins/common_data"},{"line_number":30,"context_line":"cp -a /opt/git/openstack-infra/project-config/jenkins/scripts \\"},{"line_number":31,"context_line":"    /usr/local/jenkins/slave_scripts"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa0c359_9a2e93a3","side":"PARENT","line":31,"range":{"start_line":26,"start_character":0,"end_line":31,"end_character":36},"updated":"2018-02-07 15:16:27.000000000","message":"nodepool/scripts/configure_mirror.sh still uses:\n\ncat /usr/local/jenkins/slave_scripts/afs-slug.sh \u003e\u003e /tmp/mirror_info.sh\n\nAlso, I do not see where we copy the slave_scripts over for legacy jobs. So, I\u0027m concerned about removing this.","commit_id":"16725f6e89caccca367fe07038084ea72d4e38a4"}],"nodepool/elements/zuul-worker/install.d/60-zuul-worker":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"72d6540a3db53218de1f6c3b52d71435d2d087d8","unresolved":false,"context_lines":[{"line_number":22,"context_line":"EOF"},{"line_number":23,"context_line":"chmod 0440 /etc/sudoers.d/zuul-sudo-grep"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"visudo -c || die \"Error setting zuul sudo!\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# this was copied from outside the chroot by extras.d"},{"line_number":28,"context_line":"_pub_key\u003d/tmp/in_target.d/zuul-user-ssh-public-key"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3f4b6375_2eba6b09","side":"PARENT","line":25,"updated":"2017-10-23 23:03:51.000000000","message":"this could be separate right, as it\u0027s done in the base playook now?  it might be better to split this into a different change to make this one less possible failure","commit_id":"b770db0c21b7bf107eb04f1e6a485dad3258dc6b"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"1b4d82e5d9bdbf799770e8a5583af3c88eea052f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"EOF"},{"line_number":23,"context_line":"chmod 0440 /etc/sudoers.d/zuul-sudo-grep"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"visudo -c || die \"Error setting zuul sudo!\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# this was copied from outside the chroot by extras.d"},{"line_number":28,"context_line":"_pub_key\u003d/tmp/in_target.d/zuul-user-ssh-public-key"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa0c359_7a6f3cc5","side":"PARENT","line":25,"in_reply_to":"3f4b6375_2eba6b09","updated":"2018-02-05 20:45:25.000000000","message":"done in https://review.openstack.org/541000","commit_id":"b770db0c21b7bf107eb04f1e6a485dad3258dc6b"}]}