)]}'
{"roles/submit-log-processor-jobs/library/submit_log_processor_jobs.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"cfcebff7f78d565d45116bafe21e6c85fe63049b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"class File(object):"},{"line_number":40,"context_line":"    def __init__(self, name, tags):"},{"line_number":41,"context_line":"        # Note that even if we upload a .gz we want to use the logical"},{"line_number":42,"context_line":"        # non compressed name for handling (it is easier on humans)."},{"line_number":43,"context_line":"        if name.endswith(\u0027.gz\u0027):"},{"line_number":44,"context_line":"            self._name \u003d name[:-3]"},{"line_number":45,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_6d4bfb86","line":42,"updated":"2017-10-31 20:02:46.000000000","message":"I probably would make the point in this comment that you\u0027re building up the log_url from this below, and that our configuration of apache is going to return the same content for the .gz v no-.gz ... i know you mention this in the cl but it is quite weird reading this that we can change the filename and it still works","commit_id":"cba0f2f11fdb117b8588fff4281655f8b6fed32c"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"65a89a68f8283ebe46c6732a21388c877f04ec09","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def __init__(self, name, tags):"},{"line_number":41,"context_line":"        # Note that even if we upload a .gz we want to use the logical"},{"line_number":42,"context_line":"        # non compressed name for handling (it is easier on humans)."},{"line_number":43,"context_line":"        if name.endswith(\u0027.gz\u0027):"},{"line_number":44,"context_line":"            self._name \u003d name[:-3]"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            self._name \u003d name"},{"line_number":47,"context_line":"        self._tags \u003d tags"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_de773b3b","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":34},"updated":"2017-10-31 15:55:39.000000000","message":"This is optimistic, it would match \"file.tar.gz\" and end up naming the file \"file.tar\"","commit_id":"cba0f2f11fdb117b8588fff4281655f8b6fed32c"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"243c925b45bc0f92f009939d2060f0c09b9b45ad","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def __init__(self, name, tags):"},{"line_number":41,"context_line":"        # Note that even if we upload a .gz we want to use the logical"},{"line_number":42,"context_line":"        # non compressed name for handling (it is easier on humans)."},{"line_number":43,"context_line":"        if name.endswith(\u0027.gz\u0027):"},{"line_number":44,"context_line":"            self._name \u003d name[:-3]"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            self._name \u003d name"},{"line_number":47,"context_line":"        self._tags \u003d tags"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_a1ea22d5","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":34},"in_reply_to":"3f4b6375_de773b3b","updated":"2017-10-31 16:33:43.000000000","message":"Yes, but we shouldn\u0027t ever index a tarball so I think that is an error either way.\n\nLogically some_log_file.txt and some_log_file.txt.gz are the same entity, its just how they are stored at rest that differs. Elasticsearch doesn\u0027t care about how it is stored at rest it cares about the contents and attributes and since we already have years of queries that assume they are dealing with the non .gz suffix in elasticsearch I went for backward compatibility here.","commit_id":"cba0f2f11fdb117b8588fff4281655f8b6fed32c"}]}