)]}'
{"tools/zuul-projects-checks.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ecb458f8da00d870caa9286b2e9fdda628239651","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    errors \u003d check_projects_sorted() or errors"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    if errors:"},{"line_number":77,"context_line":"        print(\"\\nFound errors in zuul.d/projects.yaml!\")"},{"line_number":78,"context_line":"    else:"},{"line_number":79,"context_line":"        print(\"\\nNo errors found in zuul.d/projects.yaml!\")"},{"line_number":80,"context_line":"    return errors"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_ff7ba377","side":"PARENT","line":77,"updated":"2017-11-04 14:56:44.000000000","message":"Might add a \\n at the end of this print to better separate the result from the following tasks.","commit_id":"8d72bd7a2d0694762f0654f92b15c3237608822f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ecb458f8da00d870caa9286b2e9fdda628239651","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        found \u003d []"},{"line_number":98,"context_line":"        for tmpl in project[\u0027templates\u0027]:"},{"line_number":99,"context_line":"            if tmpl in release_templates:"},{"line_number":100,"context_line":"                found.append(tmpl)"},{"line_number":101,"context_line":"        if len(found) \u003e 1:"},{"line_number":102,"context_line":"            errors \u003d True"},{"line_number":103,"context_line":"            print(\"  ERROR: Found multiple release jobs for %s:\" % name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_9fab8fd4","line":100,"updated":"2017-11-04 14:56:44.000000000","message":"This looks a bit unpythonic to me, how about constructing the array directly:\n\nfound \u003d [tmpl for tmpl in project[\u0027templates\u0027]\n         if tmpl in release_templates]","commit_id":"538d22f1d3723943a995bbf74391e5f58c3b115c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ecb458f8da00d870caa9286b2e9fdda628239651","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    errors \u003d check_system_templates()"},{"line_number":116,"context_line":"    errors \u003d check_projects_sorted() or errors"},{"line_number":117,"context_line":"    errors \u003d check_release_jobs()"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    if errors:"},{"line_number":120,"context_line":"        print(\"\\nFound errors in zuul.d/projects.yaml!\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_5fb19743","line":117,"updated":"2017-11-04 14:56:44.000000000","message":"Add \"... or errors\" lest you want to overwrite the previous results.\n\nOr maybe make it a single assignment or-ing the three check calls.","commit_id":"538d22f1d3723943a995bbf74391e5f58c3b115c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ecb458f8da00d870caa9286b2e9fdda628239651","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    if errors:"},{"line_number":120,"context_line":"        print(\"\\nFound errors in zuul.d/projects.yaml!\")"},{"line_number":121,"context_line":"    else:"},{"line_number":122,"context_line":"        print(\"\\nNo errors found in zuul.d/projects.yaml!\")"},{"line_number":123,"context_line":"    return errors"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_df7ea768","line":122,"updated":"2017-11-04 14:56:44.000000000","message":"Dito","commit_id":"538d22f1d3723943a995bbf74391e5f58c3b115c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"66781ab2880394c285fe22d0e3b12bf331b0a2b5","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    for entry in projects:"},{"line_number":95,"context_line":"        project \u003d entry[\u0027project\u0027]"},{"line_number":96,"context_line":"        name \u003d project[\u0027name\u0027]"},{"line_number":97,"context_line":"        found \u003d []"},{"line_number":98,"context_line":"        found \u003d [tmpl for tmpl in project[\u0027templates\u0027]"},{"line_number":99,"context_line":"                 if tmpl in release_templates]"},{"line_number":100,"context_line":"        if len(found) \u003e 1:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_0b82c100","line":97,"updated":"2017-11-05 07:21:07.000000000","message":"This is still redundant with the line below","commit_id":"5de98a78e11e1dfd66224a50b1579c8a9092c2fd"}]}