)]}'
{"jenkins/scripts/common.sh":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6c5485359592438641f1143c6c3fe36a18cb848e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    if [ -n \"$previous\" ]; then"},{"line_number":47,"context_line":"        CHANGE_ID\u003d$(echo \"$change_info\" | grep \"^change\" | awk \u0027{print $2}\u0027)"},{"line_number":48,"context_line":"        CHANGE_URL\u003d$(echo \"$change_info\" | grep \"url:\" | awk \u0027{print $2}\u0027)"},{"line_number":49,"context_line":"        CHANGE_NUM\u003d${CHANGE_URL##*/}"},{"line_number":50,"context_line":"        # read returns a non zero value when it reaches EOF. Because we use a"},{"line_number":51,"context_line":"        # heredoc here it will always reach EOF and return a nonzero value."},{"line_number":52,"context_line":"        # Disable -e temporarily to get around the read."}],"source_content_type":"text/x-sh","patch_set":5,"id":"1f485f77_b044881c","line":49,"updated":"2017-11-15 03:36:43.000000000","message":"isn\u0027t this the same thing as \"previous\"?  why go via the URL? I don\u0027t see CHANGE_URL is actually used anywhere so why export it?","commit_id":"ee291399909a43d3f6003037b15130caef5076a5"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a44b67e8d359f6597ad7719f39466204fecaf522","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    if [ -n \"$previous\" ]; then"},{"line_number":47,"context_line":"        CHANGE_ID\u003d$(echo \"$change_info\" | grep \"^change\" | awk \u0027{print $2}\u0027)"},{"line_number":48,"context_line":"        CHANGE_URL\u003d$(echo \"$change_info\" | grep \"url:\" | awk \u0027{print $2}\u0027)"},{"line_number":49,"context_line":"        CHANGE_NUM\u003d${CHANGE_URL##*/}"},{"line_number":50,"context_line":"        # read returns a non zero value when it reaches EOF. Because we use a"},{"line_number":51,"context_line":"        # heredoc here it will always reach EOF and return a nonzero value."},{"line_number":52,"context_line":"        # Disable -e temporarily to get around the read."}],"source_content_type":"text/x-sh","patch_set":5,"id":"1f485f77_b05fe870","line":49,"in_reply_to":"1f485f77_b038083d","updated":"2017-11-15 04:03:18.000000000","message":"Ah, good catch on \u0027number\u0027. I will use that.","commit_id":"ee291399909a43d3f6003037b15130caef5076a5"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e4c7532ae32d0abce69f28e4d1b62fb12d2c535f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    if [ -n \"$previous\" ]; then"},{"line_number":47,"context_line":"        CHANGE_ID\u003d$(echo \"$change_info\" | grep \"^change\" | awk \u0027{print $2}\u0027)"},{"line_number":48,"context_line":"        CHANGE_URL\u003d$(echo \"$change_info\" | grep \"url:\" | awk \u0027{print $2}\u0027)"},{"line_number":49,"context_line":"        CHANGE_NUM\u003d${CHANGE_URL##*/}"},{"line_number":50,"context_line":"        # read returns a non zero value when it reaches EOF. Because we use a"},{"line_number":51,"context_line":"        # heredoc here it will always reach EOF and return a nonzero value."},{"line_number":52,"context_line":"        # Disable -e temporarily to get around the read."}],"source_content_type":"text/x-sh","patch_set":5,"id":"1f485f77_b038083d","line":49,"in_reply_to":"1f485f77_b044881c","updated":"2017-11-15 04:00:33.000000000","message":"Okay, I can make it a local","commit_id":"ee291399909a43d3f6003037b15130caef5076a5"}],"jenkins/scripts/propose_update.sh":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"206e7baa74285f63a1144b2159711c30eca5e0c5","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        popd"},{"line_number":167,"context_line":"        if [ \"$RET\" -ne \"0\" ] ; then"},{"line_number":168,"context_line":"            ALL_SUCCESS\u003d1"},{"line_number":169,"context_line":"            echo \"Error in git review --force-rebase -d ${CHANGE_NUM} : Ignoring $PROJECT\""},{"line_number":170,"context_line":"            continue"},{"line_number":171,"context_line":"        fi"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1f485f77_219614f2","line":169,"updated":"2017-11-15 00:49:11.000000000","message":"In reality if the rebase fails, probably should continue on as if we don\u0027t have an existing change...","commit_id":"37dfca43ff4b0df2b5abf325f70e738037b50bd7"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6c5485359592438641f1143c6c3fe36a18cb848e","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            # Ignore errors we get in case we can\u0027t download the patch with"},{"line_number":163,"context_line":"            # git-review. If that happens then we will submit a new patch."},{"line_number":164,"context_line":"            set +e"},{"line_number":165,"context_line":"            git review --no-rebase -d ${CHANGE_NUM}"},{"line_number":166,"context_line":"            RET\u003d$?"},{"line_number":167,"context_line":"            if [[ \"$RET\" -eq 0 ]]; then"},{"line_number":168,"context_line":"                PREV_PATCH_ID\u003d$(git show | git patch-id | awk \u0027{print $1}\u0027)"}],"source_content_type":"text/x-sh","patch_set":5,"id":"1f485f77_b0a808db","line":165,"updated":"2017-11-15 03:36:43.000000000","message":"does \"--no-rebase\" actually do anything in the \"download a patch\" option?  i\u0027m pretty sure i\u0027ve never seen -d try to rebase","commit_id":"ee291399909a43d3f6003037b15130caef5076a5"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e4c7532ae32d0abce69f28e4d1b62fb12d2c535f","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            # Ignore errors we get in case we can\u0027t download the patch with"},{"line_number":163,"context_line":"            # git-review. If that happens then we will submit a new patch."},{"line_number":164,"context_line":"            set +e"},{"line_number":165,"context_line":"            git review --no-rebase -d ${CHANGE_NUM}"},{"line_number":166,"context_line":"            RET\u003d$?"},{"line_number":167,"context_line":"            if [[ \"$RET\" -eq 0 ]]; then"},{"line_number":168,"context_line":"                PREV_PATCH_ID\u003d$(git show | git patch-id | awk \u0027{print $1}\u0027)"}],"source_content_type":"text/x-sh","patch_set":5,"id":"1f485f77_703a9034","line":165,"in_reply_to":"1f485f77_b0a808db","updated":"2017-11-15 04:00:33.000000000","message":"Well when I read the docs it claims that \u0027rebase\u0027 was the default. So I figured to be safe, don\u0027t rebase.\n\nBut reading more it appears that only happens when submitting the change.","commit_id":"ee291399909a43d3f6003037b15130caef5076a5"}]}