)]}'
{"jenkins/scripts/release-tools/functions":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"ec91bcfc0d5997229420dc91ad3efdab5d01e167","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    if ! git diff --exit-code \u003e/dev/null 2\u003e\u00261 ; then"},{"line_number":92,"context_line":"        git add tox.ini"},{"line_number":93,"context_line":"        msg\u003d\"Update UPPER_CONSTRAINTS_FILE for $branch\""},{"line_number":94,"context_line":"        body\u003d\"This depends on the openstack/requirements repository being \\"},{"line_number":95,"context_line":"             branched, which occurs around the RC1 timeframe.\""},{"line_number":96,"context_line":"        git commit -m \"$msg\" -m \"$body\""},{"line_number":97,"context_line":"        git show"},{"line_number":98,"context_line":"        local shortbranch\u003d$(basename $branch)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa0c359_6088e3c5","line":95,"range":{"start_line":94,"start_character":8,"end_line":95,"end_character":61},"updated":"2018-02-06 07:24:49.000000000","message":"Can we rework it ?\n\nWhat about:\n\nThe new stable upper-constraints file is only available once the openstack/requirements repository is branched as well. This will happen around the RC1 timeframe.\n\nRecheck and merge this change once the requirements repository has branched.","commit_id":"cbadde87dc3643d7a4b358c47239ab85a74e887d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0a7203e177ed3085f54eb3411afb9314eecd8556","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    if ! git diff --exit-code \u003e/dev/null 2\u003e\u00261 ; then"},{"line_number":92,"context_line":"        git add tox.ini"},{"line_number":93,"context_line":"        msg\u003d\"Update UPPER_CONSTRAINTS_FILE for $branch\""},{"line_number":94,"context_line":"        body\u003d\"This depends on the openstack/requirements repository being \\"},{"line_number":95,"context_line":"             branched, which occurs around the RC1 timeframe.\""},{"line_number":96,"context_line":"        git commit -m \"$msg\" -m \"$body\""},{"line_number":97,"context_line":"        git show"},{"line_number":98,"context_line":"        local shortbranch\u003d$(basename $branch)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa0c359_1bcce9ba","line":95,"range":{"start_line":94,"start_character":8,"end_line":95,"end_character":61},"in_reply_to":"3fa0c359_6088e3c5","updated":"2018-02-06 14:25:25.000000000","message":"Thx for the suggestion. I didn\u0027t want to leave instructions (the \u0027Recheck and merge...\u0027) in the commit msg since that didn\u0027t seem appropriate for a commit, but ...\n\nThe formatting was incorrect too, so I think I fixed that.","commit_id":"cbadde87dc3643d7a4b358c47239ab85a74e887d"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"dfd1f07b7fd35a3608983ba05935b2a2a24facaf","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    if ! git diff --exit-code \u003e/dev/null 2\u003e\u00261 ; then"},{"line_number":92,"context_line":"        git add tox.ini"},{"line_number":93,"context_line":"        msg\u003d\"Update UPPER_CONSTRAINTS_FILE for $branch\""},{"line_number":94,"context_line":"    p1\u003d\u0027The new stable upper-constraints file is only available"},{"line_number":95,"context_line":"after the openstack/requirements repository is branched."},{"line_number":96,"context_line":"This will happen around the RC1 timeframe."},{"line_number":97,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa0c359_bbedb5f0","line":94,"updated":"2018-02-06 14:33:30.000000000","message":"I like the text but it\u0027s not at all clear to me how it\u0027s used. I think p1 here and $body on line 100 should be the same variable name but aren\u0027t?","commit_id":"061b514d9dbbf4ebd899b668671d3864afa86da1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1ab392875b585725c8a5ad9b2e9225b20e3567bf","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    if ! git diff --exit-code \u003e/dev/null 2\u003e\u00261 ; then"},{"line_number":92,"context_line":"        git add tox.ini"},{"line_number":93,"context_line":"        msg\u003d\"Update UPPER_CONSTRAINTS_FILE for $branch\""},{"line_number":94,"context_line":"    p1\u003d\u0027The new stable upper-constraints file is only available"},{"line_number":95,"context_line":"after the openstack/requirements repository is branched."},{"line_number":96,"context_line":"This will happen around the RC1 timeframe."},{"line_number":97,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa0c359_fb69fd24","line":94,"in_reply_to":"3fa0c359_bbedb5f0","updated":"2018-02-06 14:47:52.000000000","message":"Oops, I had broken it into 2 paragraphs, then decided not to but forgot to change it back to body. Thx for catching it!","commit_id":"061b514d9dbbf4ebd899b668671d3864afa86da1"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"dfd1f07b7fd35a3608983ba05935b2a2a24facaf","unresolved":false,"context_lines":[{"line_number":96,"context_line":"This will happen around the RC1 timeframe."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Recheck and merge this change once the requirements"},{"line_number":99,"context_line":"repository has been branched.\u0027"},{"line_number":100,"context_line":"        git commit -m \"$msg\" -m \"$body\""},{"line_number":101,"context_line":"        git show"},{"line_number":102,"context_line":"        local shortbranch\u003d$(basename $branch)"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa0c359_9b9eb961","line":99,"updated":"2018-02-06 14:33:30.000000000","message":"We could also add this detail:\n\n  The CI system will work with this patch before the requirements repository\n  is branched because zuul configures the job to run with a local copy of the file\n  and defaults to the master branch. However, accepting the patch will break\n  the test configuration on developers\u0027 local systems, so please wait until\n  after the requirements repository is branched to merge the patch.","commit_id":"061b514d9dbbf4ebd899b668671d3864afa86da1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1ab392875b585725c8a5ad9b2e9225b20e3567bf","unresolved":false,"context_lines":[{"line_number":96,"context_line":"This will happen around the RC1 timeframe."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Recheck and merge this change once the requirements"},{"line_number":99,"context_line":"repository has been branched.\u0027"},{"line_number":100,"context_line":"        git commit -m \"$msg\" -m \"$body\""},{"line_number":101,"context_line":"        git show"},{"line_number":102,"context_line":"        local shortbranch\u003d$(basename $branch)"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa0c359_7b9acd14","line":99,"in_reply_to":"3fa0c359_9b9eb961","updated":"2018-02-06 14:47:52.000000000","message":"Done","commit_id":"061b514d9dbbf4ebd899b668671d3864afa86da1"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"a257c10fba6abad8cc544522de0a8d1223ba3fa9","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    if ! git diff --exit-code \u003e/dev/null 2\u003e\u00261 ; then"},{"line_number":92,"context_line":"        git add tox.ini"},{"line_number":93,"context_line":"        msg\u003d\"Update UPPER_CONSTRAINTS_FILE for $branch\""},{"line_number":94,"context_line":"    body\u003d\u0027The new stable upper-constraints file is only available"},{"line_number":95,"context_line":"after the openstack/requirements repository is branched."},{"line_number":96,"context_line":"This will happen around the RC1 timeframe."},{"line_number":97,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fa0c359_46ddb812","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":4},"updated":"2018-02-06 15:21:41.000000000","message":"nit: the indentation doesn\u0027t match here","commit_id":"57c12fe6ccfe3d02d5727af77c8c30540bf8743f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d903a99cde6eefa01a3b5ace55b85dee55db2710","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    if ! git diff --exit-code \u003e/dev/null 2\u003e\u00261 ; then"},{"line_number":92,"context_line":"        git add tox.ini"},{"line_number":93,"context_line":"        msg\u003d\"Update UPPER_CONSTRAINTS_FILE for $branch\""},{"line_number":94,"context_line":"    body\u003d\u0027The new stable upper-constraints file is only available"},{"line_number":95,"context_line":"after the openstack/requirements repository is branched."},{"line_number":96,"context_line":"This will happen around the RC1 timeframe."},{"line_number":97,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fa0c359_d9ae862d","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":4},"in_reply_to":"3fa0c359_46ddb812","updated":"2018-02-06 18:59:20.000000000","message":"Done","commit_id":"57c12fe6ccfe3d02d5727af77c8c30540bf8743f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"a257c10fba6abad8cc544522de0a8d1223ba3fa9","unresolved":false,"context_lines":[{"line_number":102,"context_line":"repository is branched because zuul configues the job to run"},{"line_number":103,"context_line":"with a local copy of the file and defaults to the master branch."},{"line_number":104,"context_line":"However, accepting the patch will break the test configuration"},{"line_number":105,"context_line":"on developers\u0027 local systems, so please wait until after the"},{"line_number":106,"context_line":"requirements repository is branched to merge the patch.\u0027"},{"line_number":107,"context_line":"        git commit -m \"$msg\" -m \"$body\""},{"line_number":108,"context_line":"        git show"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fa0c359_e6cde45d","line":105,"range":{"start_line":105,"start_character":12,"end_line":105,"end_character":15},"updated":"2018-02-06 15:21:41.000000000","message":"it looks like this extra single quote as an apostrophe is going to cause trouble with the single quotes around the body string. Maybe use double quotes there?","commit_id":"57c12fe6ccfe3d02d5727af77c8c30540bf8743f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d903a99cde6eefa01a3b5ace55b85dee55db2710","unresolved":false,"context_lines":[{"line_number":102,"context_line":"repository is branched because zuul configues the job to run"},{"line_number":103,"context_line":"with a local copy of the file and defaults to the master branch."},{"line_number":104,"context_line":"However, accepting the patch will break the test configuration"},{"line_number":105,"context_line":"on developers\u0027 local systems, so please wait until after the"},{"line_number":106,"context_line":"requirements repository is branched to merge the patch.\u0027"},{"line_number":107,"context_line":"        git commit -m \"$msg\" -m \"$body\""},{"line_number":108,"context_line":"        git show"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fa0c359_596836f4","line":105,"range":{"start_line":105,"start_character":12,"end_line":105,"end_character":15},"in_reply_to":"3fa0c359_e6cde45d","updated":"2018-02-06 18:59:20.000000000","message":"Yup, it does cause trouble. Gad, of course, I was too lazy to test it :-(","commit_id":"57c12fe6ccfe3d02d5727af77c8c30540bf8743f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"a257c10fba6abad8cc544522de0a8d1223ba3fa9","unresolved":false,"context_lines":[{"line_number":104,"context_line":"However, accepting the patch will break the test configuration"},{"line_number":105,"context_line":"on developers\u0027 local systems, so please wait until after the"},{"line_number":106,"context_line":"requirements repository is branched to merge the patch.\u0027"},{"line_number":107,"context_line":"        git commit -m \"$msg\" -m \"$body\""},{"line_number":108,"context_line":"        git show"},{"line_number":109,"context_line":"        local shortbranch\u003d$(basename $branch)"},{"line_number":110,"context_line":"        git review -t \"create-${shortbranch}\" --yes"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fa0c359_86f3c09e","line":107,"updated":"2018-02-06 15:21:41.000000000","message":"TIL that -m can be passed multiple times. Thanks. :-)","commit_id":"57c12fe6ccfe3d02d5727af77c8c30540bf8743f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"57f41dd84dc15c2fa77ef84bfca26396ade18e57","unresolved":false,"context_lines":[{"line_number":104,"context_line":"However, accepting the patch will break the test configuration"},{"line_number":105,"context_line":"on developers\u0027 local systems, so please wait until after the"},{"line_number":106,"context_line":"requirements repository is branched to merge the patch.\u0027"},{"line_number":107,"context_line":"        git commit -m \"$msg\" -m \"$body\""},{"line_number":108,"context_line":"        git show"},{"line_number":109,"context_line":"        local shortbranch\u003d$(basename $branch)"},{"line_number":110,"context_line":"        git review -t \"create-${shortbranch}\" --yes"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fa0c359_fcb570ef","line":107,"in_reply_to":"3fa0c359_3931aa0c","updated":"2018-02-06 19:25:07.000000000","message":"I like using multiple options here, I just didn\u0027t know that was allowed.","commit_id":"57c12fe6ccfe3d02d5727af77c8c30540bf8743f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d903a99cde6eefa01a3b5ace55b85dee55db2710","unresolved":false,"context_lines":[{"line_number":104,"context_line":"However, accepting the patch will break the test configuration"},{"line_number":105,"context_line":"on developers\u0027 local systems, so please wait until after the"},{"line_number":106,"context_line":"requirements repository is branched to merge the patch.\u0027"},{"line_number":107,"context_line":"        git commit -m \"$msg\" -m \"$body\""},{"line_number":108,"context_line":"        git show"},{"line_number":109,"context_line":"        local shortbranch\u003d$(basename $branch)"},{"line_number":110,"context_line":"        git review -t \"create-${shortbranch}\" --yes"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fa0c359_3931aa0c","line":107,"in_reply_to":"3fa0c359_86f3c09e","updated":"2018-02-06 18:59:20.000000000","message":"I can change it to one msg too, but maybe it is good to use the two -m\u0027s, so others can see the usage of that.","commit_id":"57c12fe6ccfe3d02d5727af77c8c30540bf8743f"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"201ce13734cee2b6f8043e50c5b1bfb32949c69f","unresolved":false,"context_lines":[{"line_number":104,"context_line":"However, accepting the patch will break the test configuration"},{"line_number":105,"context_line":"on developers\u0027 local systems, so please wait until after the"},{"line_number":106,"context_line":"requirements repository is branched to merge the patch.\""},{"line_number":107,"context_line":"        git commit -m \"$msg\" -m \"$body\""},{"line_number":108,"context_line":"        git show"},{"line_number":109,"context_line":"        local shortbranch\u003d$(basename $branch)"},{"line_number":110,"context_line":"        git review -t \"create-${shortbranch}\" --yes"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3fa0c359_0f758095","line":107,"updated":"2018-02-06 19:58:18.000000000","message":"Wow, what a story ;)","commit_id":"eb22332f7825009a289eccb7034493c545a58f08"}]}
