)]}'
{"nodepool/elements/nodepool-base/finalise.d/89-unbound":[{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"77cf7b75e24de18958d2f3b97419ada112f11754","unresolved":false,"context_lines":[{"line_number":116,"context_line":"sed -i -e \u0027s/^NETCONFIG_DNS_POLICY\u003d.*/NETCONFIG_DNS_POLICY\u003d\"\"/g\u0027 /etc/sysconfig/network/config"},{"line_number":117,"context_line":"set -e"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"if [ -L /etc/resolv.conf ] ; then"},{"line_number":120,"context_line":"    # On some systems (like those using systemd resolved /etc/resolv.conf"},{"line_number":121,"context_line":"    # will be a symlink to a systemd managed location. We want to"},{"line_number":122,"context_line":"    # just use localhost as a resolver so we remove the link then"},{"line_number":123,"context_line":"    # explicitly write what we want to /etc/resolv.conf."},{"line_number":124,"context_line":"    rm /etc/resolv.conf"},{"line_number":125,"context_line":"fi"},{"line_number":126,"context_line":"echo \u0027nameserver 127.0.0.1\u0027 \u003e /etc/resolv.conf"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"exit 0"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bf659307_ca4953b7","line":125,"range":{"start_line":119,"start_character":0,"end_line":125,"end_character":2},"updated":"2018-03-29 22:29:31.000000000","message":"we should be able to do then around line 177 too. And remove the symlink from the image before we create it.  It looks like it is added when we install resolvconf package:\n\nhttp://manpages.ubuntu.com/manpages/bionic/man8/resolvconf.8.html","commit_id":"c974126480d72955e3b0d64551442cd0549bc6b6"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3256b29b201ba95eb197e065345028f5e1ea4876","unresolved":false,"context_lines":[{"line_number":168,"context_line":"EOF"},{"line_number":169,"context_line":"fi"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"if [ -L /etc/resolv.conf ] ; then"},{"line_number":172,"context_line":"    # On some systems (like ubuntu bionic) /etc/resolv.conf"},{"line_number":173,"context_line":"    # will be a symlink to a /run location which is a tmpfs mounted by"},{"line_number":174,"context_line":"    # sytemd. This is done so that resolvconf can do its job."}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bf659307_827b1426","line":171,"updated":"2018-04-02 22:04:04.000000000","message":"my concern here is -- what made this a symlink?  resolvconf package presumably, during the dib install portion?\n\nwhat brought in resolvconf?  is it a base dependency?\n\nwhat\u0027s going to stop it running, and overwriting this again?","commit_id":"1431cefe0d2e60a79aa3eb0885928c414666141c"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"5384b00aeb0fdaf9db15df3f9c43c5868199737c","unresolved":false,"context_lines":[{"line_number":168,"context_line":"EOF"},{"line_number":169,"context_line":"fi"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"if [ -L /etc/resolv.conf ] ; then"},{"line_number":172,"context_line":"    # On some systems (like ubuntu bionic) /etc/resolv.conf"},{"line_number":173,"context_line":"    # will be a symlink to a /run location which is a tmpfs mounted by"},{"line_number":174,"context_line":"    # sytemd. This is done so that resolvconf can do its job."}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bf659307_42a65cad","line":171,"in_reply_to":"bf659307_827b1426","updated":"2018-04-02 22:08:18.000000000","message":"yes, resolvconf does it on installation.\n\nhttp://manpages.ubuntu.com/manpages/bionic/man8/resolvconf.8.html\n\nWhich has been a dependency for some time, but suspect the latest version added this function.","commit_id":"1431cefe0d2e60a79aa3eb0885928c414666141c"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"b83fd2147e8ef34b8eccf401b1ffb44cbb3d6012","unresolved":false,"context_lines":[{"line_number":179,"context_line":"# dib saves /etc/resolv.conf after the initial install and replaces it"},{"line_number":180,"context_line":"# with a copy from the building host (so networking works during"},{"line_number":181,"context_line":"# element runs).  Thus we check if the saved link is to"},{"line_number":182,"context_line":"# systemd-resolved compatability files; if so, replace that with a"},{"line_number":183,"context_line":"# plain file.  dib will copy this back over during image creation, and"},{"line_number":184,"context_line":"# the final image will end up with a regular file."},{"line_number":185,"context_line":"#"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bf659307_a94b3fae","line":182,"updated":"2018-04-06 15:46:40.000000000","message":"To be extra clear the saving of /etc/resolv.conf happens after the initial install which is what puts the resolved symlink in place? Want to make sure that we got the order of things correctly so that we end up with a successful conditional for bionic below.\n\nSpecifically worried that if resolved installation of symlink happens after dib has replaced the build\u0027s /etc/resolv.conf it won\u0027t write a symlink at all  and then we\u0027ll put the old ORIG back which is not going to be 127.0.0.1 likely.","commit_id":"50329d4ac509270b19b38c13f3c8956391b61bf5"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"44aaea48e201a3eec82cad1195c20557a9dacc30","unresolved":false,"context_lines":[{"line_number":179,"context_line":"# dib saves /etc/resolv.conf after the initial install and replaces it"},{"line_number":180,"context_line":"# with a copy from the building host (so networking works during"},{"line_number":181,"context_line":"# element runs).  Thus we check if the saved link is to"},{"line_number":182,"context_line":"# systemd-resolved compatability files; if so, replace that with a"},{"line_number":183,"context_line":"# plain file.  dib will copy this back over during image creation, and"},{"line_number":184,"context_line":"# the final image will end up with a regular file."},{"line_number":185,"context_line":"#"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bf659307_0f458b70","line":182,"in_reply_to":"bf659307_0c3a79e6","updated":"2018-04-06 17:14:07.000000000","message":"yah, I\u0027d like to see that myself.","commit_id":"50329d4ac509270b19b38c13f3c8956391b61bf5"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"eaeaaea2f00632c49f8a85858ba4b7820534cd8a","unresolved":false,"context_lines":[{"line_number":179,"context_line":"# dib saves /etc/resolv.conf after the initial install and replaces it"},{"line_number":180,"context_line":"# with a copy from the building host (so networking works during"},{"line_number":181,"context_line":"# element runs).  Thus we check if the saved link is to"},{"line_number":182,"context_line":"# systemd-resolved compatability files; if so, replace that with a"},{"line_number":183,"context_line":"# plain file.  dib will copy this back over during image creation, and"},{"line_number":184,"context_line":"# the final image will end up with a regular file."},{"line_number":185,"context_line":"#"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bf659307_0c3a79e6","line":182,"in_reply_to":"bf659307_4c62b118","updated":"2018-04-06 16:30:17.000000000","message":"Maybe we can cleanup some of the rc.local script above in that case too?","commit_id":"50329d4ac509270b19b38c13f3c8956391b61bf5"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"acb83cddacbe51ba7f294b5e56a652b0ec819940","unresolved":false,"context_lines":[{"line_number":179,"context_line":"# dib saves /etc/resolv.conf after the initial install and replaces it"},{"line_number":180,"context_line":"# with a copy from the building host (so networking works during"},{"line_number":181,"context_line":"# element runs).  Thus we check if the saved link is to"},{"line_number":182,"context_line":"# systemd-resolved compatability files; if so, replace that with a"},{"line_number":183,"context_line":"# plain file.  dib will copy this back over during image creation, and"},{"line_number":184,"context_line":"# the final image will end up with a regular file."},{"line_number":185,"context_line":"#"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bf659307_07f31da0","line":182,"in_reply_to":"bf659307_a94b3fae","updated":"2018-04-09 05:10:29.000000000","message":"\u003e To be extra clear the saving of /etc/resolv.conf happens after the initial install which is what puts the resolved symlink in place?\n\nyes\n\n1) initial install into chroot environment\n1a) systemd-resolved adds the link during this\n2) move any generated /etc/resolv.conf generated by that to the ORIG file\n3) copy in the host system\u0027s version\n\nbut, it\u0027s a fair point that in this script, we can just always save in 127.0.0.1 to the resolv.conf unconditionally and remove the check","commit_id":"50329d4ac509270b19b38c13f3c8956391b61bf5"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"4bf5689ce598956667a402a976223085b047ed7d","unresolved":false,"context_lines":[{"line_number":179,"context_line":"# dib saves /etc/resolv.conf after the initial install and replaces it"},{"line_number":180,"context_line":"# with a copy from the building host (so networking works during"},{"line_number":181,"context_line":"# element runs).  Thus we check if the saved link is to"},{"line_number":182,"context_line":"# systemd-resolved compatability files; if so, replace that with a"},{"line_number":183,"context_line":"# plain file.  dib will copy this back over during image creation, and"},{"line_number":184,"context_line":"# the final image will end up with a regular file."},{"line_number":185,"context_line":"#"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bf659307_4c62b118","line":182,"in_reply_to":"bf659307_a94b3fae","updated":"2018-04-06 16:27:17.000000000","message":"I\u0027m actually trying to see why we check ORIG, why don\u0027t we just set it remove it and default to 127.0.0.1 for all distros.\n\nThat way, we\u0027ll build qcow2 for all images with that the default, regardless of systemd or resolved.","commit_id":"50329d4ac509270b19b38c13f3c8956391b61bf5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"04f628aa4fdc68aacd4470f4d9b1e0b8e36a32f6","unresolved":false,"context_lines":[{"line_number":182,"context_line":"#"},{"line_number":183,"context_line":"# Note that with /etc/resolv.conf as a regular file, systemd-resolved"},{"line_number":184,"context_line":"# will also obey it for nameserver info when it starts at boot."},{"line_number":185,"context_line":"rm -rf /etc/resolv.conf.ORIG"},{"line_number":186,"context_line":"echo \"nameserver 127.0.0.1\" \u003e /etc/resolv.conf.ORIG"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"case \"$DIB_INIT_SYSTEM\" in"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bf659307_3d40b035","line":185,"updated":"2018-04-09 06:53:47.000000000","message":"I can\u0027t think of a situation where the \"-r\" would make sense, just \"-f\" should be enough.","commit_id":"abcc8773a681ed45d84087026895961da884008a"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"69d8719d1be4a8f61b568104f40391b74094d0aa","unresolved":false,"context_lines":[{"line_number":182,"context_line":"#"},{"line_number":183,"context_line":"# Note that with /etc/resolv.conf as a regular file, systemd-resolved"},{"line_number":184,"context_line":"# will also obey it for nameserver info when it starts at boot."},{"line_number":185,"context_line":"rm -rf /etc/resolv.conf.ORIG"},{"line_number":186,"context_line":"echo \"nameserver 127.0.0.1\" \u003e /etc/resolv.conf.ORIG"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"case \"$DIB_INIT_SYSTEM\" in"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bf659307_dd9734eb","line":185,"in_reply_to":"bf659307_3d40b035","updated":"2018-04-09 07:32:54.000000000","message":"Done","commit_id":"abcc8773a681ed45d84087026895961da884008a"}]}