)]}'
{"nodepool/elements/nodepool-base/post-install.d/20-iptables":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"62204dda4df853f3fe82229f09a11be52b1b8d92","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        # nothing to do"},{"line_number":45,"context_line":"        ;;"},{"line_number":46,"context_line":"    systemd)"},{"line_number":47,"context_line":"        systemctl enable ${service_name}.service"},{"line_number":48,"context_line":"        if [[ \"$DISTRO_NAME\" \u003d~ (centos|fedora) ]] ; then"},{"line_number":49,"context_line":"            systemctl enable ip6tables.service"},{"line_number":50,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f6a8fd7_83bbe1e3","side":"PARENT","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":48},"updated":"2018-04-16 06:14:59.000000000","message":"This enables it everywhere - this it not enabled in the new code for CentOS/Fedora.","commit_id":"d27f41461b85c1381028ef9bacd6b7483e068772"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"0272e1878d8e97e1912bb97d2147a268f28987fd","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        # nothing to do"},{"line_number":45,"context_line":"        ;;"},{"line_number":46,"context_line":"    systemd)"},{"line_number":47,"context_line":"        systemctl enable ${service_name}.service"},{"line_number":48,"context_line":"        if [[ \"$DISTRO_NAME\" \u003d~ (centos|fedora) ]] ; then"},{"line_number":49,"context_line":"            systemctl enable ip6tables.service"},{"line_number":50,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f6a8fd7_63afad94","side":"PARENT","line":47,"updated":"2018-04-16 06:17:48.000000000","message":"ok, my first patch was right then","commit_id":"d27f41461b85c1381028ef9bacd6b7483e068772"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"62204dda4df853f3fe82229f09a11be52b1b8d92","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            systemctl enable iptables-store.service"},{"line_number":49,"context_line":"            systemctl enable ip6tables-restore.service"},{"line_number":50,"context_line":"            systemctl enable ip6tables-store.service"},{"line_number":51,"context_line":"        elif [[ \"$DISTRO_NAME\" \u003d~ (centos|fedora) ]] ; then"},{"line_number":52,"context_line":"            systemctl enable ip6tables.service"},{"line_number":53,"context_line":"        else"},{"line_number":54,"context_line":"            systemctl enable ${service_name}.service"},{"line_number":55,"context_line":"        fi"},{"line_number":56,"context_line":"        ;;"},{"line_number":57,"context_line":"    openrc)"},{"line_number":58,"context_line":"        rc-update add ${service_name1} default"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f6a8fd7_e3ec1df5","line":55,"range":{"start_line":51,"start_character":0,"end_line":55,"end_character":10},"updated":"2018-04-16 06:14:59.000000000","message":"this is wrong, you do not enable {service_name}.service for centos/fedora anymore.","commit_id":"3f2aa4ee2cb1d549b56b6c701e7c47f2678fa084"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0efc4be40b8a61bd07fd8e73c2f315b5a6fbabc7","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            systemctl enable iptables-restore.service"},{"line_number":48,"context_line":"            systemctl enable iptables-store.service"},{"line_number":49,"context_line":"            systemctl enable ip6tables-restore.service"},{"line_number":50,"context_line":"            systemctl enable ip6tables-store.service"},{"line_number":51,"context_line":"        else"},{"line_number":52,"context_line":"            systemctl enable ${service_name}.service"},{"line_number":53,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9f6a8fd7_b23eb6b5","line":50,"updated":"2018-04-23 23:38:18.000000000","message":"Rather than list these out and make gentoo special, maybe just set these as the $service_name like all the other distros? We can `systemctl enable foo bar baz` to do more than one. Also I don\u0027t think the .service suffix is necessary as it is implied.","commit_id":"b8cd818fa0d9136b01ddda65bd7fa9bc0297ecab"}]}