)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"556101f7ab70f178265b5e051313537125967ef5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add Tripleo Ansible repo"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This repo is a TripleO Ansible project directory.  It contains"},{"line_number":10,"context_line":"playbooks for use with TripleO deployed clouds."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change also adds an ACL specifically for TripleO Ansible"},{"line_number":13,"context_line":"components, and changes relevant repos to use it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_e79d46ba","line":10,"updated":"2018-07-31 13:16:52.000000000","message":"I looked at https://github.com/jillr/tripleo-ansible and I fail to understand the difference between this repo and https://github.com/openstack/ansible-role-openstack-operations\n\ncan you explain a bit what\u0027s the plan?","commit_id":"a98390b62b3a0f0598073a662ea79572c611dec1"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"f8b0ee3a01cf087a0bde2e0a3f2bda01dba3fe02","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add Tripleo Ansible repo"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This repo is a TripleO Ansible project directory.  It contains"},{"line_number":10,"context_line":"playbooks for use with TripleO deployed clouds."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change also adds an ACL specifically for TripleO Ansible"},{"line_number":13,"context_line":"components, and changes relevant repos to use it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_7bec6abb","line":10,"in_reply_to":"5f7c97a3_0724025e","updated":"2018-07-31 18:01:43.000000000","message":"tripleo-ansible will be an ansible project directory.\n\nSee: https://docs.ansible.com/ansible/2.5/user_guide/playbooks_best_practices.html#directory-layout\n\nWe will use it for playbooks, callback plugins, custom modules, etc.\n\nIt\u0027s a different thing than an ansible role. See this for a sample role:\nhttps://docs.ansible.com/ansible/2.5/user_guide/playbooks_reuse_roles.html#role-directory-structure","commit_id":"a98390b62b3a0f0598073a662ea79572c611dec1"},{"author":{"_account_id":20868,"name":"Jill Rouleau","email":"jill.rouleau@bespokess.com","username":"jillr"},"change_message_id":"d3ffdcc110ab467cc8659b9201f16ad4d3ea423e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add Tripleo Ansible repo"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This repo is a TripleO Ansible project directory.  It contains"},{"line_number":10,"context_line":"playbooks for use with TripleO deployed clouds."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change also adds an ACL specifically for TripleO Ansible"},{"line_number":13,"context_line":"components, and changes relevant repos to use it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_4165c51b","line":10,"in_reply_to":"5f7c97a3_2f2227b8","updated":"2018-08-02 18:50:10.000000000","message":"Correct, so for example we wouldn\u0027t dump playbooks into tripleo-common any longer, and playbooks that use roles will reference them via import_role.","commit_id":"a98390b62b3a0f0598073a662ea79572c611dec1"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"93e835ab27f0923fc156bfda5859568bb1e76353","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add Tripleo Ansible repo"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This repo is a TripleO Ansible project directory.  It contains"},{"line_number":10,"context_line":"playbooks for use with TripleO deployed clouds."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change also adds an ACL specifically for TripleO Ansible"},{"line_number":13,"context_line":"components, and changes relevant repos to use it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_2f2227b8","line":10,"in_reply_to":"5f7c97a3_7bec6abb","updated":"2018-07-31 21:30:21.000000000","message":"So yea sounds like taking the ansible bits from all over the place and centralizing them in a single tripleo-ansible repo as part of a best practice.  The roles themselves would be referenced in some fashion via this project, correct?","commit_id":"a98390b62b3a0f0598073a662ea79572c611dec1"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"337497e4e0203b6ad9be46b13b396144f5fc307a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add Tripleo Ansible repo"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This repo is a TripleO Ansible project directory.  It contains"},{"line_number":10,"context_line":"playbooks for use with TripleO deployed clouds."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change also adds an ACL specifically for TripleO Ansible"},{"line_number":13,"context_line":"components, and changes relevant repos to use it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_db1fbeb5","line":10,"in_reply_to":"5f7c97a3_7bec6abb","updated":"2018-07-31 18:03:18.000000000","message":"another example...ceph-ansible is a project directory. that\u0027s the same sort of thing we\u0027re aiming for here.","commit_id":"a98390b62b3a0f0598073a662ea79572c611dec1"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"59a6437fbbf15d95af55a5d0d75aa720415626ed","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add Tripleo Ansible repo"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This repo is a TripleO Ansible project directory.  It contains"},{"line_number":10,"context_line":"playbooks for use with TripleO deployed clouds."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change also adds an ACL specifically for TripleO Ansible"},{"line_number":13,"context_line":"components, and changes relevant repos to use it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_0724025e","line":10,"in_reply_to":"5f7c97a3_e79d46ba","updated":"2018-07-31 13:20:24.000000000","message":"So I believe this should be the repo we move the various (random) ansible bits out of tripleo-common into.  ansible-role-openstack-operations should really just contain openstack related actions and not necessarily tripleo specific things.  It would be a good idea to explain this better to help people understand what should go where,","commit_id":"a98390b62b3a0f0598073a662ea79572c611dec1"}],"gerrit/acls/openstack/tripleo-ansible.config":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3452d73cfef4a60cf74a415fa0643898c7d86c27","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[access \"refs/heads/*\"]"},{"line_number":2,"context_line":"abandon \u003d group tripleo-ansible-core"},{"line_number":3,"context_line":"label-Code-Review \u003d -2..+2 group tripleo-ansible-core"},{"line_number":4,"context_line":"label-Verified \u003d -1..+1 group tripleo-ci"},{"line_number":5,"context_line":"label-Workflow \u003d -1..+1 group tripleo-ansible-core"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[receive]"}],"source_content_type":"text/x-ini","patch_set":3,"id":"5f7c97a3_623d7a8b","line":4,"updated":"2018-07-20 15:59:25.000000000","message":"I don\u0027t think we want tripleo-ci group here, it\u0027s tripleo-core.\n\nPlease look at gerrit/acls/openstack/tripleo-specs.config for an example.\nAlso, include the tripleo-ansible-core that you want to create.","commit_id":"26e296d4ac60270eae38f8e654919960bc1b6323"},{"author":{"_account_id":20868,"name":"Jill Rouleau","email":"jill.rouleau@bespokess.com","username":"jillr"},"change_message_id":"ff36af2d81e932dd2228a42593c2533db7d2fdce","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[access \"refs/heads/*\"]"},{"line_number":2,"context_line":"abandon \u003d group tripleo-ansible-core"},{"line_number":3,"context_line":"label-Code-Review \u003d -2..+2 group tripleo-ansible-core"},{"line_number":4,"context_line":"label-Verified \u003d -1..+1 group tripleo-ci"},{"line_number":5,"context_line":"label-Workflow \u003d -1..+1 group tripleo-ansible-core"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[receive]"}],"source_content_type":"text/x-ini","patch_set":3,"id":"5f7c97a3_c2148eec","line":4,"in_reply_to":"5f7c97a3_623d7a8b","updated":"2018-07-20 16:04:03.000000000","message":"OOC, why not tripleo-ci for these repos or specs when we do have it for the tripleo.config acl (which is what I\u0027ve copied from here)?\n\nThe tripleo-ansible-core gerrit group does already exist, is that what you mean?","commit_id":"26e296d4ac60270eae38f8e654919960bc1b6323"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"846fe8665590c03c50453e298cba410be18eca93","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[access \"refs/heads/*\"]"},{"line_number":2,"context_line":"abandon \u003d group tripleo-ansible-core"},{"line_number":3,"context_line":"label-Code-Review \u003d -2..+2 group tripleo-ansible-core"},{"line_number":4,"context_line":"label-Verified \u003d -1..+1 group tripleo-ci"},{"line_number":5,"context_line":"label-Workflow \u003d -1..+1 group tripleo-ansible-core"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[receive]"}],"source_content_type":"text/x-ini","patch_set":3,"id":"5f7c97a3_8e4c7d9d","line":4,"in_reply_to":"5f7c97a3_82b536d2","updated":"2018-07-20 19:10:50.000000000","message":"tripleo-core is already included in tripleo-ansible-core\n\nsee:\nhttps://review.openstack.org/#/admin/groups/448,members\n\nso, i\u0027d prefer to see just tripleo-ansible-core listed here in the acl, and let us manage what is included in there via gerrit.","commit_id":"26e296d4ac60270eae38f8e654919960bc1b6323"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"20499988d454932c7ad5837e22ab9b69ea08350f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[access \"refs/heads/*\"]"},{"line_number":2,"context_line":"abandon \u003d group tripleo-ansible-core"},{"line_number":3,"context_line":"label-Code-Review \u003d -2..+2 group tripleo-ansible-core"},{"line_number":4,"context_line":"label-Verified \u003d -1..+1 group tripleo-ci"},{"line_number":5,"context_line":"label-Workflow \u003d -1..+1 group tripleo-ansible-core"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[receive]"}],"source_content_type":"text/x-ini","patch_set":3,"id":"5f7c97a3_4e42e568","line":4,"in_reply_to":"5f7c97a3_8e4c7d9d","updated":"2018-07-20 19:11:58.000000000","message":"I\u0027m fine with it. So just remove tripleo-ci from this ACL and I think we\u0027re good. Just let tripleo-ansible-core.","commit_id":"26e296d4ac60270eae38f8e654919960bc1b6323"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3e046d1a7a730c6e0d5de91bc8a0aabe0971dd3d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[access \"refs/heads/*\"]"},{"line_number":2,"context_line":"abandon \u003d group tripleo-ansible-core"},{"line_number":3,"context_line":"label-Code-Review \u003d -2..+2 group tripleo-ansible-core"},{"line_number":4,"context_line":"label-Verified \u003d -1..+1 group tripleo-ci"},{"line_number":5,"context_line":"label-Workflow \u003d -1..+1 group tripleo-ansible-core"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[receive]"}],"source_content_type":"text/x-ini","patch_set":3,"id":"5f7c97a3_c2c24e54","line":4,"in_reply_to":"5f7c97a3_c2148eec","updated":"2018-07-20 16:05:43.000000000","message":"The group who contains tripleo cores is tripleo-core, and we\u0027ll also include an additional group for these roles (including you and Sam I guess), tripleo-ansible-core.\ntripleo-ci group is for projects related for CI (quickstart, etc) but not for these Ansible roles.\n\nDoes it make sense?","commit_id":"26e296d4ac60270eae38f8e654919960bc1b6323"},{"author":{"_account_id":20868,"name":"Jill Rouleau","email":"jill.rouleau@bespokess.com","username":"jillr"},"change_message_id":"a2d31ff3871ee31bfd68047008e2be1a98586d50","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[access \"refs/heads/*\"]"},{"line_number":2,"context_line":"abandon \u003d group tripleo-ansible-core"},{"line_number":3,"context_line":"label-Code-Review \u003d -2..+2 group tripleo-ansible-core"},{"line_number":4,"context_line":"label-Verified \u003d -1..+1 group tripleo-ci"},{"line_number":5,"context_line":"label-Workflow \u003d -1..+1 group tripleo-ansible-core"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[receive]"}],"source_content_type":"text/x-ini","patch_set":3,"id":"5f7c97a3_82b536d2","line":4,"in_reply_to":"5f7c97a3_c2c24e54","updated":"2018-07-20 16:08:42.000000000","message":"The CI thing totally does, thanks.\ntripleo-core is a member of tripleo-ansible-core, I can make it explicit here instead of implicit by group membership though for sure.","commit_id":"26e296d4ac60270eae38f8e654919960bc1b6323"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"68da245b0c5eaab61ceb46771d4952ed0116c6f9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[access \"refs/heads/*\"]"},{"line_number":2,"context_line":"abandon \u003d group tripleo-ansible-core"},{"line_number":3,"context_line":"label-Code-Review \u003d -2..+2 group tripleo-ansible-core"},{"line_number":4,"context_line":"label-Verified \u003d -1..+1 group tripleo-ansible-core"},{"line_number":5,"context_line":"label-Workflow \u003d -1..+1 group tripleo-ansible-core"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[receive]"}],"source_content_type":"text/x-ini","patch_set":4,"id":"5f7c97a3_bd531a6e","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":50},"updated":"2018-07-27 17:37:23.000000000","message":"Verified votes should be restricted to CI accounts. You should use tripleo-ci group or similar for this (or drop it entirely if you don\u0027t need it).","commit_id":"414bcf7266d07cd45c1cf2f1fb76fe61591c5316"},{"author":{"_account_id":20868,"name":"Jill Rouleau","email":"jill.rouleau@bespokess.com","username":"jillr"},"change_message_id":"8689d665518f83feb5f9b3d75e4351323e5515fc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[access \"refs/heads/*\"]"},{"line_number":2,"context_line":"abandon \u003d group tripleo-ansible-core"},{"line_number":3,"context_line":"label-Code-Review \u003d -2..+2 group tripleo-ansible-core"},{"line_number":4,"context_line":"label-Verified \u003d -1..+1 group tripleo-ansible-core"},{"line_number":5,"context_line":"label-Workflow \u003d -1..+1 group tripleo-ansible-core"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[receive]"}],"source_content_type":"text/x-ini","patch_set":4,"id":"5f7c97a3_fd188dce","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":50},"in_reply_to":"5f7c97a3_bd531a6e","updated":"2018-07-30 18:10:31.000000000","message":"In the previous patchset we said not to use tripleo-ci.  I guess, how do I know if I need this or not?","commit_id":"414bcf7266d07cd45c1cf2f1fb76fe61591c5316"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"b266d68cccc70a37f0f6c53b694ccd19d3823709","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[access \"refs/heads/*\"]"},{"line_number":2,"context_line":"abandon \u003d group tripleo-ansible-core"},{"line_number":3,"context_line":"label-Code-Review \u003d -2..+2 group tripleo-ansible-core"},{"line_number":4,"context_line":"label-Verified \u003d -1..+1 group tripleo-ansible-core"},{"line_number":5,"context_line":"label-Workflow \u003d -1..+1 group tripleo-ansible-core"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[receive]"}],"source_content_type":"text/x-ini","patch_set":5,"id":"5f7c97a3_fabaaa6e","line":4,"updated":"2018-08-01 04:33:59.000000000","message":"that\u0027s wrong - use tripleo-ansible-ci, see Clark\u0027s earlier review.","commit_id":"a98390b62b3a0f0598073a662ea79572c611dec1"}],"gerrit/projects.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"68da245b0c5eaab61ceb46771d4952ed0116c6f9","unresolved":false,"context_lines":[{"line_number":1101,"context_line":"  description: Ansible role to manage Nodepool"},{"line_number":1102,"context_line":"- project: openstack/ansible-role-openstack-operations"},{"line_number":1103,"context_line":"  description: Ansible role to perform common tasks to manage OpenStack clouds"},{"line_number":1104,"context_line":"  acl-config: /home/gerrit2/acls/openstack/tripleo-ansible.config"},{"line_number":1105,"context_line":"  groups:"},{"line_number":1106,"context_line":"    - tripleo"},{"line_number":1107,"context_line":"- project: openstack/ansible-role-openstacksdk"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_3df5ca52","line":1104,"updated":"2018-07-27 17:37:23.000000000","message":"Can you delete project-config/gerrit/acls/openstack/ansible-role-openstack-operations.config as it is no longer used.","commit_id":"414bcf7266d07cd45c1cf2f1fb76fe61591c5316"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"68da245b0c5eaab61ceb46771d4952ed0116c6f9","unresolved":false,"context_lines":[{"line_number":1228,"context_line":"    - tripleo"},{"line_number":1229,"context_line":"- project: openstack/ansible-role-tripleo-modify-image"},{"line_number":1230,"context_line":"  description: Ansible role to modify container images built for TripleO"},{"line_number":1231,"context_line":"  acl-config: /home/gerrit2/acls/openstack/tripleo-ansible.config"},{"line_number":1232,"context_line":"  groups:"},{"line_number":1233,"context_line":"    - tripleo"},{"line_number":1234,"context_line":"- project: openstack/ansible-role-tripleo-neutron"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_fd90b2f5","line":1231,"updated":"2018-07-27 17:37:23.000000000","message":"Can you delete project-config/gerrit/acls/openstack/ansible-role-tripleo-modify-image.config as it is no longer used.","commit_id":"414bcf7266d07cd45c1cf2f1fb76fe61591c5316"}],"gerritbot/channels.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"68da245b0c5eaab61ceb46771d4952ed0116c6f9","unresolved":false,"context_lines":[{"line_number":2448,"context_line":"    - openstack/puppet-tripleo"},{"line_number":2449,"context_line":"    - openstack/python-tripleoclient"},{"line_number":2450,"context_line":"    - openstack/tempest-tripleo-ui"},{"line_number":2451,"context_line":"    - openstack/tripleo-ansible"},{"line_number":2452,"context_line":"    - openstack/tripleo-common"},{"line_number":2453,"context_line":"    - openstack/tripleo-common-tempest-plugin"},{"line_number":2454,"context_line":"    - openstack/tripleo-docs"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_7d84a2b2","line":2451,"updated":"2018-07-27 17:37:23.000000000","message":"Not a -1. You can express this with a regex now ifyou like. Something similar to:\n\n  - ^openstack/tripleo.*\n\nThen remove all of these tripleo entries.","commit_id":"414bcf7266d07cd45c1cf2f1fb76fe61591c5316"},{"author":{"_account_id":20868,"name":"Jill Rouleau","email":"jill.rouleau@bespokess.com","username":"jillr"},"change_message_id":"8689d665518f83feb5f9b3d75e4351323e5515fc","unresolved":false,"context_lines":[{"line_number":2448,"context_line":"    - openstack/puppet-tripleo"},{"line_number":2449,"context_line":"    - openstack/python-tripleoclient"},{"line_number":2450,"context_line":"    - openstack/tempest-tripleo-ui"},{"line_number":2451,"context_line":"    - openstack/tripleo-ansible"},{"line_number":2452,"context_line":"    - openstack/tripleo-common"},{"line_number":2453,"context_line":"    - openstack/tripleo-common-tempest-plugin"},{"line_number":2454,"context_line":"    - openstack/tripleo-docs"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_7d7b1d2a","line":2451,"in_reply_to":"5f7c97a3_7d84a2b2","updated":"2018-07-30 18:10:31.000000000","message":"TIL.  I\u0027ll submit that as it\u0027s own cleanup review, thanks.","commit_id":"414bcf7266d07cd45c1cf2f1fb76fe61591c5316"}]}