)]}'
{"id":"openstack%2Fproject-config~659215","triplet_id":"openstack%2Fproject-config~master~I07a67e2e51d8d139e27da83aa16899a11d8b3f34","project":"openstack/project-config","branch":"master","topic":"journal-size","hashtags":[],"change_id":"I07a67e2e51d8d139e27da83aa16899a11d8b3f34","subject":"Increase nodepool image journal size","status":"MERGED","created":"2019-05-15 04:31:42.000000000","updated":"2019-05-21 23:17:22.000000000","submitted":"2019-05-21 23:17:22.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"659215-1558480642646-172dd170","meta_rev_id":"dc64f62d4e7ca2f0576e45c3e22bdac441752cad","_number":659215,"virtual_id_number":659215,"owner":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-05-21 23:17:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-05-17 09:45:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":2,"date":"2019-05-16 18:22:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-05-21 23:06:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"date":"2019-05-16 18:23:04.000000000","_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-16 18:22:12.000000000","updated_by":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"reviewer":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"state":"REVIEWER"},{"updated":"2019-05-21 23:06:11.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2019-05-21 23:17:22.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"2119f057b309599ca2b4eb2ef6cfe3ba777e48c4","author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"date":"2019-05-15 04:31:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a40847ca4d42519ac68de598fd756fa76f9b4788","author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"date":"2019-05-15 04:32:48.000000000","message":"Patch Set 1: Workflow-1\n\nNote, this uses a feature that will be included in the next DIB release. I\u0027m not sure when infra will pull that change in, but I wanted to propose this to see if there is any interest in accepting this change once it is possible.","accounts_in_message":[],"_revision_number":1},{"id":"988833d6300e15e518c862467ee29d324b74912c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-15 04:42:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-zuul-jobs-linters http://logs.openstack.org/15/659215/1/check/openstack-zuul-jobs-linters/513e004/ : SUCCESS in 5m 38s","accounts_in_message":[],"_revision_number":1},{"id":"a6c4aafab2969d68517ea298e0829a7c70246818","author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"date":"2019-05-16 16:44:58.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"74655365acec8741af43abab4910658cca98b9aa","author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"date":"2019-05-16 16:45:12.000000000","message":"Patch Set 2: Workflow-1\n\nnote above ^","accounts_in_message":[],"_revision_number":2},{"id":"2e765c15338e30cd53a1da21b2d06ed1c9113475","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-16 16:56:35.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-zuul-jobs-linters http://logs.openstack.org/15/659215/2/check/openstack-zuul-jobs-linters/5b8bf28/ : SUCCESS in 6m 18s\n- project-config-nodepool http://logs.openstack.org/15/659215/2/check/project-config-nodepool/2c55857/ : FAILURE in 3m 07s","accounts_in_message":[],"_revision_number":2},{"id":"e2fd56dc1dc50c947d50256562dc51a505828ac8","author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"date":"2019-05-16 17:09:18.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"1b0aefa91b26705264c62e0ffe223bef5821125d","author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"date":"2019-05-16 17:09:45.000000000","message":"Patch Set 3: Workflow-1\n\nstill note above ^","accounts_in_message":[],"_revision_number":3},{"id":"68687b0c6c246619976fb42da4daa3ca8eb77890","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-16 17:30:38.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-zuul-jobs-linters http://logs.openstack.org/15/659215/3/check/openstack-zuul-jobs-linters/26e965d/ : SUCCESS in 6m 11s\n- project-config-nodepool http://logs.openstack.org/15/659215/3/check/project-config-nodepool/57e74b3/ : SUCCESS in 4m 54s","accounts_in_message":[],"_revision_number":3},{"id":"0d0639621a3a2e9ff153226693b9eec3908aa766","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2019-05-16 18:22:12.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"c2d75986ce2ddcbb2e60a7088d71699acab504ca","author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"date":"2019-05-16 18:23:04.000000000","message":"Patch Set 3: -Workflow","accounts_in_message":[],"_revision_number":3},{"id":"b7ba7c748d4b6645d653e616cdc32f84e6c1d710","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-05-17 09:45:46.000000000","message":"Patch Set 3: Code-Review+2\n\nwe will need a dib release ; i\u0027ve put it on my todo and will merge after","accounts_in_message":[],"_revision_number":3},{"id":"63dcb6fcd95a98d5c74f4c0c8fb4c8c8e550949e","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-05-17 10:26:33.000000000","message":"Patch Set 3:\n\n2.23.0 released; it will need a few hours to get to builders","accounts_in_message":[],"_revision_number":3},{"id":"b0a14f2c41d8235e12df08890d4a91de484a5d1c","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-05-21 23:06:11.000000000","message":"Patch Set 3: Workflow+1\n\nThe article linked doesn\u0027t resolve for me; I haven\u0027t found too much hard info on this.  Certainly empirical testing shows that our nodes have a 64mb journal and that it hasn\u0027t been sized up by resize2fs (via growroot).  I guess this is worth a go; I\u0027m not sure what we\u0027re actually using to benchmark if this makes a difference or not?  Suggestions welcome :)","accounts_in_message":[],"_revision_number":3},{"id":"6e2f2caf05a3b570792c47530eb3ec07b9b34962","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-21 23:06:24.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"129bef80b6c999b3f55b3ef115f6176aad24e98d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-21 23:17:22.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-zuul-jobs-linters http://logs.openstack.org/15/659215/3/gate/openstack-zuul-jobs-linters/913ca36/ : SUCCESS in 5m 56s\n- project-config-nodepool http://logs.openstack.org/15/659215/3/gate/project-config-nodepool/04d94e4/ : SUCCESS in 3m 17s","accounts_in_message":[],"_revision_number":3},{"id":"1888d3a07c3ac3b1e704638d61faa72a130bcfa8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-21 23:17:22.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"c974096f522b1b4910f65343222bea91722c7f1a","revisions":{"9b8500732bd56e70615c58a07aeba864555baad5":{"kind":"REWORK","_number":1,"created":"2019-05-15 04:31:42.000000000","uploader":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"ref":"refs/changes/15/659215/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/15/659215/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/15/659215/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/15/659215/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/15/659215/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/15/659215/1"}}},"commit":{"parents":[{"commit":"4ece9652e4ffe4be4d6d733efe679338fda7ddac","subject":"Merge \"Remove ansible-lint-jobs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/4ece9652e4ffe4be4d6d733efe679338fda7ddac"}]}],"author":{"name":"Logan V","email":"logan2211@gmail.com","date":"2019-05-15 04:11:10.000000000","tz":-300},"committer":{"name":"Logan V","email":"logan2211@gmail.com","date":"2019-05-15 04:11:10.000000000","tz":-300},"subject":"Increase nodepool image journal size","message":"Increase nodepool image journal size\n\nDIB uses 64MB as the default ext4 journal size, which is far below\nthe mkfs.ext4 default for the 80GB disks that nodepool instances\nuse. This change will increase the journal size to 512MB which is\nthe default size for ext4 filesystems built on disks 64-128GB in\nsize.\n\nThe relevant mkfs source where default journal sizes are calculated\nis available here:\nhttps://git.kernel.org/pub/scm/fs/ext2/e2fsprogs.git/tree/lib/ext2fs/mkjournal.c#333\n\nhttp://www.linux-mag.com/id/7666/ shows that an undersized journal\ncan have a large impact on file operations when dealing with lots\nof small files. With larger files, there is negligible performance\nimpact. So worst case this change may not improve performance, but\nwith the number of jobs using small python source files and small\n.git repo files, this should cause a marginal performance increase\nfor the nodepool use case.\n\nChange-Id: I07a67e2e51d8d139e27da83aa16899a11d8b3f34\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/9b8500732bd56e70615c58a07aeba864555baad5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/9b8500732bd56e70615c58a07aeba864555baad5"}]},"branch":"refs/heads/master"},"bdf9c82b73ab998269ebb7762816c5d2f925244e":{"kind":"REWORK","_number":2,"created":"2019-05-16 16:44:58.000000000","uploader":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"ref":"refs/changes/15/659215/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/15/659215/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/15/659215/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/15/659215/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/15/659215/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/15/659215/2"}}},"commit":{"parents":[{"commit":"5088b9d00999e7f09171225da1c39cf6977c46de","subject":"Cleanup nodepool DIB environment using anchors","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/5088b9d00999e7f09171225da1c39cf6977c46de"}]}],"author":{"name":"Logan V","email":"logan2211@gmail.com","date":"2019-05-15 04:11:10.000000000","tz":-300},"committer":{"name":"Logan V","email":"logan2211@gmail.com","date":"2019-05-16 16:44:29.000000000","tz":-300},"subject":"Increase nodepool image journal size","message":"Increase nodepool image journal size\n\nDIB uses 64MB as the default ext4 journal size, which is far below\nthe mkfs.ext4 default for the 80GB disks that nodepool instances\nuse. This change will increase the journal size to 512MB which is\nthe default size for ext4 filesystems built on disks 64-128GB in\nsize.\n\nThe relevant mkfs source where default journal sizes are calculated\nis available here:\nhttps://git.kernel.org/pub/scm/fs/ext2/e2fsprogs.git/tree/lib/ext2fs/mkjournal.c#333\n\nhttp://www.linux-mag.com/id/7666/ shows that an undersized journal\ncan have a large impact on file operations when dealing with lots\nof small files. With larger files, there is negligible performance\nimpact. So worst case this change may not improve performance, but\nwith the number of jobs using small python source files and small\n.git repo files, this should cause a marginal performance increase\nfor the nodepool use case.\n\nChange-Id: I07a67e2e51d8d139e27da83aa16899a11d8b3f34\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/bdf9c82b73ab998269ebb7762816c5d2f925244e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/bdf9c82b73ab998269ebb7762816c5d2f925244e"}]},"branch":"refs/heads/master"},"c974096f522b1b4910f65343222bea91722c7f1a":{"kind":"REWORK","_number":3,"created":"2019-05-16 17:09:18.000000000","uploader":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"ref":"refs/changes/15/659215/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/15/659215/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/15/659215/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/15/659215/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/15/659215/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/15/659215/3"}}},"commit":{"parents":[{"commit":"4ece9652e4ffe4be4d6d733efe679338fda7ddac","subject":"Merge \"Remove ansible-lint-jobs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/4ece9652e4ffe4be4d6d733efe679338fda7ddac"}]}],"author":{"name":"Logan V","email":"logan2211@gmail.com","date":"2019-05-15 04:11:10.000000000","tz":-300},"committer":{"name":"Logan V","email":"logan2211@gmail.com","date":"2019-05-16 17:09:00.000000000","tz":-300},"subject":"Increase nodepool image journal size","message":"Increase nodepool image journal size\n\nDIB uses 64MB as the default ext4 journal size, which is far below\nthe mkfs.ext4 default for the 80GB disks that nodepool instances\nuse. This change will increase the journal size to 512MB which is\nthe default size for ext4 filesystems built on disks 64-128GB in\nsize.\n\nThe relevant mkfs source where default journal sizes are calculated\nis available here:\nhttps://git.kernel.org/pub/scm/fs/ext2/e2fsprogs.git/tree/lib/ext2fs/mkjournal.c#333\n\nhttp://www.linux-mag.com/id/7666/ shows that an undersized journal\ncan have a large impact on file operations when dealing with lots\nof small files. With larger files, there is negligible performance\nimpact. So worst case this change may not improve performance, but\nwith the number of jobs using small python source files and small\n.git repo files, this should cause a marginal performance increase\nfor the nodepool use case.\n\nChange-Id: I07a67e2e51d8d139e27da83aa16899a11d8b3f34\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/c974096f522b1b4910f65343222bea91722c7f1a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/c974096f522b1b4910f65343222bea91722c7f1a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}