)]}'
{"id":"openstack%2Fproject-config~665014","triplet_id":"openstack%2Fproject-config~master~Ic45b52f6bfc803756a8f42f21c848e1fd223175f","project":"openstack/project-config","branch":"master","topic":"stop-control-plane-nodepool","hashtags":[],"change_id":"Ic45b52f6bfc803756a8f42f21c848e1fd223175f","subject":"Stop building control plane images","status":"MERGED","created":"2019-06-12 20:46:52.000000000","updated":"2019-06-18 09:28:55.000000000","submitted":"2019-06-18 09:28:55.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"665014-1560850135218-b95397b7","meta_rev_id":"f6802566304b6f784852bfa911134323cb5c6370","_number":665014,"virtual_id_number":665014,"owner":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-06-18 09:28:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-06-18 09:17:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-06-18 09:17:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-18 09:17:23.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2019-06-18 09:28:55.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d0f21ebdf248081c1c25e06d095e3dc87f067bbc","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2019-06-12 20:46:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"08f0987bd03f67e0390798770e80995f2e5b4822","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-12 20:58:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-zuul-jobs-linters http://logs.openstack.org/14/665014/1/check/openstack-zuul-jobs-linters/1c50e21/ : SUCCESS in 6m 23s\n- project-config-nodepool http://logs.openstack.org/14/665014/1/check/project-config-nodepool/1a18c77/ : SUCCESS in 3m 19s","accounts_in_message":[],"_revision_number":1},{"id":"e0ac90839890fef0a7aea889a704e0da17bca476","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-06-18 09:17:23.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nemergency merging this, because it seems this is causing threads to leak as nodepool tries to delete images that are in use\n\n root@nb01:/proc/1103/task# ls -ltrah | wc -l\n 259\n\nI have saved a bt of all the threads at this time in \n\n /home/ianw/nodepool-bt-665014.txt\n\nin case it helps.","accounts_in_message":[],"_revision_number":1},{"id":"4fb209c8ed834d02f64796880eb33ec824c1f089","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-18 09:17:35.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"9240f891735e1c4347a4878faa850711573c9bef","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-18 09:28:55.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"7d80f98386384d76163d415ba96b7d9c81a139fa","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-18 09:28:55.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-zuul-jobs-linters http://logs.openstack.org/14/665014/1/gate/openstack-zuul-jobs-linters/5aea371/ : SUCCESS in 6m 27s\n- project-config-nodepool http://logs.openstack.org/14/665014/1/gate/project-config-nodepool/2db8670/ : SUCCESS in 3m 48s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6b56fd81cad681c3b7ed87bbfdfebbdf00656f55","revisions":{"6b56fd81cad681c3b7ed87bbfdfebbdf00656f55":{"kind":"REWORK","_number":1,"created":"2019-06-12 20:46:52.000000000","uploader":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"ref":"refs/changes/14/665014/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/14/665014/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/14/665014/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/14/665014/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/14/665014/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/14/665014/1"}}},"commit":{"parents":[{"commit":"d8b7f2da286f88a4bb687897f6f514384871aa6e","subject":"Revert \"opendev.org mirrors: switch out DFW, switch in IAD\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/d8b7f2da286f88a4bb687897f6f514384871aa6e"}]}],"author":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2019-06-12 20:44:47.000000000","tz":-420},"committer":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2019-06-12 20:44:47.000000000","tz":-420},"subject":"Stop building control plane images","message":"Stop building control plane images\n\nNodepool wants to build a new image every day then delete the N+2\u0027th\nimage. This is great for dynamic test nodes which never live for longer\nthan a few hours. Unfortunately, with boot from volume servers you\ncannot delete their base image if the server is still running. This\nmeans as soon as we use these images for control plane servers, which do\nnot go away after a few hours, we\u0027ll no longer be able to delete that\nimage a couple days later.\n\nThis will make our current nodepool install unhappy so lets avoid doing\nthat for now.\n\nWe can probably make improvements to nodepool to better support this use\ncase. At that time we can start trying this again. We will probably also\nwant to use a dedicated builder for that.\n\nNote this isn\u0027t a revert because we want to wind down nodepool in such a\nway that it cleans up after itself.\n\nChange-Id: Ic45b52f6bfc803756a8f42f21c848e1fd223175f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/6b56fd81cad681c3b7ed87bbfdfebbdf00656f55"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/6b56fd81cad681c3b7ed87bbfdfebbdf00656f55"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}