)]}'
{"nodepool/elements/nodepool-base/finalise.d/89-boot-settings":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cfed168e9181808442433b60e1b37c66f9c97a70","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    # [1] https://bugzilla.redhat.com/show_bug.cgi?id\u003d1386052"},{"line_number":125,"context_line":"    if [[ ! -e /etc/rc.local ]] \u0026\u0026 [[ ! -e /etc/debian_version ]]; then"},{"line_number":126,"context_line":"        if [[ ! -d /etc/rc.d ]]; then"},{"line_number":127,"context_line":"            echo \"No rc.local and no rc.d directory!  See comments in 89-unbound\""},{"line_number":128,"context_line":"            exit 1"},{"line_number":129,"context_line":"        fi"},{"line_number":130,"context_line":"        touch /etc/rc.d/rc.local"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_98c5333f","line":127,"updated":"2019-09-20 13:27:02.000000000","message":"You probably want to amend this comment.","commit_id":"7c2873d538ab523109306355b613d0187ad59f1e"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"81b8a2dd4a0e150a5ba664c84cf8ca7e9139dc6b","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    # [1] https://bugzilla.redhat.com/show_bug.cgi?id\u003d1386052"},{"line_number":125,"context_line":"    if [[ ! -e /etc/rc.local ]] \u0026\u0026 [[ ! -e /etc/debian_version ]]; then"},{"line_number":126,"context_line":"        if [[ ! -d /etc/rc.d ]]; then"},{"line_number":127,"context_line":"            echo \"No rc.local and no rc.d directory!  See comments in 89-unbound\""},{"line_number":128,"context_line":"            exit 1"},{"line_number":129,"context_line":"        fi"},{"line_number":130,"context_line":"        touch /etc/rc.d/rc.local"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_3ecc24bb","line":127,"in_reply_to":"3fa7e38b_98c5333f","updated":"2019-09-20 15:54:56.000000000","message":"Good catch","commit_id":"7c2873d538ab523109306355b613d0187ad59f1e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cfed168e9181808442433b60e1b37c66f9c97a70","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    rclocalcontent\u003d\"$rclocalcontent\\n$iptablescontent\""},{"line_number":164,"context_line":"fi"},{"line_number":165,"context_line":"rclocalcontent\u003d\"$rclocalcontent\\n\\nexit 0\""},{"line_number":166,"context_line":"echo -e \"$rclocalcontent\" | dd of\u003d$rclocal"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"# Debian/Ubuntu ship their dummy rc.local with +x permissions, but"},{"line_number":169,"context_line":"# CentOS (and the file we created for Fedora) do not ... this is to"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_9848d3cc","line":166,"updated":"2019-09-20 13:27:02.000000000","message":"Is there a specific reason why we must use dd here? This whole construct looks very strange to me, I\u0027d consider using multiple cats in order to assemble the file in chunks more natural.","commit_id":"7c2873d538ab523109306355b613d0187ad59f1e"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"81b8a2dd4a0e150a5ba664c84cf8ca7e9139dc6b","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    rclocalcontent\u003d\"$rclocalcontent\\n$iptablescontent\""},{"line_number":164,"context_line":"fi"},{"line_number":165,"context_line":"rclocalcontent\u003d\"$rclocalcontent\\n\\nexit 0\""},{"line_number":166,"context_line":"echo -e \"$rclocalcontent\" | dd of\u003d$rclocal"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"# Debian/Ubuntu ship their dummy rc.local with +x permissions, but"},{"line_number":169,"context_line":"# CentOS (and the file we created for Fedora) do not ... this is to"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_9ed51846","line":166,"in_reply_to":"3fa7e38b_9848d3cc","updated":"2019-09-20 15:54:56.000000000","message":"\u003e Is there a specific reason why we must use dd here? This whole\n \u003e construct looks very strange to me, I\u0027d consider using multiple\n \u003e cats in order to assemble the file in chunks more natural.\n\nI agree it\u0027s really weird. I preserved the existing use of dd on the off chance it was a deliberate choice for a reason I can\u0027t think of (atomicity of file operations?) but can switch it to cat if there\u0027s no good reason to keep dd.","commit_id":"7c2873d538ab523109306355b613d0187ad59f1e"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"bb60d3011158163328fa6b0b6e20b8c42bf3e351","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    rclocalcontent\u003d\"$rclocalcontent\\n$iptablescontent\""},{"line_number":164,"context_line":"fi"},{"line_number":165,"context_line":"rclocalcontent\u003d\"$rclocalcontent\\n\\nexit 0\""},{"line_number":166,"context_line":"echo -e \"$rclocalcontent\" | dd of\u003d$rclocal"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"# Debian/Ubuntu ship their dummy rc.local with +x permissions, but"},{"line_number":169,"context_line":"# CentOS (and the file we created for Fedora) do not ... this is to"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_13dda441","line":166,"in_reply_to":"3fa7e38b_9848d3cc","updated":"2019-09-20 13:46:37.000000000","message":"Isn\u0027t that carefully avoiding the useless-use-of-cat-award? ;)","commit_id":"7c2873d538ab523109306355b613d0187ad59f1e"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2f81885d0ba30ac65b9af6a436ea69c8a31b72af","unresolved":false,"context_lines":[{"line_number":154,"context_line":"# openSUSE doesn\u0027t have an iptables service, so apply the iptables rules at boot"},{"line_number":155,"context_line":"if [[ \"${DISTRO_NAME}\" \u003d~ (opensuse) ]] ; then"},{"line_number":156,"context_line":"    cat \u003e\u003e$rclocal \u003c\u003cEOF"},{"line_number":157,"context_line":"iptables-restore /etc/sysconfig/iptables"},{"line_number":158,"context_line":"ip6tables-restore /etc/sysconfig/ip6tables"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"EOF"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa7e38b_e3d48c22","line":157,"range":{"start_line":157,"start_character":17,"end_line":157,"end_character":40},"updated":"2019-09-24 06:07:05.000000000","message":"So I guess that zuul-jobs actually writes this out?  AFAICT this isn\u0027t written out during the image build (maybe, probably, i\u0027m wrong?).  Is the script OK if these don\u0027t exist?\n\nBasically this is covering the case of a rebooted host (not something we do a lot of)?","commit_id":"587b85ba368ac047281102281d7afa7dd831225c"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"4f9f53cf444ad74d827529ad23e95ff671419843","unresolved":false,"context_lines":[{"line_number":154,"context_line":"# openSUSE doesn\u0027t have an iptables service, so apply the iptables rules at boot"},{"line_number":155,"context_line":"if [[ \"${DISTRO_NAME}\" \u003d~ (opensuse) ]] ; then"},{"line_number":156,"context_line":"    cat \u003e\u003e$rclocal \u003c\u003cEOF"},{"line_number":157,"context_line":"iptables-restore /etc/sysconfig/iptables"},{"line_number":158,"context_line":"ip6tables-restore /etc/sysconfig/ip6tables"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"EOF"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa7e38b_a3e454e1","line":157,"range":{"start_line":157,"start_character":17,"end_line":157,"end_character":40},"in_reply_to":"3fa7e38b_e3d48c22","updated":"2019-09-24 06:27:38.000000000","message":"This is written out during the image build here https://opendev.org/openstack/project-config/src/commit/08feda2960c2c30dc195ff94a222626001b5c834/nodepool/elements/nodepool-base/install.d/20-iptables#L46-L92","commit_id":"587b85ba368ac047281102281d7afa7dd831225c"}]}