)]}'
{"id":"openstack%2Fproject-config~683236","triplet_id":"openstack%2Fproject-config~master~Ia2b72e25078efa68019f1bf7c7a0b77e6ff702fd","project":"openstack/project-config","branch":"master","topic":"suse-iptables","hashtags":[],"change_id":"Ia2b72e25078efa68019f1bf7c7a0b77e6ff702fd","subject":"Use iptables for openSUSE","status":"MERGED","created":"2019-09-19 21:11:12.000000000","updated":"2019-09-30 06:05:50.000000000","submitted":"2019-09-30 06:05:50.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"683236-1569823550883-02882d20","meta_rev_id":"d472f77fd13b578f9016661627d092fa92aeaf30","_number":683236,"virtual_id_number":683236,"owner":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"date":"2019-09-24 06:27:38.000000000","_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-09-30 06:05:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":2,"date":"2019-09-24 11:46:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":2,"date":"2019-09-30 05:53:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-09-25 08:09:59.000000000","_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":1,"date":"2019-09-30 05:53:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-20 11:02:43.000000000","updated_by":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"reviewer":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"state":"REVIEWER"},{"updated":"2019-09-20 12:52:45.000000000","updated_by":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"reviewer":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"state":"REVIEWER"},{"updated":"2019-09-24 11:46:32.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2019-09-25 08:09:59.000000000","updated_by":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"reviewer":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"state":"REVIEWER"},{"updated":"2019-09-30 05:53:29.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2019-09-30 06:05:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"fddf9958d87f9698e3701c2b8598948630c8a120","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-09-19 21:11:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"534f36b6c5abe60d732f7d04f5cd343cdb56f100","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-19 21:22:44.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-zuul-jobs-linters https://zuul.opendev.org/t/openstack/build/c0a4bfb1445240db86696f6c0d724ae8 : SUCCESS in 6m 06s\n- project-config-dib https://zuul.opendev.org/t/openstack/build/96b8ecf84b0d4428974d0df83c47c103 : SUCCESS in 4m 23s","accounts_in_message":[],"_revision_number":1},{"id":"6e306bbbf3f5f0b5a0fdd9018e09fbfd35d2fd7d","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-09-19 21:39:12.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"428901e094643c3cedbe8042901661f33f32fe33","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-09-19 21:43:29.000000000","message":"Patch Set 1: -Workflow","accounts_in_message":[],"_revision_number":1},{"id":"227ec688021b859f3a50d96ca14dd14d34dd78b9","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2019-09-20 11:02:43.000000000","message":"Patch Set 1: Code-Review+1\n\nThanks Colleen, looks good to me!","accounts_in_message":[],"_revision_number":1},{"id":"b6ac50b8f6876033971b70217ad623cd5d545f5f","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2019-09-20 12:52:45.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"cfed168e9181808442433b60e1b37c66f9c97a70","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-09-20 13:27:02.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nIs there a way we can test this before merging? I\u0027m a bit worried about unnoticed possible sideeffects.","accounts_in_message":[],"_revision_number":1},{"id":"bb60d3011158163328fa6b0b6e20b8c42bf3e351","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2019-09-20 13:46:37.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"81b8a2dd4a0e150a5ba664c84cf8ca7e9139dc6b","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-09-20 15:54:56.000000000","message":"Patch Set 1:\n\n(2 comments)\n\n\u003e \n \u003e Is there a way we can test this before merging? I\u0027m a bit worried\n \u003e about unnoticed possible sideeffects.\n\nI tested it manually with tools/build-image.sh with leap 15.1 and tumbleweed. I could post those logs and test ubuntu as well. I don\u0027t know how we could get zuul to test it.","accounts_in_message":[],"_revision_number":1},{"id":"d84a44db2bd34800532dbe313ff121cf5ec3337e","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-09-20 19:05:59.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c57dd3abf6f96e2b620730f6f08c06ebff5a5fb7","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-09-20 19:06:19.000000000","message":"Patch Set 2:\n\nBuild logs: http://www.gazlene.net/logs/","accounts_in_message":[],"_revision_number":2},{"id":"47419e6b342bf3c407c10221b9886a15a7c0f1ca","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-20 19:17:46.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-zuul-jobs-linters https://zuul.opendev.org/t/openstack/build/fdd3878a6fec46bc9ba4bec323bc1398 : SUCCESS in 7m 40s\n- project-config-dib https://zuul.opendev.org/t/openstack/build/55dcd14a1df54ec1b3a271aed6f918ed : SUCCESS in 3m 13s","accounts_in_message":[],"_revision_number":2},{"id":"2f81885d0ba30ac65b9af6a436ea69c8a31b72af","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-09-24 06:07:05.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"4f9f53cf444ad74d827529ad23e95ff671419843","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-09-24 06:27:38.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"91515de35a69feab93477f9aefff9c144cd2f4ae","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-09-24 11:46:32.000000000","message":"Patch Set 2: Code-Review+2\n\nO.k., I\u0027m fine with giving it a spin, would be good if someone could keep an eye on builder logs once this merges. (I could do that depending on time zone.)","accounts_in_message":[],"_revision_number":2},{"id":"fbc10dff949153e66789a94c224ebbb139faec89","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-09-30 05:53:29.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"6284926fa15ed59662bff6afcb8f98e8d2a9f082","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-30 05:53:41.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"9a23ec204b71c47d239fb4f1264bf181ae21c8dd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-30 06:05:50.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"d44051b034b4a6c3b07159cac13d3e792900ec21","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-30 06:05:50.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-zuul-jobs-linters https://zuul.opendev.org/t/openstack/build/996a4f47640643418d827f90346f911f : SUCCESS in 6m 58s\n- project-config-dib https://zuul.opendev.org/t/openstack/build/ae853c46b43944f6b43807b0bccf9cde : SUCCESS in 4m 01s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"587b85ba368ac047281102281d7afa7dd831225c","revisions":{"7c2873d538ab523109306355b613d0187ad59f1e":{"kind":"REWORK","_number":1,"created":"2019-09-19 21:11:12.000000000","uploader":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"ref":"refs/changes/36/683236/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/36/683236/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/36/683236/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/36/683236/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/36/683236/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/36/683236/1"}}},"commit":{"parents":[{"commit":"7a6101a60ccb4e4586884a377cb1091a513d89c8","subject":"Merge \"Add zuul-registry project\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/7a6101a60ccb4e4586884a377cb1091a513d89c8"}]}],"author":{"name":"Colleen Murphy","email":"colleen.murphy@suse.de","date":"2019-09-19 21:04:44.000000000","tz":-420},"committer":{"name":"Colleen Murphy","email":"colleen.murphy@suse.de","date":"2019-09-19 21:11:06.000000000","tz":-420},"subject":"Use iptables for openSUSE","message":"Use iptables for openSUSE\n\nIn openSUSE Tumbleweed, the SuSEfirewall2 package was removed in favor\nof firewalld[1]. This commit updates the openSUSE nodeset to use plain\niptables rather than injecting iptables rules into the SuSEfirewall2\nservice. This will work on both Tumbleweed and Leap nodesets.\n\nopenSUSE provides no iptables-service package the way the RHEL family\ndoes, so we can\u0027t fall back to that. Rather than try to convert iptables\nrules to firewalld syntax, this change leverages init.d to ensure\niptables rules are loaded at boot. The 89-unbound script has been\ncoopted for this purpose since it already creates\n/etc/init.d/boot.local. The usage of `dd` rather than `cat` is\npreserved.\n\n[1] https://lists.opensuse.org/opensuse-factory/2019-01/msg00490.html\n\nChange-Id: Ia2b72e25078efa68019f1bf7c7a0b77e6ff702fd\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/7c2873d538ab523109306355b613d0187ad59f1e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/7c2873d538ab523109306355b613d0187ad59f1e"}]},"branch":"refs/heads/master"},"587b85ba368ac047281102281d7afa7dd831225c":{"kind":"REWORK","_number":2,"created":"2019-09-20 19:05:59.000000000","uploader":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"ref":"refs/changes/36/683236/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/36/683236/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/36/683236/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/36/683236/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/36/683236/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/36/683236/2"}}},"commit":{"parents":[{"commit":"7a6101a60ccb4e4586884a377cb1091a513d89c8","subject":"Merge \"Add zuul-registry project\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/7a6101a60ccb4e4586884a377cb1091a513d89c8"}]}],"author":{"name":"Colleen Murphy","email":"colleen.murphy@suse.de","date":"2019-09-19 21:04:44.000000000","tz":-420},"committer":{"name":"Colleen Murphy","email":"colleen.murphy@suse.de","date":"2019-09-20 19:05:09.000000000","tz":-420},"subject":"Use iptables for openSUSE","message":"Use iptables for openSUSE\n\nIn openSUSE Tumbleweed, the SuSEfirewall2 package was removed in favor\nof firewalld[1]. This commit updates the openSUSE nodeset to use plain\niptables rather than injecting iptables rules into the SuSEfirewall2\nservice. This will work on both Tumbleweed and Leap nodesets.\n\nopenSUSE provides no iptables-service package the way the RHEL family\ndoes, so we can\u0027t fall back to that. Rather than try to convert iptables\nrules to firewalld syntax, this change leverages init.d to ensure\niptables rules are loaded at boot. The 89-unbound script has been\ncoopted for this purpose since it already creates\n/etc/init.d/boot.local. Switched from `dd` to `cat` which makes\nconditionally composing the file more natural.\n\n[1] https://lists.opensuse.org/opensuse-factory/2019-01/msg00490.html\n\nChange-Id: Ia2b72e25078efa68019f1bf7c7a0b77e6ff702fd\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/587b85ba368ac047281102281d7afa7dd831225c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/587b85ba368ac047281102281d7afa7dd831225c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}