)]}'
{"id":"openstack%2Fproject-config~683431","triplet_id":"openstack%2Fproject-config~master~I3795fee1530045363e3f629f0793cbe6e95c23ca","project":"openstack/project-config","branch":"master","topic":"nested-virt","hashtags":[],"change_id":"I3795fee1530045363e3f629f0793cbe6e95c23ca","subject":"add common nested-virt lables","status":"MERGED","created":"2019-09-20 15:49:45.000000000","updated":"2019-10-02 19:05:03.000000000","submitted":"2019-10-02 19:05:03.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"683431-1570043103977-39d839bb","meta_rev_id":"27c9a6240194aa685b395c9b023d0612110d7a38","_number":683431,"virtual_id_number":683431,"owner":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":20754,"name":"Donny Davis","email":"donny@fortnebula.com","username":"donnydavis"},{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":0,"date":"2019-09-20 16:25:42.000000000","_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-02 19:05:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"recommended":{"_account_id":20754,"name":"Donny Davis","email":"donny@fortnebula.com","username":"donnydavis"},"all":[{"value":1,"date":"2019-09-20 16:08:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":20754,"name":"Donny Davis","email":"donny@fortnebula.com","username":"donnydavis"},{"value":2,"date":"2019-10-01 20:07:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":2,"date":"2019-10-02 17:30:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":1,"date":"2019-10-02 15:31:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":2,"date":"2019-10-01 20:11:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-09-30 06:03:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"all":[{"value":0,"_account_id":20754,"name":"Donny Davis","email":"donny@fortnebula.com","username":"donnydavis"},{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":1,"date":"2019-10-02 17:30:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"_account_id":20754,"name":"Donny Davis","email":"donny@fortnebula.com","username":"donnydavis"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-20 16:08:19.000000000","updated_by":{"_account_id":20754,"name":"Donny Davis","email":"donny@fortnebula.com","username":"donnydavis"},"reviewer":{"_account_id":20754,"name":"Donny Davis","email":"donny@fortnebula.com","username":"donnydavis"},"state":"REVIEWER"},{"updated":"2019-09-30 06:03:53.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2019-10-01 20:07:44.000000000","updated_by":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"reviewer":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"state":"REVIEWER"},{"updated":"2019-10-01 20:11:46.000000000","updated_by":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"reviewer":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"state":"REVIEWER"},{"updated":"2019-10-02 15:31:40.000000000","updated_by":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"reviewer":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"state":"REVIEWER"},{"updated":"2019-10-02 17:30:04.000000000","updated_by":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"reviewer":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"state":"REVIEWER"},{"updated":"2019-10-02 19:05:03.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e3f33b3b72308c1999b2e4c66e43a9e01e29a733","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2019-09-20 15:49:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"99f877eca414da9613c2979e79d0df3c285b844f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-20 15:59:58.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-zuul-jobs-linters https://zuul.opendev.org/t/openstack/build/1d438744e5e74dba98d119a3e3c656a6 : SUCCESS in 6m 46s\n- project-config-nodepool https://zuul.opendev.org/t/openstack/build/e7aeb2257151439c907cd2e53a6c8cc7 : SUCCESS in 4m 17s","accounts_in_message":[],"_revision_number":1},{"id":"8c370f4ae8122680dae315fa195e33b962a45ba3","author":{"_account_id":20754,"name":"Donny Davis","email":"donny@fortnebula.com","username":"donnydavis"},"date":"2019-09-20 16:08:19.000000000","message":"Patch Set 1: Code-Review+1\n\nLGTM - If this helps get things through the gate I am happy. Use FN however it works best.","accounts_in_message":[],"_revision_number":1},{"id":"e0993c67d5151c42cac939114355c8aed4d835e2","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2019-09-20 16:25:42.000000000","message":"Patch Set 1:\n\nthe real motivation is to eventually be able to make a job that use nested virt voting at some point.\n\nas long as we are using a lable that can only be provided by one cloud, regardless of how stable it is i am not comfortable make a job voting so this will help with that goal. i intend to start using this for netorking-ovs-dpdk and os-vif to test ovs-dpdk integration with openstack and eventually expand it to other testing in nova.\n\ni plan to be concerrvitve and graduate the jobs nova job with core consent form perordic+experimental to non-voting check then to voting in check over the course of the Ussuri cycle.\n\nfor os-vif and networking-ovs-dpdk i plan to be more agressive and go to non voting check the voting check more quickly for ovs-dpdk testing since i have core rights and can backout the job if need.","accounts_in_message":[],"_revision_number":1},{"id":"6d22b70511fe0ec6ec5db57dc43fb713f3119e3c","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-09-30 06:03:53.000000000","message":"Patch Set 1: Code-Review+2\n\n(2 comments)\n\nI feel like overall we\u0027ve tried to keep the idea that nodepool is a \"pool\" and not tried to split things up into smaller and smaller categories, such that jobs evolve to become specific enough to only run in essentially limited conditions.  \n\nPerhaps, though, nested kvm is now a mature enough idea that this is less of a concern, and we have a broad enough coverage that should one provider disappear we\u0027re not left with jobs that have no home.\n\nI\u0027d go with the group consensus, but would like to see PTL weigh in as it is a bit of a change in policy...","accounts_in_message":[],"_revision_number":1},{"id":"3ca3825b36e2f6c4c1c43e431b1ab275a9674146","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2019-10-01 20:07:44.000000000","message":"Patch Set 1: Code-Review+2\n\nNested virt with KVM as deployed on our clouds is probably not quite as reliable as we\u0027d like it to be. That said we now seem to have cloud operator involvement at a level that allows us to try this and really shake out the remaining issues with nested virt.\n\nIt would be nice to have the cloud providers ack this change before we merge it though just to be sure we have their buy in first.\n\nI think the goal here would be to provide this more universally through the improvements to the software that can be made by actively using it.","accounts_in_message":[],"_revision_number":1},{"id":"f80d1839596547e56bbce28be4cd9c1576fe87ef","author":{"_account_id":20754,"name":"Donny Davis","email":"donny@fortnebula.com","username":"donnydavis"},"date":"2019-10-01 20:10:07.000000000","message":"Patch Set 1:\n\nLGTM - happy to support it","accounts_in_message":[],"_revision_number":1},{"id":"bfab8c07e7985483468ffad6966738a6a6c42492","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-10-01 20:11:46.000000000","message":"Patch Set 1: Code-Review+2\n\nlgtm","accounts_in_message":[],"_revision_number":1},{"id":"f365537d29202464a4bffd1d65ab48a570e50d06","author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"date":"2019-10-02 15:31:40.000000000","message":"Patch Set 1: Code-Review+1\n\nbring it! limestone\u0027s bare-metal testing jobs live or die by nested virt, so we are very motivated to keep it working.","accounts_in_message":[],"_revision_number":1},{"id":"8dc16ed19f11632f759f1ecce11001f61a8f2f87","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2019-10-02 17:30:04.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"055be6274798ed5400ffc2497d866c833fd4f4d1","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 17:30:18.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"bb05f964bd4fd22942eeb0f517debbc070fb825b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 19:05:03.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"61552a655f798cfec6bd2c930cd856195ce98c1c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 19:05:03.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-zuul-jobs-linters https://zuul.opendev.org/t/openstack/build/84a6e4ed37924b2bb9e12e2ff3136703 : SUCCESS in 6m 37s\n- project-config-nodepool https://zuul.opendev.org/t/openstack/build/1560bd2ae1704a0e85adf6519c0cd1a1 : SUCCESS in 3m 54s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"72fc182c7a61761b96b8824cc68a66325ddf4d00","revisions":{"72fc182c7a61761b96b8824cc68a66325ddf4d00":{"kind":"REWORK","_number":1,"created":"2019-09-20 15:49:45.000000000","uploader":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"ref":"refs/changes/31/683431/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/31/683431/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/31/683431/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/31/683431/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/31/683431/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/31/683431/1"}}},"commit":{"parents":[{"commit":"e447d361db4c23aa6eaabf2160e50844cfe689b7","subject":"Merge \"Set requireContributorAgreement false for windmill roles\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/e447d361db4c23aa6eaabf2160e50844cfe689b7"}]}],"author":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2019-09-20 15:43:22.000000000","tz":60},"committer":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2019-09-20 15:49:42.000000000","tz":60},"subject":"add common nested-virt lables","message":"add common nested-virt lables\n\nThis change adds two new lables nested-virt-ubuntu-bionic\nand nested-virt-centos-7 to fort nebula, limestone adn vexxhost.\ncurrently jobs that require nested virt to function mus use provider\nspecific lables to ensure the job can execute correctly.\nThe addtion of common nested virt lables will allow more redundency\nensuring that if a specific provider is offline the node requests can\nbe fullfiled by the remaining providers. These new lables are identical\nto the existing centos-7 and ubuntu-bionic lables. it is intended that\nmost jobs should continute to use the non nested virt lables and only\nnew jobs that require nested virt will use the new lables.\n\nChange-Id: I3795fee1530045363e3f629f0793cbe6e95c23ca\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/72fc182c7a61761b96b8824cc68a66325ddf4d00"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/72fc182c7a61761b96b8824cc68a66325ddf4d00"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}