)]}'
{"playbooks/proposal/kolla_version_update.py":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"d14170af12f67bff8d9b3e44aeac820b9c04c50e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import yaml"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from kolla.common import config  # noqa"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"logging.basicConfig(level\u003dlogging.INFO)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_c358c932","line":28,"range":{"start_line":28,"start_character":5,"end_line":28,"end_character":16},"updated":"2019-11-08 10:35:36.000000000","message":"do you really need to import kolla here?","commit_id":"874422ca8b20edf343b7f4f562fc48866107ed6b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ecd513186d725504b99de6805f16e2883433d05e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import yaml"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from kolla.common import config  # noqa"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"logging.basicConfig(level\u003dlogging.INFO)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_43ea99d8","line":28,"range":{"start_line":28,"start_character":5,"end_line":28,"end_character":16},"in_reply_to":"3fa7e38b_c358c932","updated":"2019-11-08 10:56:19.000000000","message":"Currently we have a variable, SOURCES, that defines our source list. It\u0027s a bit horrible, and hrw is looking at switching to YAML: https://review.opendev.org/693398. I was hoping these two things could be independent but if this script needs to live in a branchless repo then they are not. We are discussing backporting that change to stable branches, so that we could move this script to YAML mode.","commit_id":"874422ca8b20edf343b7f4f562fc48866107ed6b"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"d14170af12f67bff8d9b3e44aeac820b9c04c50e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    subprocess.call(cmd)  # nosec"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def get_default_branch():"},{"line_number":57,"context_line":"    gitreview_file \u003d os.path.join(PROJECT_ROOT, \u0027.gitreview\u0027)"},{"line_number":58,"context_line":"    if not os.path.exists(gitreview_file):"},{"line_number":59,"context_line":"        return"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    with open(gitreview_file, \u0027r\u0027) as gitreview:"},{"line_number":62,"context_line":"        for line in gitreview:"},{"line_number":63,"context_line":"            branches \u003d RE_DEFAULT_BRANCH.findall(line)"},{"line_number":64,"context_line":"            if branches:"},{"line_number":65,"context_line":"                return branches[0]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def load_all_info(openstack_release):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_e372a5b0","line":65,"range":{"start_line":56,"start_character":0,"end_line":65,"end_character":34},"updated":"2019-11-08 10:35:36.000000000","message":"you\u0027re running this as part of Zuul, so don\u0027t need this logic. See how other scripts get the branch via ZUUL environment variables","commit_id":"874422ca8b20edf343b7f4f562fc48866107ed6b"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"d14170af12f67bff8d9b3e44aeac820b9c04c50e","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    projects \u003d {}"},{"line_number":70,"context_line":"    release_path \u003d os.path.join(TARGET, \u0027deliverables\u0027, openstack_release)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    if not os.path.exists(release_path):"},{"line_number":73,"context_line":"        raise ValueError("},{"line_number":74,"context_line":"            \u0027Can not find openstack release: \"%s\"\u0027 % openstack_release)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_8363b1dd","line":72,"range":{"start_line":72,"start_character":23,"end_line":72,"end_character":40},"updated":"2019-11-08 10:35:36.000000000","message":"you need to require the project","commit_id":"874422ca8b20edf343b7f4f562fc48866107ed6b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ecd513186d725504b99de6805f16e2883433d05e","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    projects \u003d {}"},{"line_number":70,"context_line":"    release_path \u003d os.path.join(TARGET, \u0027deliverables\u0027, openstack_release)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    if not os.path.exists(release_path):"},{"line_number":73,"context_line":"        raise ValueError("},{"line_number":74,"context_line":"            \u0027Can not find openstack release: \"%s\"\u0027 % openstack_release)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_a3b26d05","line":72,"range":{"start_line":72,"start_character":23,"end_line":72,"end_character":40},"in_reply_to":"3fa7e38b_8363b1dd","updated":"2019-11-08 10:56:19.000000000","message":"Would it need to be a \u0027subclass\u0027 job of propose-updates to add a requirement on releases?","commit_id":"874422ca8b20edf343b7f4f562fc48866107ed6b"}],"playbooks/proposal/propose_update.sh":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"694408734b22a69ee98a7e54c1778e5a79532af4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    TOPIC\u003d\"openstack/openstack-ansible-tests/sync-tests\""},{"line_number":62,"context_line":"    PROJECTS\u003d$(./gen-projects-list.sh)"},{"line_number":63,"context_line":"    function update {"},{"line_number":64,"context_line":"        bash /home/zuul/scripts/sync_openstack_ansible_common_files.sh $1"},{"line_number":65,"context_line":"    }"},{"line_number":66,"context_line":"elif [ \"$OWN_PROJECT\" \u003d\u003d \"os-service-types\" ] ; then"},{"line_number":67,"context_line":"    INITIAL_COMMIT_MSG\u003d\"Updated from OpenStack Service Type Authority\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_31ffaeac","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":32},"updated":"2019-11-07 19:12:57.000000000","message":"new scripts are only allowed to come from project-config, they will be in zuul/scripts/ after updating playbooks/proposal/pre.yaml","commit_id":"4079354df5f821bdc3eaeb9a6539b8725195cc3d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"629f025d8d76ebd47a2c896cb8ed83ace88d319c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    TOPIC\u003d\"openstack/openstack-ansible-tests/sync-tests\""},{"line_number":62,"context_line":"    PROJECTS\u003d$(./gen-projects-list.sh)"},{"line_number":63,"context_line":"    function update {"},{"line_number":64,"context_line":"        bash /home/zuul/scripts/sync_openstack_ansible_common_files.sh $1"},{"line_number":65,"context_line":"    }"},{"line_number":66,"context_line":"elif [ \"$OWN_PROJECT\" \u003d\u003d \"os-service-types\" ] ; then"},{"line_number":67,"context_line":"    INITIAL_COMMIT_MSG\u003d\"Updated from OpenStack Service Type Authority\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_689c545b","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":32},"in_reply_to":"3fa7e38b_31ffaeac","updated":"2019-11-08 09:34:03.000000000","message":"Done","commit_id":"4079354df5f821bdc3eaeb9a6539b8725195cc3d"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"694408734b22a69ee98a7e54c1778e5a79532af4","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    TOPIC\u003d\"openstack/kolla/versions\""},{"line_number":78,"context_line":"    PROJECTS\u003d\"openstack/kolla\""},{"line_number":79,"context_line":"    function update {"},{"line_number":80,"context_line":"        tools/version-check.sh"},{"line_number":81,"context_line":"    }"},{"line_number":82,"context_line":"else"},{"line_number":83,"context_line":"    echo \"Unknown project $1\" \u003e2"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_7170c674","line":80,"range":{"start_line":80,"start_character":7,"end_line":80,"end_character":30},"updated":"2019-11-07 19:12:57.000000000","message":"use (see above) /home/zuul and place it in playbooks/proposal/","commit_id":"4079354df5f821bdc3eaeb9a6539b8725195cc3d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"629f025d8d76ebd47a2c896cb8ed83ace88d319c","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    TOPIC\u003d\"openstack/kolla/versions\""},{"line_number":78,"context_line":"    PROJECTS\u003d\"openstack/kolla\""},{"line_number":79,"context_line":"    function update {"},{"line_number":80,"context_line":"        tools/version-check.sh"},{"line_number":81,"context_line":"    }"},{"line_number":82,"context_line":"else"},{"line_number":83,"context_line":"    echo \"Unknown project $1\" \u003e2"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_489f1851","line":80,"range":{"start_line":80,"start_character":7,"end_line":80,"end_character":30},"in_reply_to":"3fa7e38b_7170c674","updated":"2019-11-08 09:34:03.000000000","message":"Done","commit_id":"4079354df5f821bdc3eaeb9a6539b8725195cc3d"}]}