)]}'
{"roles/build-wheels/files/wheel-build.sh":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"dc739df07591497cb11af2908bb19c2bd246dccb","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# Disable debug information in compiled C extensions, since these often"},{"line_number":17,"context_line":"# incorporate build timestamps which will cause the wheels in which they\u0027re"},{"line_number":18,"context_line":"# bundled to have different checksums each time they\u0027re built."},{"line_number":19,"context_line":"export CFLAGS\u003d-g0"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# preclean logs"},{"line_number":22,"context_line":"mkdir -p ${LOGS}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_91aabb17","line":19,"updated":"2020-01-21 16:20:56.000000000","message":"After discussion in IRC, it sounds like what you\u0027re saying is that if CFLAGS is defined in the environment calling this script (for example to set -O2 optimization level) then this will clobber it, but this seems unlikely (and if it is a real concern, we can change this to export CFLAGS\u003d\"$CFLAGS -g0\" instead). Exporting CFLAGS in this script should at least be additive with any sanely-constructed build toolchains which should append them to any baked-in compiler flags set in, say, a Makefile for the C extension. If they don\u0027t, that\u0027s a bug we should raise upstream with their respective maintainers.","commit_id":"2fafd2876b0f5fb3bc995b26754160f97d55a3a0"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"4798fe3c1c115cc41870d6aa0eead0be156c2b81","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# Disable debug information in compiled C extensions, since these often"},{"line_number":17,"context_line":"# incorporate build timestamps which will cause the wheels in which they\u0027re"},{"line_number":18,"context_line":"# bundled to have different checksums each time they\u0027re built."},{"line_number":19,"context_line":"export CFLAGS\u003d-g0"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# preclean logs"},{"line_number":22,"context_line":"mkdir -p ${LOGS}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_4915779a","line":19,"updated":"2020-01-21 22:04:10.000000000","message":"I meant using CFLAGS\u003d\"$CFLAGS -g0\" if the concern is that we\u0027re clobbering any CFLAGS value which was set in the environment which called this script, but I\u0027m honestly still not sure what you\u0027re trying to say. Is the concern that some build toolchains may only add optimization options to the cc CLI if CFLAGS is *not* already set in the environment which calls them?","commit_id":"2fafd2876b0f5fb3bc995b26754160f97d55a3a0"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"3e99c5720f2679cf429a31ed16830bbd05652634","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# Disable debug information in compiled C extensions, since these often"},{"line_number":17,"context_line":"# incorporate build timestamps which will cause the wheels in which they\u0027re"},{"line_number":18,"context_line":"# bundled to have different checksums each time they\u0027re built."},{"line_number":19,"context_line":"export CFLAGS\u003d-g0"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# preclean logs"},{"line_number":22,"context_line":"mkdir -p ${LOGS}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_62f42189","line":19,"updated":"2020-01-20 20:26:16.000000000","message":"that means no optimization, why not add \"-O2\" as well?","commit_id":"2fafd2876b0f5fb3bc995b26754160f97d55a3a0"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"70f8ca69022c3bf15ce8823a9e2fa57987da313c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# Disable debug information in compiled C extensions, since these often"},{"line_number":17,"context_line":"# incorporate build timestamps which will cause the wheels in which they\u0027re"},{"line_number":18,"context_line":"# bundled to have different checksums each time they\u0027re built."},{"line_number":19,"context_line":"export CFLAGS\u003d-g0"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# preclean logs"},{"line_number":22,"context_line":"mkdir -p ${LOGS}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_8f3cd6c0","line":19,"in_reply_to":"3fa7e38b_91aabb17","updated":"2020-01-21 17:26:02.000000000","message":"export CFLAGS\u003d\"$CFLAGS -g0\" will not work here, since we set CFLAGS here - and then call the build job.\n\nIf this overrides CFLAGS in the package, I would use CFLAGS\u003d\"-g0 -O2\".\n\nLooking at one package, it was working fine with that change.\n\nI couldn\u0027t find any definite python packaging building instructions on what to use...","commit_id":"2fafd2876b0f5fb3bc995b26754160f97d55a3a0"}]}