)]}'
{"id":"openstack%2Fproject-config~710986","triplet_id":"openstack%2Fproject-config~master~I0bdfedcc5bb00577e9c5e59a7e978fe30438eabd","project":"openstack/project-config","branch":"master","topic":"c8","hashtags":[],"change_id":"I0bdfedcc5bb00577e9c5e59a7e978fe30438eabd","subject":"Add option to get ethX interfaces on centos-8","status":"ABANDONED","created":"2020-03-03 11:56:43.000000000","updated":"2020-04-02 08:01:00.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"61add9cb4febdb2e4d6c2666821855cc10ffa8b1","_number":710986,"virtual_id_number":710986,"owner":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},{"date":"2020-03-03 12:56:49.000000000","_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"tag":"autogenerated:zuul:check","value":1,"date":"2020-03-03 12:22:03.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"disliked":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":-1,"date":"2020-03-04 10:46:56.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":1,"date":"2020-03-03 12:28:36.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"value":0,"date":"2020-03-03 14:05:39.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-03-04 00:24:53.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-03 12:22:03.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-03-03 12:28:36.000000000","updated_by":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"reviewer":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"state":"REVIEWER"},{"updated":"2020-03-03 14:05:39.000000000","updated_by":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"reviewer":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"state":"REVIEWER"},{"updated":"2020-03-04 00:24:53.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2020-03-04 10:46:56.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"}],"messages":[{"id":"b4aa2819b0bf757d0b82a6c688e791ac4ab15050","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2020-03-03 11:56:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4d3bb3936da5a874e2f77f5b80595e9515805ab6","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2020-03-03 12:06:20.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"184732bad22967b932701582fa4e0c5794b00fa3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-03 12:22:03.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-zuul-jobs-linters https://zuul.opendev.org/t/openstack/build/1e356b16686e49e28735977981f6d8eb : SUCCESS in 7m 32s\n- project-config-nodepool https://zuul.opendev.org/t/openstack/build/dd21da44e1734f189fb5cfd3de413ed7 : SUCCESS in 5m 59s","accounts_in_message":[],"_revision_number":1},{"id":"d8de3481efb3a396b4f4382e86aab93282e8c2d9","author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"date":"2020-03-03 12:28:36.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"4a140159d9e474f4d44c44826160bcb9116b7cca","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2020-03-03 12:49:58.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e189bffeeee73e56b644f26452b3d942cb155915","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2020-03-03 12:56:49.000000000","message":"Patch Set 1:\n\nThis env variable is used here: https://opendev.org/openstack/diskimage-builder/src/branch/master/diskimage_builder/elements/bootloader/finalise.d/50-bootloader#L190","accounts_in_message":[],"_revision_number":1},{"id":"d8a6cf40e838cedc69d3252f8c7bc2aa25e8985d","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2020-03-03 23:06:12.000000000","message":"Patch Set 1:\n\nthis is under active discussion in irc, but from my POV my opinion is rather straight forward : I want these images to be as consistent as possible with rhel-guest image you might download from redhat, or https://cloud.centos.org/centos/8/x86_64/images/CentOS-8-GenericCloud-8.1.1911-20200113.3.x86_64.qcow2 you would download from centos.\n\nAFAICS, neither of these set this by default, so at this point i\u0027m not sold on the argument that we should set this for our builds (either here or in dib)","accounts_in_message":[],"_revision_number":1},{"id":"836ade984d952c79fed9979a98e04f184da44815","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2020-03-04 10:46:56.000000000","message":"Patch Set 1: Code-Review-1\n\nI agree with Ian, also tripleo isn\u0027t the only consumer of these images and I don\u0027t think it would be helpful if e.g. devstack would be using this setup. It may be an option to have another flavor of the centos8 image with this additional flag set, though.","accounts_in_message":[],"_revision_number":1},{"id":"36f522267ca526f8468f0d822ff94c650a612711","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2020-03-16 14:52:43.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1},{"id":"0218b244433f7f0b5f420ad13d4c9352eaa41373","author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"date":"2020-04-02 08:01:00.000000000","message":"Patch Set 1:\n\n\u003e this is under active discussion in irc, but from my POV my opinion\n \u003e is rather straight forward : I want these images to be as\n \u003e consistent as possible with rhel-guest image you might download\n \u003e from redhat, or https://cloud.centos.org/centos/8/x86_64/images/CentOS-8-GenericCloud-8.1.1911-20200113.3.x86_64.qcow2\n \u003e you would download from centos.\n \u003e \n \u003e AFAICS, neither of these set this by default, so at this point i\u0027m\n \u003e not sold on the argument that we should set this for our builds\n \u003e (either here or in dib)\n\nActually, the CentOS cloud image does have the option:\n\n$ virt-cat -a CentOS-8-GenericCloud-8.1.1911-20200113.3.x86_64.qcow2 /etc/sysconfig/grub |grep CMDLINE\nGRUB_CMDLINE_LINUX\u003d\"console\u003dttyS0,115200n8 no_timer_check net.ifnames\u003d0 crashkernel\u003dauto\"","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"82f1be02be2d77b700436a6a014feb149d7866d5","revisions":{"82f1be02be2d77b700436a6a014feb149d7866d5":{"kind":"REWORK","_number":1,"created":"2020-03-03 11:56:43.000000000","uploader":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"ref":"refs/changes/86/710986/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/86/710986/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/86/710986/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/86/710986/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/86/710986/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/86/710986/1"}}},"commit":{"parents":[{"commit":"67cbecdfb488bdb0fce82f797abbc3ffdfe75eb7","subject":"Restore blank nodepool/scripts","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/67cbecdfb488bdb0fce82f797abbc3ffdfe75eb7"}]}],"author":{"name":"Sagi Shnaidman","email":"sshnaidm@redhat.com","date":"2020-03-03 11:53:59.000000000","tz":120},"committer":{"name":"Sagi Shnaidman","email":"sshnaidm@redhat.com","date":"2020-03-03 11:53:59.000000000","tz":120},"subject":"Add option to get ethX interfaces on centos-8","message":"Add option to get ethX interfaces on centos-8\n\nWe want to make sure network interfaces get ethX names in the\nupstream centos-8 images. This is done by adding the \"net.ifnames\u003d0\"\nparameter to the kernel command-line.\n\nIn our case, we use the DIB_BOOTLOADER_DEFAULT_CMDLINE option when\nbuilding the image. We add the current default parameters, in addition\nto the new one [1].\nAs it\u0027s done in RDO CI [2].\n\n[1] -\nhttps://docs.openstack.org/diskimage-builder/2.6.1/elements/bootloader/README.html#arguments\n[2] https://softwarefactory-project.io/r/#/c/17697/\n\nChange-Id: I0bdfedcc5bb00577e9c5e59a7e978fe30438eabd\nCo-Author: Javier Pena \u003cjpena@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/82f1be02be2d77b700436a6a014feb149d7866d5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/82f1be02be2d77b700436a6a014feb149d7866d5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}