)]}'
{"id":"openstack%2Fproject-config~719047","triplet_id":"openstack%2Fproject-config~master~Iac5db122eb41709dffcdae675137723cd49fca8f","project":"openstack/project-config","branch":"master","hashtags":[],"change_id":"Iac5db122eb41709dffcdae675137723cd49fca8f","subject":"Revert \"Revert \"Introduce job for granular GitHub mirroring\"\"","status":"MERGED","created":"2020-04-10 16:24:05.000000000","updated":"2020-04-15 05:30:11.000000000","submitted":"2020-04-15 05:30:11.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"719047-1586928611823-b16e9fe7","meta_rev_id":"0092ef9f27257cb015a0e614600308a7affdfee1","_number":719047,"virtual_id_number":719047,"owner":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":0,"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-04-15 05:30:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-04-10 19:36:15.000000000","_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"all":[{"value":2,"date":"2020-04-14 21:38:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":2,"date":"2020-04-15 05:22:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":1,"date":"2020-04-14 09:48:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"all":[{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":1,"date":"2020-04-15 05:22:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":0,"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-04-10 19:36:15.000000000","updated_by":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"reviewer":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"state":"REVIEWER"},{"updated":"2020-04-14 09:48:13.000000000","updated_by":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"reviewer":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"state":"REVIEWER"},{"updated":"2020-04-14 21:38:05.000000000","updated_by":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"reviewer":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"state":"REVIEWER"},{"updated":"2020-04-15 05:22:07.000000000","updated_by":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"reviewer":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"state":"REVIEWER"},{"updated":"2020-04-15 05:30:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7f4abcb2f04d07fe9b09dcafe43e76dc7103f4d8","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2020-04-10 16:24:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a271ea2daac8da97c29a09f9dc9e3326bfa3ad3b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-10 16:24:25.000000000","message":"Patch Set 1: Verified-1\n\n(1 comment)\n\nZuul encountered a syntax error while parsing its configuration in the\nrepo openstack/project-config on branch master.  The error was:\n\n  Job openstack-mirror-on-github not defined\n\nThe error appears in the following project stanza:\n\n  project:\n      name: openstack/release-test\n      post:\n        jobs:\n          - openstack-mirror-on-github\n\n  in \"openstack/project-config/zuul.d/projects.yaml@master\", line 3908, column 3","accounts_in_message":[],"_revision_number":1},{"id":"503ef2eadc9a2df248aaa3003832b25daf515949","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2020-04-10 16:29:01.000000000","message":"Patch Set 1:\n\nThis job needs to run in project-config and not in a branched repo, so should we enforce it with making it protected/final?","accounts_in_message":[],"_revision_number":1},{"id":"477b3b313c9ec02f9585a41572bf427862e261f9","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2020-04-10 16:53:44.000000000","message":"Patch Set 1:\n\nI\u0027m not sure that protected or final would prevent someone from just adding this job to a pipeline in-repo.  They would prevent someone inheriting it and passing other parameters, and while that\u0027s harmless, it\u0027s also confusing, so it\u0027s probably good to set them.","accounts_in_message":[],"_revision_number":1},{"id":"fa447e61703b0f66f358c34e434f29e762cf190a","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2020-04-10 16:57:33.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"55de54607ec1f1a9845862d3e741977cc95d4054","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2020-04-10 17:01:22.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"81a56f6fe2ac12dc636f2b71cec1914122f622bb","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-10 17:05:13.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-zuul-jobs-linters https://zuul.opendev.org/t/openstack/build/42e6bf84b6844c62a2e353cc6950d57a : SUCCESS in 6m 55s","accounts_in_message":[],"_revision_number":2},{"id":"33de2c479b64db31d57312706799e269a51ec8fa","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2020-04-10 19:28:43.000000000","message":"Patch Set 2:\n\nSo just to be clear, we\u0027re not going with the regular expression match on the project name(space) suggested in the ML thread?","accounts_in_message":[],"_revision_number":2},{"id":"a93dc380992a69658691ba8e0064131094c9d6e1","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2020-04-10 19:30:34.000000000","message":"Patch Set 2: Code-Review+1\n\n\u003e So just to be clear, we\u0027re not going with the regular expression\n \u003e match on the project name(space) suggested in the ML thread?\n\nLet\u0027s ask Jim about what needs adding where here..","accounts_in_message":[],"_revision_number":2},{"id":"61bf1dbf496be5acb06cd80d27ecb2dc8512b7ba","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2020-04-10 19:36:15.000000000","message":"Patch Set 2:\n\nWell, I mean, this ought to also be safe for now, it just requires a 1:1 match between OpenDev namespaces and GitHub organization names, which may not be sufficiently flexible for other projects (but will work for OpenStack so is probably a fine place to start).","accounts_in_message":[],"_revision_number":2},{"id":"183a2f705b2015bcdf3dd1761dffe66483923107","author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"date":"2020-04-14 09:48:13.000000000","message":"Patch Set 2: Code-Review+1\n\nI think that should work, but Jim should review it before we enable it :)","accounts_in_message":[],"_revision_number":2},{"id":"733110fc65c711f94e4f4f1711dbec4825039c01","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2020-04-14 21:38:05.000000000","message":"Patch Set 2: Code-Review+2\n\nI think this is secure.  It won\u0027t let someone push content to the wrong project.  The only downside of not having the regex-based check is that if someone adds this job to x/foo and the github user corresponding to this ssh key doesn\u0027t have permissions, that may register as an error on the github side, and if it happens a lot, they may notice and take action.  I doubt that anyone will add this job where it shouldn\u0027t be, and if they did, i doubt the additional noise would be enough for github to notice, so overall, I deem it a very low risk.","accounts_in_message":[],"_revision_number":2},{"id":"fd1971ba00a6cc3eca5595772467b9f782ce8856","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2020-04-15 05:22:07.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"c6ff8f7915e06d8815b9565fd4022e3e00ab413a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-15 05:22:32.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"3261b8c6ebf5151fa478b61846b41ffb7c5079ac","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-15 05:30:11.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-zuul-jobs-linters https://zuul.opendev.org/t/openstack/build/832f51922138422e821c31054b761f9a : SUCCESS in 6m 29s","accounts_in_message":[],"_revision_number":2},{"id":"0092ef9f27257cb015a0e614600308a7affdfee1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-15 05:30:11.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"64c84190aaa1651d13a0a0d9daa4a8f910a967f3","revisions":{"c7218aa4c869530b5dd0ed0ad5a4c207374762e4":{"kind":"REWORK","_number":1,"created":"2020-04-10 16:24:05.000000000","uploader":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"ref":"refs/changes/47/719047/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/47/719047/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/47/719047/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/47/719047/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/47/719047/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/47/719047/1"}}},"commit":{"parents":[{"commit":"f2459f87161ea711079035679733b98d026f8368","subject":"Drop dependencies from manage-projects","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/f2459f87161ea711079035679733b98d026f8368"}]}],"author":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2020-04-10 16:19:31.000000000","tz":-240},"committer":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2020-04-10 16:23:24.000000000","tz":-240},"subject":"Revert \"Revert \"Introduce job for granular GitHub mirroring\"\"","message":"Revert \"Revert \"Introduce job for granular GitHub mirroring\"\"\n\nThis change inroduces the usage of the parent job which enforces\na project name inside of it to avoid a project from mirroring\nmaliciously to another one.\n\nIt reparents it to the nodeless job inside opendev, enforeces the\nsetting of target_repository inside the secret so it cannot be modified\nand fixes the `user` to point to `git` instead.\n\nThis reverts commit 04133b4bccb931b403a22ddcd49737e02907dd2a.\n\nChange-Id: Iac5db122eb41709dffcdae675137723cd49fca8f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/c7218aa4c869530b5dd0ed0ad5a4c207374762e4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/c7218aa4c869530b5dd0ed0ad5a4c207374762e4"}]},"branch":"refs/heads/master"},"64c84190aaa1651d13a0a0d9daa4a8f910a967f3":{"kind":"REWORK","_number":2,"created":"2020-04-10 16:57:33.000000000","uploader":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"ref":"refs/changes/47/719047/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/47/719047/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/47/719047/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/47/719047/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/47/719047/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/47/719047/2"}}},"commit":{"parents":[{"commit":"f2459f87161ea711079035679733b98d026f8368","subject":"Drop dependencies from manage-projects","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/f2459f87161ea711079035679733b98d026f8368"}]}],"author":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2020-04-10 16:19:31.000000000","tz":-240},"committer":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2020-04-10 16:57:25.000000000","tz":-240},"subject":"Revert \"Revert \"Introduce job for granular GitHub mirroring\"\"","message":"Revert \"Revert \"Introduce job for granular GitHub mirroring\"\"\n\nThis change inroduces the usage of the parent job which enforces\na project name inside of it to avoid a project from mirroring\nmaliciously to another one.\n\nIt reparents it to the nodeless job inside opendev, enforeces the\nsetting of target_repository inside the secret so it cannot be modified\nand fixes the `user` to point to `git` instead.\n\nThis reverts commit 04133b4bccb931b403a22ddcd49737e02907dd2a.\n\nChange-Id: Iac5db122eb41709dffcdae675137723cd49fca8f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/64c84190aaa1651d13a0a0d9daa4a8f910a967f3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/64c84190aaa1651d13a0a0d9daa4a8f910a967f3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}