)]}'
{"tox.ini":[{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"7523e54035ffb8226ffb58f35113b97ec22d2adf","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# Add dependencies here since other jobs use python2 and zuul requires"},{"line_number":27,"context_line":"# python3."},{"line_number":28,"context_line":"deps \u003d"},{"line_number":29,"context_line":"     # ansible-lint brings in the latest version of ansible, but we"},{"line_number":30,"context_line":"     # keep this in sync with what Zuul uses so we don\u0027t allow though"},{"line_number":31,"context_line":"     # things from a later ansible that would actually fail in"},{"line_number":32,"context_line":"     # production."},{"line_number":33,"context_line":"     ansible\u003e\u003d2.8,\u003c2.9"},{"line_number":34,"context_line":"     ansible-lint\u003e\u003d4.2.0,\u003c5"},{"line_number":35,"context_line":"     hacking\u003e\u003d2.0.0,\u003c2.1.0"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1f621f24_ba89ee75","line":32,"range":{"start_line":29,"start_character":0,"end_line":32,"end_character":18},"updated":"2020-11-14 09:28:47.000000000","message":"I find this comment bit confusing for multiple reasons:\na) you do not know which version zuul uses (is not defined here), also zuul may use multiple versions\nb) old versions will not be able to highlight a serious range of issues and deprecations\nc) linting is not functional testing, it does provide much ensurance that that code will run correctly on a particular version of ansible\n\nIf you really want to run a ansible-linting with the oldeds version of Ansible supported by current repository, you can try to create an additional job like a \"tox-linters-lower\" that does this.\n\nStill, when running a single time, by far the vest results will be obtained from using latest versions. I would personally even advocate to run on 2.10.","commit_id":"10942587e532825acd6c5d5711ae8ff6353abf5b"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"7523e54035ffb8226ffb58f35113b97ec22d2adf","unresolved":false,"context_lines":[{"line_number":30,"context_line":"     # keep this in sync with what Zuul uses so we don\u0027t allow though"},{"line_number":31,"context_line":"     # things from a later ansible that would actually fail in"},{"line_number":32,"context_line":"     # production."},{"line_number":33,"context_line":"     ansible\u003e\u003d2.8,\u003c2.9"},{"line_number":34,"context_line":"     ansible-lint\u003e\u003d4.2.0,\u003c5"},{"line_number":35,"context_line":"     hacking\u003e\u003d2.0.0,\u003c2.1.0"},{"line_number":36,"context_line":"     bashate\u003e\u003d0.2"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1f621f24_9ab7d23a","line":33,"range":{"start_line":33,"start_character":5,"end_line":33,"end_character":22},"updated":"2020-11-14 09:28:47.000000000","message":"I am afraid this is not a fix because current version of the linter does not support ansible 2.8, minimal version being 2.9.\n\nThat is mentioned in first paragraph of the readme https://github.com/ansible/ansible-lint/","commit_id":"10942587e532825acd6c5d5711ae8ff6353abf5b"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"7523e54035ffb8226ffb58f35113b97ec22d2adf","unresolved":false,"context_lines":[{"line_number":35,"context_line":"     hacking\u003e\u003d2.0.0,\u003c2.1.0"},{"line_number":36,"context_line":"     bashate\u003e\u003d0.2"},{"line_number":37,"context_line":"commands \u003d"},{"line_number":38,"context_line":"  {toxinidir}/tools/run-bashate.sh"},{"line_number":39,"context_line":"  flake8"},{"line_number":40,"context_line":"  # Run some policy checks on zuul.d/projects.yaml"},{"line_number":41,"context_line":"  {toxinidir}/tools/zuul-projects-checks.py"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1f621f24_5a9a5ab8","line":38,"range":{"start_line":38,"start_character":2,"end_line":38,"end_character":34},"updated":"2020-11-14 09:28:47.000000000","message":"first command here must be \"pip check\", this will assure that you stop the run if there are dependency conflicts.","commit_id":"10942587e532825acd6c5d5711ae8ff6353abf5b"}]}