)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7663b47f2ee43d7b2584bfee3aedce8ec16f5c09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6436b56a_b98ae9b9","updated":"2021-10-28 06:58:44.000000000","message":"thanks","commit_id":"5f0278475a8404a3ac742be2d5bd66b9938cab87"}],"nodepool/elements/infra-package-needs/install.d/10-packages":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a636055720b3c0c037fba7477664bb0c932acaef","unresolved":true,"context_lines":[{"line_number":20,"context_line":"fi"},{"line_number":21,"context_line":"set -e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"if [[ \"$DISTRO_NAME\" \u003d\u003d centos \u0026\u0026 \"$DIB_RELEASE\" !\u003d \"9-stream\" ]] ; then"},{"line_number":24,"context_line":"    # Note: $YUM exposed by centos environment, correct across releases"},{"line_number":25,"context_line":"    ${YUM} -y install --enablerepo\u003depel haveged"},{"line_number":26,"context_line":"elif [[ \"$DISTRO_NAME\" \u003d\u003d centos \u0026\u0026 \"$DIB_RELEASE\" \u003d\u003d \"9-stream\" ]] ; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"c68d2235_229538b4","line":23,"range":{"start_line":23,"start_character":49,"end_line":23,"end_character":51},"updated":"2021-10-25 05:29:25.000000000","message":"should it be -lt \"9-stream\" ?\nif we really mean explicitly if it is \"8\" then lets do that?\n\nif [[ ... \u0026\u0026  \"${DIB_RELEASE%-stream}\" \u003d\u003d \"8\" ]]; then","commit_id":"c186987fca1b7ad8a60586ad9ab14f8d70102ef1"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"35d1277af742fa2b90f14ce9c2b3feb3d13b0265","unresolved":true,"context_lines":[{"line_number":20,"context_line":"fi"},{"line_number":21,"context_line":"set -e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"if [[ \"$DISTRO_NAME\" \u003d\u003d centos \u0026\u0026 \"$DIB_RELEASE\" !\u003d \"9-stream\" ]] ; then"},{"line_number":24,"context_line":"    # Note: $YUM exposed by centos environment, correct across releases"},{"line_number":25,"context_line":"    ${YUM} -y install --enablerepo\u003depel haveged"},{"line_number":26,"context_line":"elif [[ \"$DISTRO_NAME\" \u003d\u003d centos \u0026\u0026 \"$DIB_RELEASE\" \u003d\u003d \"9-stream\" ]] ; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"8149ffba_3f3ac99f","line":23,"range":{"start_line":23,"start_character":49,"end_line":23,"end_character":51},"in_reply_to":"c68d2235_229538b4","updated":"2021-10-25 09:30:34.000000000","message":"+1 for that","commit_id":"c186987fca1b7ad8a60586ad9ab14f8d70102ef1"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"db2b060a744a4d25d55af82412f5a94cfe2e4d4f","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    # There is no epel9 yet, so we need to install haveged from RDO Dependencies repo"},{"line_number":28,"context_line":"    curl -L -o /etc/yum.repos.d/delorean-deps.repo https://trunk.rdoproject.org/centos9-master/delorean-deps.repo"},{"line_number":29,"context_line":"    ${YUM} -y install haveged"},{"line_number":30,"context_line":"    rm -f /etc/yum.repos.d/delorean-deps.repo"},{"line_number":31,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1b8b2587_b4331820","line":30,"updated":"2021-10-28 23:13:23.000000000","message":"My preference would be that we not rely on RDO packages during the build process as much as possible as the rdo package repos haven\u0027t always been the most relaible.\n\nInstead I think we can either wait for haveged to be part of the operating system or find an alternative or centos-9 can happen without entropy generation and maybe that will convince people to get entropy generation into the distro :)","commit_id":"5f0278475a8404a3ac742be2d5bd66b9938cab87"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"f3e73a8856ad61888466ac670f840cc4523d0ab5","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    # There is no epel9 yet, so we need to install haveged from RDO Dependencies repo"},{"line_number":28,"context_line":"    curl -L -o /etc/yum.repos.d/delorean-deps.repo https://trunk.rdoproject.org/centos9-master/delorean-deps.repo"},{"line_number":29,"context_line":"    ${YUM} -y install haveged"},{"line_number":30,"context_line":"    rm -f /etc/yum.repos.d/delorean-deps.repo"},{"line_number":31,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"931cd01f_d271e837","line":30,"in_reply_to":"1b8b2587_b4331820","updated":"2021-10-29 08:06:15.000000000","message":"ok, i\u0027ll just remove it.\n\nSince centos8, rng-tools package included in RHEL/Centos and installed by default in dib images includes support for jitter entropy source by default when a better generator is not found, so I guess using rngd should be good enough?\n\nBTW, as RDO maintainer, i\u0027d like to know what have been the issues with rdo packages in the past. Said that, i agree in the general goal of minimizing repositories during build.","commit_id":"5f0278475a8404a3ac742be2d5bd66b9938cab87"}],"nodepool/elements/infra-package-needs/pkg-map":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"7c35b796df1e273f24bcb520da932fa96bd1eea2","unresolved":true,"context_lines":[{"line_number":5,"context_line":"        \"python-dev\": \"\","},{"line_number":6,"context_line":"        \"ntp\": \"chrony\","},{"line_number":7,"context_line":"        \"ntpdate\": \"\""},{"line_number":8,"context_line":"       },"},{"line_number":9,"context_line":"      \"9-stream\": {"},{"line_number":10,"context_line":"        \"python-dev\": \"\","},{"line_number":11,"context_line":"        \"ntp\": \"chrony\","}],"source_content_type":"application/octet-stream","patch_set":4,"id":"22761064_3bae550d","line":8,"updated":"2021-11-04 23:43:25.000000000","message":"i am guessing 8-stream actually matches on this?  i\u0027m not sure i want to think too hard about it right now","commit_id":"4e88e748bbfd877b45b4032ae899a6ef03fc05e6"}],"nodepool/elements/nodepool-base/package-installs.yaml":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"4784ff34419355d6923e8f06d90a314b89325411","unresolved":true,"context_lines":[{"line_number":1,"context_line":"unbound:"},{"line_number":2,"context_line":"iptables-services:"},{"line_number":3,"context_line":"  when:"},{"line_number":4,"context_line":"    - DIB_RELEASE \u003d 9-stream"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b7ec1d82_9fbad360","line":4,"updated":"2021-10-28 22:27:54.000000000","message":"for consistency, this should really go in the pkg-map file, with only centos-9 installing this and the others leaving it blank.  other distros might need to do similar as iptables seems to be somewhat on the way out...","commit_id":"5f0278475a8404a3ac742be2d5bd66b9938cab87"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"f3e73a8856ad61888466ac670f840cc4523d0ab5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"unbound:"},{"line_number":2,"context_line":"iptables-services:"},{"line_number":3,"context_line":"  when:"},{"line_number":4,"context_line":"    - DIB_RELEASE \u003d 9-stream"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7fde1557_75846575","line":4,"in_reply_to":"b7ec1d82_9fbad360","updated":"2021-10-29 08:06:15.000000000","message":"Actually, i\u0027ve just realized that iptables is included in infra-package-needs so I\u0027ll fix it there.","commit_id":"5f0278475a8404a3ac742be2d5bd66b9938cab87"}]}