)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"45c699c42f7da6f818437a1d9e8f1c73002264ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4086f871_8a824e4e","updated":"2021-11-02 14:43:23.000000000","message":"I was a bit confused when I reviewed the code. If I understand correctly the problem is that we have release liaisons listed at two different places: releases repository and governance repository.\n\nMy understanding is that the listed \u0027release liaisons\u0027 in governance repository are actually members who shares the PTL role with each other.\n\nShouldn\u0027t we somehow eliminate the redundancy and keep the data up to date at one place instead?","commit_id":"f2de286150fcf0434cf5381e048b1d52dfe5c953"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"1daae1b2402bea9eadf639c0623c70e28a20cccd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fdaa23b3_84a1f328","updated":"2022-07-08 15:10:00.000000000","message":"I\u0027ve updated this patch to match more with the very similar check_approval.py [1] patch in the release repository.\n\n[1] https://review.opendev.org/c/openstack/releases/+/815499/2","commit_id":"f2a5c9a1c929f4ba912066a6581b7d472eb93230"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d5b0518e4c470cf2f4a17c3ffc15dd1dfef5f789","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"52b4f3b2_7f80a81d","updated":"2023-09-28 12:36:38.000000000","message":"Well, I completely forgot about this patch, and proposed another [1]. Though the distributed leadership type checking is not even working in this patch, so the other patch is better.\n\nNevertheless, it\u0027s a good proposal to move data from\n  openstack/releases, data/release_liaisons.yaml\nto\n  openstack/governance, reference/projects.yaml\nto eliminate some data redundancy. Added this suggestion to Bobcat\u0027s tracking etherpad\u0027s \u0027things to change section\u0027 to not to forget.\n\n[1] https://review.opendev.org/c/openstack/project-config/+/896785","commit_id":"f2a5c9a1c929f4ba912066a6581b7d472eb93230"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"a6e199ae29ec6397e274f3df8161456353420ad2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1de0f0a3_facabc2d","in_reply_to":"52b4f3b2_7f80a81d","updated":"2023-09-28 12:39:48.000000000","message":"I think this can be abandoned and referenced patch [1] can be merged instead for now. (until we figure out whether the data/release_liaisons.yaml can be merged to projects.yaml or not)","commit_id":"f2a5c9a1c929f4ba912066a6581b7d472eb93230"}],"roles/check-release-approval/files/check_approval.py":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"45c699c42f7da6f818437a1d9e8f1c73002264ea","unresolved":true,"context_lines":[{"line_number":126,"context_line":"                break"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"            # Fetch PTL and release liaisons"},{"line_number":129,"context_line":"            liaisons \u003d get_liaisons(self.workspace, team)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"            # Sone teams follow the \"distributed project lead\" governance"},{"line_number":132,"context_line":"            # model so they are PTL-less but they have release liaisons"}],"source_content_type":"text/x-python","patch_set":2,"id":"c0811188_f64dda6c","line":129,"range":{"start_line":129,"start_character":12,"end_line":129,"end_character":57},"updated":"2021-11-02 14:43:23.000000000","message":"Isn\u0027t this doing the same as the below new code?\n\nLater: OK I realized that this fetches the liaisons from release_liaisons.yaml, while the below code reads the release liaisons list from the governance repository\u0027s projects.yaml file.","commit_id":"f2de286150fcf0434cf5381e048b1d52dfe5c953"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d5b0518e4c470cf2f4a17c3ffc15dd1dfef5f789","unresolved":true,"context_lines":[{"line_number":131,"context_line":"            # Some teams follow the \"distributed project lead\" governance"},{"line_number":132,"context_line":"            # model so they are PTL-less but they have release liaisons"},{"line_number":133,"context_line":"            # defined. Fetch those liaisons."},{"line_number":134,"context_line":"            if govteam.get(\u0027distributed\u0027, None):"},{"line_number":135,"context_line":"                distributed_ptl_liaisons \u003d govteam[\u0027liaison\u0027][\u0027release\u0027]"},{"line_number":136,"context_line":"                for liaison in distributed_ptl_liaisons:"},{"line_number":137,"context_line":"                    liaisons.append(liaison[\u0027email\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"66722fcc_65ac9927","line":134,"updated":"2023-09-28 12:36:38.000000000","message":"this should be \n  if govteam.get(\u0027leadership_type\u0027, None) \u003d\u003d \u0027distributed\u0027:","commit_id":"f2a5c9a1c929f4ba912066a6581b7d472eb93230"}]}