)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0f574ff5c804e56c33f618f27c5786993692da35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2bb035b8_c2a528c6","updated":"2022-01-14 16:22:32.000000000","message":"First -1 because the fix misses an additional bit the upstream fix does. Details inline.\n\nBut also because I don\u0027t think we should take this approach. The distro is broken and our images accurately affect that. If you fix it this way then your software will only work on specially customized images. Instead you should workaround this in your software or push upstream to fix things. Or the more drastic approach would be to stop testing/supporting a platform that does not perform basic CI and allows simple but problematic issues like this to fall through the cracks.","commit_id":"71781d3aaff8ae8b0e35468255d50f183f5025d3"}],"nodepool/elements/ping-sysctl-fix/install.d/10-ping-sysctl":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0f574ff5c804e56c33f618f27c5786993692da35","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"cat \u003e /etc/sysctl.d/99-ping-sysctl-fix.conf \u003c\u003cEOF"},{"line_number":10,"context_line":"# See https://bugzilla.redhat.com/show_bug.cgi?id\u003d2037807"},{"line_number":11,"context_line":"net.ipv4.ping_group_range \u003d 0 2147483647"},{"line_number":12,"context_line":"EOF"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"a370f077_8d3e8858","line":11,"updated":"2022-01-14 16:22:32.000000000","message":"This should be prefixed by \u0027-\u0027 resulting in:\n\n  -net.ipv4.ping_group_range \u003d 0 2147483647\n\nPer the PR in github https://github.com/redhat-plumbers/systemd-rhel8/commit/41a32aeaf5d33f253f48bfbe8d00de9d160985f7","commit_id":"71781d3aaff8ae8b0e35468255d50f183f5025d3"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"dd0ddbf43188382491ed65281510cd8b1e18847c","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"cat \u003e /etc/sysctl.d/99-ping-sysctl-fix.conf \u003c\u003cEOF"},{"line_number":10,"context_line":"# See https://bugzilla.redhat.com/show_bug.cgi?id\u003d2037807"},{"line_number":11,"context_line":"net.ipv4.ping_group_range \u003d 0 2147483647"},{"line_number":12,"context_line":"EOF"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"90043dd0_a298e1dd","line":11,"in_reply_to":"a370f077_8d3e8858","updated":"2022-01-14 21:41:01.000000000","message":"I noticed it while preparing the patch and looked for the reason: it makes the sysctl setting non-fatal. If I understand correctly, it was prompted by failures to apply this sysctl from within containers: https://github.com/systemd/systemd/issues/13177\n\nThis didn\u0027t seem to apply in this case, I actually wanted the opposite, i.e. making sure that the sysctl was applied successfully, which is why I left out the leading dash.","commit_id":"71781d3aaff8ae8b0e35468255d50f183f5025d3"}]}