)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c5776f083e13270eff048bf7f75c452315869bcb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"897b3267_138ad884","updated":"2022-08-11 00:32:14.000000000","message":"I will monitor this","commit_id":"c043b9c2b68fc0fa447adf3bb45bce76ff27de42"}],"nodepool/elements/infra-package-needs/install.d/10-packages":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"4e2baa5a5d70dbc8553c39f56e0bbb21d7351117","unresolved":false,"context_lines":[{"line_number":20,"context_line":"fi"},{"line_number":21,"context_line":"set -e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"if [[ \"$DISTRO_NAME\" \u003d~ ^(centos|rocky)$ \u0026\u0026 \u00279\u0027 \u003d~ ${DIB_RELEASE} ]] ; then"},{"line_number":24,"context_line":"    # 9-stream we are just using the default rngd"},{"line_number":25,"context_line":"    # Note: $YUM exposed by centos|rhel-like environment, correct across releases"},{"line_number":26,"context_line":"    ${YUM} -y install --enablerepo\u003depel haveged"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7aa37b99_db9b9287","line":23,"updated":"2022-08-09 11:35:05.000000000","message":"Also the order of the parameters is backwards, based on what I see in the bash manpage: \"An additional binary operator, \u003d~, is available, with the same precedence as \u003d\u003d and !\u003d. When it is used, the string to the right of the operator is considered a POSIX extended regular expression and matched accordingly (using the POSIX regcomp and regexec interfaces usually described in regex(3)). The return value is 0 if the string matches the pattern, and 1 otherwise.\" So yes, it looks like we want \"... \u0026\u0026 ! ${DIB_RELEASE} \u003d~ \u0027^9\u0027\" here (invert the return value and reverse the parameters in the comparison).","commit_id":"5c57a3bee2857c90cbaaa3df84cb9fbeeb3b0d24"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3e879083ddef8773ad76158451ba3a4664263c54","unresolved":true,"context_lines":[{"line_number":20,"context_line":"fi"},{"line_number":21,"context_line":"set -e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"if [[ \"$DISTRO_NAME\" \u003d~ ^(centos|rocky)$ \u0026\u0026 \u00279\u0027 \u003d~ ${DIB_RELEASE} ]] ; then"},{"line_number":24,"context_line":"    # 9-stream we are just using the default rngd"},{"line_number":25,"context_line":"    # Note: $YUM exposed by centos|rhel-like environment, correct across releases"},{"line_number":26,"context_line":"    ${YUM} -y install --enablerepo\u003depel haveged"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"2240bcb9_a59ab1f2","line":23,"updated":"2022-08-09 08:29:01.000000000","message":"IIUC this is inverting the condition?","commit_id":"5c57a3bee2857c90cbaaa3df84cb9fbeeb3b0d24"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"9902c74fa6a94e715fc7edfe4e4ba3f0e8473c64","unresolved":false,"context_lines":[{"line_number":20,"context_line":"fi"},{"line_number":21,"context_line":"set -e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"if [[ \"$DISTRO_NAME\" \u003d~ ^(centos|rocky)$ \u0026\u0026 \u00279\u0027 \u003d~ ${DIB_RELEASE} ]] ; then"},{"line_number":24,"context_line":"    # 9-stream we are just using the default rngd"},{"line_number":25,"context_line":"    # Note: $YUM exposed by centos|rhel-like environment, correct across releases"},{"line_number":26,"context_line":"    ${YUM} -y install --enablerepo\u003depel haveged"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"0bde9487_61d3b3b8","line":23,"in_reply_to":"2240bcb9_a59ab1f2","updated":"2022-08-10 01:34:50.000000000","message":"Thanks, fixed in next revision","commit_id":"5c57a3bee2857c90cbaaa3df84cb9fbeeb3b0d24"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"7683d2ea12d2a188ec3024b217a18d6993151848","unresolved":false,"context_lines":[{"line_number":20,"context_line":"fi"},{"line_number":21,"context_line":"set -e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"if [[ \"$DISTRO_NAME\" \u003d~ ^(centos|rocky)$ \u0026\u0026 \u00279\u0027 \u003d~ ${DIB_RELEASE} ]] ; then"},{"line_number":24,"context_line":"    # 9-stream we are just using the default rngd"},{"line_number":25,"context_line":"    # Note: $YUM exposed by centos|rhel-like environment, correct across releases"},{"line_number":26,"context_line":"    ${YUM} -y install --enablerepo\u003depel haveged"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"a299d7f9_885ade99","line":23,"in_reply_to":"7aa37b99_db9b9287","updated":"2022-08-10 01:29:00.000000000","message":"I think this is a habit picked up from constructs like\n\n \"amd64 arm64 powerpc\" \u003d~ $ARCH\n \nwhich could also be written as\n\n $ARCH \u003d~ (amd64|arm64|powerpc)\n \nwhich you would probably say is clearer","commit_id":"5c57a3bee2857c90cbaaa3df84cb9fbeeb3b0d24"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6818e6e9e6cef2193d1ea80490c14112f3f20ad3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"fi"},{"line_number":21,"context_line":"set -e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"if [[ \"$DISTRO_NAME\" \u003d~ ^(centos|rocky)$ \u0026\u0026 \u00279\u0027 \u003d~ ${DIB_RELEASE} ]] ; then"},{"line_number":24,"context_line":"    # 9-stream we are just using the default rngd"},{"line_number":25,"context_line":"    # Note: $YUM exposed by centos|rhel-like environment, correct across releases"},{"line_number":26,"context_line":"    ${YUM} -y install --enablerepo\u003depel haveged"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"86e495eb_e342ae89","line":23,"in_reply_to":"a299d7f9_885ade99","updated":"2022-08-10 01:29:39.000000000","message":"which you would probably say is clearer\n \nby \"you\" I mean, anyone who would read that code in general 😊","commit_id":"5c57a3bee2857c90cbaaa3df84cb9fbeeb3b0d24"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c389a3490dc26433ddf5fda7cdebfe7a1eb7bd6d","unresolved":true,"context_lines":[{"line_number":20,"context_line":"fi"},{"line_number":21,"context_line":"set -e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"if [[ \"$DISTRO_NAME\" \u003d~ ^(centos|rocky)$ \u0026\u0026 ${DIB_RELEASE} \u003d~ \u00279\u0027 ]] ; then"},{"line_number":24,"context_line":"    # 9-stream we are just using the default rngd"},{"line_number":25,"context_line":"    # Note: $YUM exposed by centos|rhel-like environment, correct across releases"},{"line_number":26,"context_line":"    ${YUM} -y install --enablerepo\u003depel haveged"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"733483cd_b528595e","line":23,"updated":"2022-08-11 00:16:31.000000000","message":"I believe this matches 9-stream now as the DIB_RELEASE whereas before we excluded it:\n\n  $ [[ 9-stream \u003d~ \u00279\u0027 ]]\n  $ echo $?\n  0","commit_id":"cf9b048e3dce7ea8f5d2a72a261136adaeff4b40"}]}