)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b77958dd47e38ba253aa0d1b15ffaa71bd7775ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0b4da973_f332bd12","updated":"2022-09-12 10:00:06.000000000","message":"It is not clear to me how we will avoid breaking 2023.1 unit tests when later for 2023.2 we e.g. add openstack-tox-py311 jobs to the generic templates.","commit_id":"c613f54ea0423945972bc6207b24155d7a8ca1a4"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"79ae414f00ff2c68f6ddf12c2ae72349104cfc1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b26de440_09096202","updated":"2022-09-12 09:39:48.000000000","message":"Maybe amend the generated commit message and possibly the branch name, too?\n\nAlso make a note that this script will be redundant after the current cycle?\n\nIs somewhere documented how template names will be changed to stable versions in the current new stable branches?","commit_id":"c613f54ea0423945972bc6207b24155d7a8ca1a4"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d807b44c14e0ffb4677ef5925dbb3d7dc9b28a0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aae15bc7_d3441e62","updated":"2022-09-12 06:48:45.000000000","message":"Thanks Ghanshyam! Though we started already the branching for libs we still ahead of branching the RC release type deliverables so this is OK to merge as soon as possible so that we won\u0027t generate wrongly the next bunch of patches.\n\nAnd for that the new job template [1] needs to be merged as soon as possible, too.\n\n[1] https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/856903","commit_id":"c613f54ea0423945972bc6207b24155d7a8ca1a4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b45dcc035aa77d5588903b84aa20d1a017aadb1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3d1c4d16_5b0301bc","in_reply_to":"0b4da973_f332bd12","updated":"2022-09-12 11:02:35.000000000","message":"ok, we will do that by branch variant and yes adding openstack-tox-py311 to run for master and say openstack-tox-py39 until 2023.2 (if we drop 39 testing in 2023.2)","commit_id":"c613f54ea0423945972bc6207b24155d7a8ca1a4"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b77958dd47e38ba253aa0d1b15ffaa71bd7775ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"06e01ee2_d31b2c72","in_reply_to":"3a8dfa72_5a65a270","updated":"2022-09-12 10:00:06.000000000","message":"Added inline comments that hopefully are clearer","commit_id":"c613f54ea0423945972bc6207b24155d7a8ca1a4"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"06560d9b72314c0eb0ac0fcbe20158952d409e9e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"49e34ff0_9354ebb3","in_reply_to":"3d1c4d16_5b0301bc","updated":"2022-09-12 11:58:17.000000000","message":"So IIUC the idea is to have branch-specific versions of the project-template? Was this ever discussed with the Zuul team? Because from what I can see in the docs[0], this isn\u0027t possible. You could have different variants of a openstack-tox-py311 job, but you cannot have a master version of the openstack-python3-jobs template that includes it and a stable/antelope version that doesn\u0027t. At least that is my current understanding, I will verify in the Zuul channel.\n\n[0] https://zuul-ci.org/docs/zuul/latest/config/project.html#project-template","commit_id":"c613f54ea0423945972bc6207b24155d7a8ca1a4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"02402e0708c77ec7f75d7840f6357ee46ce30d51","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"74367092_25b42bc2","in_reply_to":"49e34ff0_9354ebb3","updated":"2022-09-12 12:23:58.000000000","message":"this can be done like this way https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/856903/1/zuul.d/project-templates.yaml#1466","commit_id":"c613f54ea0423945972bc6207b24155d7a8ca1a4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c012950ea6788d1f2e034c6c1d5d2a29969ab07c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3a8dfa72_5a65a270","in_reply_to":"b26de440_09096202","updated":"2022-09-12 09:43:29.000000000","message":"sure, I will add the note.\n\nalso this is patch making template name generic and how to update it on every release https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/856903\n\nI am not clear what update you would like to have in generated commit msg?","commit_id":"c613f54ea0423945972bc6207b24155d7a8ca1a4"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e264d14cb435fd16ab7aa3e0166010117fab0813","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ff3eadf5_ef080527","updated":"2022-09-12 12:56:41.000000000","message":"Ok, not sure how complicated that will become over time, but I think it can work.","commit_id":"acbfd1d74a237b3d48fe52a6961a7db43bf1ea51"}],"roles/copy-release-tools-scripts/files/release-tools/add_master_python3_jobs.sh":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b77958dd47e38ba253aa0d1b15ffaa71bd7775ba","unresolved":true,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"cd $REPO"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"commit_msg\u003d\"Add Python3 ${SERIES} unit tests"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"This is an automatically generated patch to ensure unit testing"},{"line_number":43,"context_line":"is in place for all the of the tested runtimes for ${SERIES}."}],"source_content_type":"text/x-sh","patch_set":1,"id":"5e534590_16be280a","line":40,"updated":"2022-09-12 10:00:06.000000000","message":"This would rather be something like\n\n\"Switch to generic Python3 unit tests\"\n\nmaybe? Not sure about best wording, but the new template isn\u0027t series-specific anymore, is it?","commit_id":"c613f54ea0423945972bc6207b24155d7a8ca1a4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b45dcc035aa77d5588903b84aa20d1a017aadb1b","unresolved":true,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"cd $REPO"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"commit_msg\u003d\"Add Python3 ${SERIES} unit tests"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"This is an automatically generated patch to ensure unit testing"},{"line_number":43,"context_line":"is in place for all the of the tested runtimes for ${SERIES}."}],"source_content_type":"text/x-sh","patch_set":1,"id":"221e2eef_6d8d1049","line":40,"in_reply_to":"5e534590_16be280a","updated":"2022-09-12 11:02:35.000000000","message":"we are making name as generic but same template will be run different set of jobs per release.\n\nFor example, the change by this script will move unit tests to 2023.1 Antilope testing but via generic template name. so there is change in py3 testing from that it is. I can change commit msg to:\n\n\"Switch to 2023.1 Python3 unit tests and generic template name\"","commit_id":"c613f54ea0423945972bc6207b24155d7a8ca1a4"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b77958dd47e38ba253aa0d1b15ffaa71bd7775ba","unresolved":true,"context_lines":[{"line_number":40,"context_line":"commit_msg\u003d\"Add Python3 ${SERIES} unit tests"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"This is an automatically generated patch to ensure unit testing"},{"line_number":43,"context_line":"is in place for all the of the tested runtimes for ${SERIES}."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"See also the PTI in governance [1]."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3928c808_b3b34284","line":43,"updated":"2022-09-12 10:00:06.000000000","message":"Same here.","commit_id":"c613f54ea0423945972bc6207b24155d7a8ca1a4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b45dcc035aa77d5588903b84aa20d1a017aadb1b","unresolved":true,"context_lines":[{"line_number":40,"context_line":"commit_msg\u003d\"Add Python3 ${SERIES} unit tests"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"This is an automatically generated patch to ensure unit testing"},{"line_number":43,"context_line":"is in place for all the of the tested runtimes for ${SERIES}."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"See also the PTI in governance [1]."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"df0019ee_a4bd6ec2","line":43,"in_reply_to":"3928c808_b3b34284","updated":"2022-09-12 11:02:35.000000000","message":"I will add line for updating template to generic one but unit test switching is all valid as new template will move to new tests.","commit_id":"c613f54ea0423945972bc6207b24155d7a8ca1a4"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b77958dd47e38ba253aa0d1b15ffaa71bd7775ba","unresolved":true,"context_lines":[{"line_number":53,"context_line":"for fname in $fnames; do"},{"line_number":54,"context_line":"    echo \"Checking ${fname}\""},{"line_number":55,"context_line":"    sed -i -e \\"},{"line_number":56,"context_line":"        \"s/openstack-python3-${OLDSERIES}-jobs/openstack-python3-jobs/g\" \\"},{"line_number":57,"context_line":"        $fname"},{"line_number":58,"context_line":"done"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"af0454e6_ecc4bb18","line":56,"updated":"2022-09-12 10:00:06.000000000","message":"And this should then match what we come up with in L40","commit_id":"c613f54ea0423945972bc6207b24155d7a8ca1a4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b45dcc035aa77d5588903b84aa20d1a017aadb1b","unresolved":true,"context_lines":[{"line_number":53,"context_line":"for fname in $fnames; do"},{"line_number":54,"context_line":"    echo \"Checking ${fname}\""},{"line_number":55,"context_line":"    sed -i -e \\"},{"line_number":56,"context_line":"        \"s/openstack-python3-${OLDSERIES}-jobs/openstack-python3-jobs/g\" \\"},{"line_number":57,"context_line":"        $fname"},{"line_number":58,"context_line":"done"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"ec9dd7f3_1884c51d","line":56,"in_reply_to":"af0454e6_ecc4bb18","updated":"2022-09-12 11:02:35.000000000","message":"ditto. new template switching to new tests is \u0027openstack-python3-jobs\u0027","commit_id":"c613f54ea0423945972bc6207b24155d7a8ca1a4"}]}
