)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a2ddf9412d353237665ac4653830d4c4a87ab1a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"437bb88b_9f9293ac","updated":"2022-11-29 03:18:59.000000000","message":"LGTM but I won\u0027t approve right now as I may not be around in a few hours if it goes wrong.  ","commit_id":"368bb77ee36d3bdae42cf77e57cfaa2718f383f4"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a8cbd029c4fa7fda619ea4ec8822edd155221644","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"054ca056_90cf7606","updated":"2022-11-28 16:56:52.000000000","message":"Not approving to give ianw a quick chance to double check things.","commit_id":"368bb77ee36d3bdae42cf77e57cfaa2718f383f4"}],"nodepool/elements/nodepool-base/finalise.d/89-boot-settings":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"bbd26e9f2e40ea4b5701fc28691f669af56724f7","unresolved":true,"context_lines":[{"line_number":168,"context_line":"  p.read(\u0027/etc/NetworkManager/NetworkManager.conf\u0027)"},{"line_number":169,"context_line":"  p.set(\u0027main\u0027, \u0027rc-manager\u0027, \u0027unmanaged\u0027)"},{"line_number":170,"context_line":"  with open(\u0027/etc/NetworkManager/NetworkManager.conf\u0027, \u0027w\u0027) as fh:"},{"line_number":171,"context_line":"    p.write(fh)"},{"line_number":172,"context_line":"EOF"},{"line_number":173,"context_line":"fi"},{"line_number":174,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"8497ce61_531de1f4","line":171,"updated":"2022-11-24 22:19:58.000000000","message":"I\u0027m reading https://networkmanager.dev/docs/admins/ and it says to drop a config file into /etc/NetworkManager/conf.d ... which seems like a better idea than trying to modify this.\n\nThe option seems OK ... I feel a sense of deja vu about this, but it was all something to do with /etc/resolv.conf being a symlink.  I thought the idea was that if /etc/resolv.conf was a file basically nothing would touch it.  But reading the comment below about that (L223), I guess what I\u0027m tihnking about is systemd-resolved ...","commit_id":"e919a9b1171efe98aa4051700a63aa5318c63e75"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"600b4d0e2bd98f4097fef590658c9ec006d26560","unresolved":false,"context_lines":[{"line_number":168,"context_line":"  p.read(\u0027/etc/NetworkManager/NetworkManager.conf\u0027)"},{"line_number":169,"context_line":"  p.set(\u0027main\u0027, \u0027rc-manager\u0027, \u0027unmanaged\u0027)"},{"line_number":170,"context_line":"  with open(\u0027/etc/NetworkManager/NetworkManager.conf\u0027, \u0027w\u0027) as fh:"},{"line_number":171,"context_line":"    p.write(fh)"},{"line_number":172,"context_line":"EOF"},{"line_number":173,"context_line":"fi"},{"line_number":174,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"6a0cdd7d_403440a5","line":171,"in_reply_to":"8497ce61_531de1f4","updated":"2022-11-28 08:25:04.000000000","message":"getting a dedicated file seems OK - I\u0027ll still use the configparser to write it, since it\u0027s still an ini-file. I\u0027ll also ensure it\u0027s using the same name as the \"base-job\" patch, so that we\u0027re all good. *maybe* the base-job may also check for the existence of this file and, if present, not do anything, though at this point it\u0027s probably over-thinking.\n\nRegarding the option: \"unmanaged\" value means that, whatever the file is and its content, NM won\u0027t do anything. That\u0027s precisely what we want, since we want to get only one nameserver, pointing to 127.0.0.1. Other values may lead to unwanted behavior.","commit_id":"e919a9b1171efe98aa4051700a63aa5318c63e75"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a8cbd029c4fa7fda619ea4ec8822edd155221644","unresolved":false,"context_lines":[{"line_number":165,"context_line":"  cat \u003c\u003cEOF |python3"},{"line_number":166,"context_line":"  import configparser"},{"line_number":167,"context_line":"  p \u003d configparser.SafeConfigParser()"},{"line_number":168,"context_line":"  p.set(\u0027main\u0027, \u0027rc-manager\u0027, \u0027unmanaged\u0027)"},{"line_number":169,"context_line":"  with open(\u0027/etc/NetworkManager/conf.d/rc-manager.conf\u0027, \u0027w\u0027) as fh:"},{"line_number":170,"context_line":"    p.write(fh)"},{"line_number":171,"context_line":"EOF"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"d990abec_13b8bceb","line":168,"updated":"2022-11-28 16:56:52.000000000","message":"https://developer-old.gnome.org/NetworkManager/stable/NetworkManager.conf.html documents this setting. rc-manager apparently indicates resolv.conf management and unmanaged is what we want since we set our own value.","commit_id":"368bb77ee36d3bdae42cf77e57cfaa2718f383f4"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"2c18ed120d746b21750ac095157b353b6df66979","unresolved":false,"context_lines":[{"line_number":169,"context_line":"  with open(\u0027/etc/NetworkManager/conf.d/rc-manager.conf\u0027, \u0027w\u0027) as fh:"},{"line_number":170,"context_line":"    p.write(fh)"},{"line_number":171,"context_line":"EOF"},{"line_number":172,"context_line":"fi"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"# openSUSE doesn\u0027t have an iptables service, so apply the iptables rules at boot"},{"line_number":175,"context_line":"if [[ \"${DISTRO_NAME}\" \u003d~ (opensuse) ]] ; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7bde6934_6eeb8fef","line":172,"updated":"2022-11-28 13:38:21.000000000","message":"This is a great approach, I always forget about the possibility of inlining python within a shell script.","commit_id":"368bb77ee36d3bdae42cf77e57cfaa2718f383f4"}]}