)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"3df1ab760d7c8cdacec6b96cdd08eca08279a6bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d28b0c21_82075613","updated":"2023-03-07 23:05:06.000000000","message":"One small thing inline.","commit_id":"45a00c2f64acfe652f5b574607c7b93b9f2b280e"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"035f0a3c7b1558350b73262842da68e9ae48ff06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"964a426d_0ceec7ea","updated":"2023-03-09 22:15:31.000000000","message":"will montior.  none of these use booleans (AND v and tripped us up with all-projects).","commit_id":"dda3b6098ead3028379afb1ab1b0de9155726b70"}],"gerrit/acls/opendev/infra-specs.config":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0c2e892423d1b33dbcf2fa1562d943ece4879a76","unresolved":true,"context_lines":[{"line_number":30,"context_line":"[submit]"},{"line_number":31,"context_line":"mergeContent \u003d true"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[submit-requirement \"Code-Review\"]"},{"line_number":34,"context_line":"description \u003d Informational vote on current revision"},{"line_number":35,"context_line":"submittableIf \u003d is:true"}],"source_content_type":"text/x-ini","patch_set":4,"id":"b1504e50_6702ed69","line":33,"updated":"2023-03-06 17:19:55.000000000","message":"You have probably tested this but I want to make sure this isn\u0027t an issue.\n\nThe submit-requirement name value doesn\u0027t necessarily map to a label name restricting where it is valid right? Instead this requirement essentially says the change is always submittable unless something else prevents it (currently the rollcall vote). A better way to express this would be submittableIf codereview has any value?\n\nI\u0027m worried that as cargo culting happens people might infer this requirement only applies to code review votes when really it doesn\u0027t. I do think this is safe in this instance and I seem to recall you tested this. But worry about long term understanding.","commit_id":"593fa4f543bb47c1c13f8bf575fe557973ef619b"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"de2d3427774b9601b3f98009034499742ba90b4c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"[submit]"},{"line_number":31,"context_line":"mergeContent \u003d true"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[submit-requirement \"Code-Review\"]"},{"line_number":34,"context_line":"description \u003d Informational vote on current revision"},{"line_number":35,"context_line":"submittableIf \u003d is:true"}],"source_content_type":"text/x-ini","patch_set":4,"id":"ec2fe99e_2090d2a0","line":33,"in_reply_to":"4f9d0f23_b6a5d5a2","updated":"2023-03-07 22:48:22.000000000","message":"Note that in PS5 this is more formalised with the upstream merge rules.  So we need a matching submit-requirement, but it makes itself no-op with a combinatino of \"applicableIf \u003d is:false\" and \"submittableIf \u003d is:true\"","commit_id":"593fa4f543bb47c1c13f8bf575fe557973ef619b"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0d5dfed915230e9a2393a6a49acf1300d8c665bd","unresolved":true,"context_lines":[{"line_number":30,"context_line":"[submit]"},{"line_number":31,"context_line":"mergeContent \u003d true"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[submit-requirement \"Code-Review\"]"},{"line_number":34,"context_line":"description \u003d Informational vote on current revision"},{"line_number":35,"context_line":"submittableIf \u003d is:true"}],"source_content_type":"text/x-ini","patch_set":4,"id":"4f9d0f23_b6a5d5a2","line":33,"in_reply_to":"b1504e50_6702ed69","updated":"2023-03-06 17:28:56.000000000","message":"It occurred to me after posting the initial review that another way to break this perception may be to call this submit-requirement something like \"No-Requirement\". I think if we call it \"Code-Review\" we should have submittableIf rules that refer to Code-Review labels. Otherwise make it explicit that the two aren\u0027t directly tied to each other.","commit_id":"593fa4f543bb47c1c13f8bf575fe557973ef619b"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"3df1ab760d7c8cdacec6b96cdd08eca08279a6bb","unresolved":true,"context_lines":[{"line_number":31,"context_line":"mergeContent \u003d true"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[submit-requirement \"Code-Review\"]"},{"line_number":34,"context_line":"applicableIf \u003d is:false"},{"line_number":35,"context_line":"description \u003d Informational vote on current revision"},{"line_number":36,"context_line":"submittableIf \u003d is:true"}],"source_content_type":"text/x-ini","patch_set":5,"id":"9e3e51ce_eef70b0d","line":34,"updated":"2023-03-07 23:05:06.000000000","message":"For other reviewers this entry here essentially means this submit requirement does not apply to any changes in this project. But if this is how upstream wants to express a NoBlock in the future then I think it is a good idea to be in sync with that even if it is weird.","commit_id":"45a00c2f64acfe652f5b574607c7b93b9f2b280e"}],"gerrit/acls/openstack/governance.config":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"3df1ab760d7c8cdacec6b96cdd08eca08279a6bb","unresolved":true,"context_lines":[{"line_number":28,"context_line":"[label \"Rollcall-Vote\"]"},{"line_number":29,"context_line":"copyCondition \u003d changekind:TRIVIAL_REBASE"},{"line_number":30,"context_line":"defaultValue \u003d 0"},{"line_number":31,"context_line":"function \u003d NoOp"},{"line_number":32,"context_line":"value \u003d -1 No"},{"line_number":33,"context_line":"value \u003d 0 Abstain"},{"line_number":34,"context_line":"value \u003d +1 Yes"}],"source_content_type":"text/x-ini","patch_set":5,"id":"659c7819_07679b3e","line":31,"range":{"start_line":31,"start_character":11,"end_line":31,"end_character":15},"updated":"2023-03-07 23:05:06.000000000","message":"Missed a NoOp here.","commit_id":"45a00c2f64acfe652f5b574607c7b93b9f2b280e"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"de7a3b48787a8c8254b3a5110df32e5f3d6112f5","unresolved":false,"context_lines":[{"line_number":28,"context_line":"[label \"Rollcall-Vote\"]"},{"line_number":29,"context_line":"copyCondition \u003d changekind:TRIVIAL_REBASE"},{"line_number":30,"context_line":"defaultValue \u003d 0"},{"line_number":31,"context_line":"function \u003d NoOp"},{"line_number":32,"context_line":"value \u003d -1 No"},{"line_number":33,"context_line":"value \u003d 0 Abstain"},{"line_number":34,"context_line":"value \u003d +1 Yes"}],"source_content_type":"text/x-ini","patch_set":5,"id":"cfa0e214_5b051ba3","line":31,"range":{"start_line":31,"start_character":11,"end_line":31,"end_character":15},"in_reply_to":"659c7819_07679b3e","updated":"2023-03-07 23:13:07.000000000","message":"Done","commit_id":"45a00c2f64acfe652f5b574607c7b93b9f2b280e"}]}