)]}'
{"id":"openstack%2Fproject-config~875804","triplet_id":"openstack%2Fproject-config~master~Ic43f561174ebf30474b1b54be2bed02695cebedc","project":"openstack/project-config","branch":"master","topic":"gerrit-s-r-3.7","attention_set":{},"removed_from_attention_set":{"4146":{"account":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"last_update":"2023-03-07 23:14:58.000000000","reason":"\u003cGERRIT_ACCOUNT_4146\u003e replied on the change","reason_account":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"}},"7118":{"account":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"last_update":"2023-03-09 22:15:31.000000000","reason":"\u003cGERRIT_ACCOUNT_7118\u003e replied on the change","reason_account":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}}},"hashtags":[],"change_id":"Ic43f561174ebf30474b1b54be2bed02695cebedc","subject":"gerrit/acl : submit-requirements for deprecated NoOp function","status":"MERGED","created":"2023-03-01 05:16:12.000000000","updated":"2023-03-09 22:48:35.000000000","submitted":"2023-03-09 22:28:17.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":8,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"875804-gerrit-s-r-3.7","meta_rev_id":"cbd55c3e3b430369b1dcdbe636a868fb414aa54a","_number":875804,"virtual_id_number":875804,"owner":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-03-09 22:28:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"all":[{"value":2,"date":"2023-03-07 23:14:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2023-03-09 22:15:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-03-01 05:28:02.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-03-06 17:19:55.000000000","updated_by":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"reviewer":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"state":"CC"},{"updated":"2023-03-07 23:05:06.000000000","updated_by":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"reviewer":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"state":"REVIEWER"}],"messages":[{"id":"c9bdbf929e97c52ccfc9779de30fc6f0a8f2257a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2023-03-01 05:16:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3a0abf81de7c0865316646b0080e2d996b6eef15","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-01 05:28:02.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/e81d2f11cc454e59a3140e4b786b7fb8\n\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/6c3fb1d65cc5485baee91aba4ff85d53 : SUCCESS in 2m 49s\n- openstack-zuul-jobs-linters https://zuul.opendev.org/t/openstack/build/bb43251cec5142c3928981b75dc8d40b : SUCCESS in 6m 29s\n- project-config-gerrit https://zuul.opendev.org/t/openstack/build/1b63795b24104e78b13c0b96bfe9a52f : FAILURE in 2m 46s","accounts_in_message":[],"_revision_number":1},{"id":"2ec1f567e0cf50a6316e4cf7a01ebd2a32a9f6c9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2023-03-02 00:18:18.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"791cdaa9fd88661c9f205a2e095f2eaf4a3e87e7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-02 00:34:10.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/45b9fde001684414b5420a02caeb8afd\n\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/ac7481f2b22448b2866bac9d9d763721 : SUCCESS in 2m 54s\n- openstack-zuul-jobs-linters https://zuul.opendev.org/t/openstack/build/7bad30dd84ba47ad8cdab61e5f28ee47 : SUCCESS in 7m 01s\n- project-config-gerrit https://zuul.opendev.org/t/openstack/build/d22275a624514f9da773b7b6995a1226 : SUCCESS in 3m 26s","accounts_in_message":[],"_revision_number":2},{"id":"a296a397f1cf5515787cccbc0712c4455ca04748","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2023-03-02 05:48:20.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"af7afde47300535fcf5aca452cfa414f85948ede","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-02 05:56:25.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/11b8c04157cd4ddf86bd7f69d66feb7d\n\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/37496b80616e438abe22ef16fdd731a5 : SUCCESS in 2m 49s\n- openstack-zuul-jobs-linters https://zuul.opendev.org/t/openstack/build/d766762be1c142709414712407340eb9 : SUCCESS in 5m 03s\n- project-config-gerrit https://zuul.opendev.org/t/openstack/build/a04bd13c1364456a87c4ce84f863bb74 : SUCCESS in 3m 20s","accounts_in_message":[],"_revision_number":3},{"id":"9b583d4b556109a86f44a001054c51ac0dccdd36","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2023-03-03 02:59:55.000000000","message":"Topic copyCondition removed","accounts_in_message":[],"_revision_number":3},{"id":"ee89a4b7d16f6f6f0a111aee285181e9bda15fc6","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2023-03-03 02:59:57.000000000","message":"Topic set to gerrit-s-r-3.7","accounts_in_message":[],"_revision_number":3},{"id":"9c2573dcb9e700c73ac9f1af9c30f60e4840baa2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2023-03-03 03:42:01.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"653fee9cc050a38dc961ccbf44fc87481e0c9370","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-03 04:13:41.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/f01672f3f07e464f9a68d59c6dde720e\n\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/252455f91b284a4ba3e845335fc70d27 : SUCCESS in 4m 59s\n- openstack-zuul-jobs-linters https://zuul.opendev.org/t/openstack/build/e5095262661c44a08c3766daa6567631 : SUCCESS in 6m 29s\n- project-config-gerrit https://zuul.opendev.org/t/openstack/build/cb0bec0128664ef9b17e78165f772961 : SUCCESS in 4m 16s","accounts_in_message":[],"_revision_number":4},{"id":"0c2e892423d1b33dbcf2fa1562d943ece4879a76","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2023-03-06 17:19:55.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"0d5dfed915230e9a2393a6a49acf1300d8c665bd","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2023-03-06 17:28:56.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"690dfa7b9f306c9726f07a4262bf402a1ceafa05","tag":"autogenerated:gerrit:abandon","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2023-03-07 04:03:38.000000000","message":"Abandoned\n\nDecided against having s-r here","accounts_in_message":[],"_revision_number":4},{"id":"1eb004d6bdde4b8d1f41a9935a4ce8e99ff4de8c","tag":"autogenerated:gerrit:restore","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2023-03-07 22:20:56.000000000","message":"Restored","accounts_in_message":[],"_revision_number":4},{"id":"36d254931c3c048d86fee39c7bd79a8ced41d471","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2023-03-07 22:21:40.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"f7f5fd21bc3dbac45e44818cbf0ee7e29d4e71e0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-07 22:43:12.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/82f0a362c0b94196bd374c91d7f8471a\n\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/fe58eda1e3ca447a9726fe3205509823 : SUCCESS in 3m 09s\n- openstack-zuul-jobs-linters https://zuul.opendev.org/t/openstack/build/71a490ae9d5f4c16bfce6977d6954b9b : SUCCESS in 4m 56s\n- project-config-gerrit https://zuul.opendev.org/t/openstack/build/80981e1e07d04619a2de239669e67a21 : SUCCESS in 3m 08s","accounts_in_message":[],"_revision_number":5},{"id":"de2d3427774b9601b3f98009034499742ba90b4c","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2023-03-07 22:48:22.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"3df1ab760d7c8cdacec6b96cdd08eca08279a6bb","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2023-03-07 23:05:06.000000000","message":"Patch Set 5: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":5},{"id":"de7a3b48787a8c8254b3a5110df32e5f3d6112f5","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2023-03-07 23:13:07.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"5a0827b16ff9bec1e3a3d8ecec03391269fc810b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2023-03-07 23:13:16.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"e5f02e175141a93a466ff98ab2e88d32e97b90ce","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2023-03-07 23:14:58.000000000","message":"Patch Set 6: Code-Review+2","accounts_in_message":[],"_revision_number":6},{"id":"7ccceb788c4a9dedb60dce2c562703e0eb548ed7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-07 23:22:18.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/08c978565db845ec8fe2b42a038f4235\n\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/33481108a38547fab8297ff5971bd644 : SUCCESS in 2m 52s\n- openstack-zuul-jobs-linters https://zuul.opendev.org/t/openstack/build/4cd7324755d5478ebc593c4cedb77ad8 : SUCCESS in 6m 26s\n- project-config-gerrit https://zuul.opendev.org/t/openstack/build/f34dc5a024ea4484808376d5ff37e0f8 : SUCCESS in 3m 37s","accounts_in_message":[],"_revision_number":6},{"id":"035f0a3c7b1558350b73262842da68e9ae48ff06","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2023-03-09 22:15:31.000000000","message":"Patch Set 6: Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"25839e97f662d58a22da2039e8646362a4945157","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-09 22:15:55.000000000","message":"Patch Set 6: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":6},{"id":"b238680de433e8168e1d053244b013d7562455f7","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-09 22:28:17.000000000","message":"Patch Set 6: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c07ccf590fb64699b239d81ce7491cef\n\n- openstack-zuul-jobs-linters https://zuul.opendev.org/t/openstack/build/e139c98a15c74a1583907c6d9d3e3912 : SUCCESS in 5m 56s\n- project-config-gerrit https://zuul.opendev.org/t/openstack/build/125edf8c40ec4a02ad0192c19d1170c3 : SUCCESS in 3m 30s","accounts_in_message":[],"_revision_number":6},{"id":"3dff1d5d83976eccd98db7ad885544ffef6dcbcf","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-09 22:28:17.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":6},{"id":"cbd55c3e3b430369b1dcdbe636a868fb414aa54a","tag":"autogenerated:zuul:deploy","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-09 22:48:35.000000000","message":"Patch Set 6:\n\nBuild succeeded (deploy pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/b3e69e8f2bae47de8a06cac854727372\n\n- infra-prod-manage-projects https://zuul.opendev.org/t/openstack/build/7c40f7ecf8514e96ae1fb71f0e722aa2 : SUCCESS in 12m 51s","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"dda3b6098ead3028379afb1ab1b0de9155726b70","revisions":{"ce15f35e87af3dddbfb1f130b0f875eb2f22d1a3":{"kind":"REWORK","_number":1,"created":"2023-03-01 05:16:12.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/04/875804/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/04/875804/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/04/875804/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/04/875804/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/04/875804/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/04/875804/1"}}},"commit":{"parents":[{"commit":"6349f18d405642ec7cb113235b2b37035aeb14bf","subject":"gerrit/acl : remove deprecated copy conditions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/6349f18d405642ec7cb113235b2b37035aeb14bf"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2023-03-01 05:11:24.000000000","tz":660},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2023-03-01 05:11:24.000000000","tz":660},"subject":"gerrit/acl : remove deprecated NoOp function","message":"gerrit/acl : remove deprecated NoOp function\n\nThe submit functions are deprecated in Gerrit 3.7 and replaced with\nsubmit-requirements.\n\nThis starts at the replacement with the NoOp function.  Since these\nlabels should never block submitting we replace it with a\nsubmit-requirement of \"is:true\" which always passes.\n\nThis change itself should be a no-op.\n\nChange-Id: Ic43f561174ebf30474b1b54be2bed02695cebedc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/ce15f35e87af3dddbfb1f130b0f875eb2f22d1a3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/ce15f35e87af3dddbfb1f130b0f875eb2f22d1a3"}]},"branch":"refs/heads/master"},"fad60cc7ccd655b91326d4724ddebec65df7d3e3":{"kind":"REWORK","_number":2,"created":"2023-03-02 00:18:18.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/04/875804/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/04/875804/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/04/875804/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/04/875804/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/04/875804/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/04/875804/2"}}},"commit":{"parents":[{"commit":"4dd31aac469c7e271bb5d213749e13547cd3549a","subject":"acls : handle submit requirements in normalise tool","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/4dd31aac469c7e271bb5d213749e13547cd3549a"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2023-03-01 05:11:24.000000000","tz":660},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2023-03-01 22:26:18.000000000","tz":660},"subject":"gerrit/acl : remove deprecated NoOp function","message":"gerrit/acl : remove deprecated NoOp function\n\nThe submit functions are deprecated in Gerrit 3.7 and replaced with\nsubmit-requirements.\n\nThis starts at the replacement with the NoOp function.  Since these\nlabels should never block submitting we replace it with a\nsubmit-requirement of \"is:true\" which always passes.\n\nThis change itself should be a no-op.\n\nChange-Id: Ic43f561174ebf30474b1b54be2bed02695cebedc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/fad60cc7ccd655b91326d4724ddebec65df7d3e3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/fad60cc7ccd655b91326d4724ddebec65df7d3e3"}]},"branch":"refs/heads/master"},"111683726ed4661b268f7e27b4d32f849eda3569":{"kind":"REWORK","_number":3,"created":"2023-03-02 05:48:20.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/04/875804/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/04/875804/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/04/875804/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/04/875804/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/04/875804/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/04/875804/3"}}},"commit":{"parents":[{"commit":"4dd31aac469c7e271bb5d213749e13547cd3549a","subject":"acls : handle submit requirements in normalise tool","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/4dd31aac469c7e271bb5d213749e13547cd3549a"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2023-03-01 05:11:24.000000000","tz":660},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2023-03-02 04:13:45.000000000","tz":660},"subject":"gerrit/acl : submit-requirements for deprecated NoOp function","message":"gerrit/acl : submit-requirements for deprecated NoOp function\n\nThe submit functions are deprecated in Gerrit 3.7 and replaced with\nsubmit-requirements.\n\nThis starts at the replacement with ACL\u0027s currently using the NoOp\nfunction.  Labels currently must have a function associated with them,\nso the NoOp function is retained.\n\nHowever, to future-proof ourselves and to be consistent across all the\nACL files, we add an explicit submit-requirement for the label.  Since\nthese labels should never block submitting we use only a\nsubmit-requirement of \"is:true\" which always passes.\n\nThis change itself should be a no-op.\n\nChange-Id: Ic43f561174ebf30474b1b54be2bed02695cebedc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/111683726ed4661b268f7e27b4d32f849eda3569"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/111683726ed4661b268f7e27b4d32f849eda3569"}]},"branch":"refs/heads/master"},"593fa4f543bb47c1c13f8bf575fe557973ef619b":{"kind":"REWORK","_number":4,"created":"2023-03-03 03:42:01.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/04/875804/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/04/875804/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/04/875804/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/04/875804/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/04/875804/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/04/875804/4"}}},"commit":{"parents":[{"commit":"4dd31aac469c7e271bb5d213749e13547cd3549a","subject":"acls : handle submit requirements in normalise tool","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/4dd31aac469c7e271bb5d213749e13547cd3549a"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2023-03-01 05:11:24.000000000","tz":660},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2023-03-03 03:37:35.000000000","tz":660},"subject":"gerrit/acl : submit-requirements for deprecated NoOp function","message":"gerrit/acl : submit-requirements for deprecated NoOp function\n\nThe submit functions are deprecated in Gerrit 3.7 and replaced with\nsubmit-requirements.\n\nThis starts at the replacement with ACL\u0027s currently using the NoOp\nfunction.  Labels currently must have a function associated with them,\nso the NoOp function is retained.\n\nHowever, to future-proof ourselves and to be consistent across all the\nACL files, we add an explicit submit-requirement for the label.  Since\nthese labels should never block submitting we use only a\nsubmit-requirement of \"is:true\" which always passes.\n\nThis change itself should be a no-op.\n\nChange-Id: Ic43f561174ebf30474b1b54be2bed02695cebedc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/593fa4f543bb47c1c13f8bf575fe557973ef619b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/593fa4f543bb47c1c13f8bf575fe557973ef619b"}]},"branch":"refs/heads/master"},"45a00c2f64acfe652f5b574607c7b93b9f2b280e":{"kind":"REWORK","_number":5,"created":"2023-03-07 22:21:40.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/04/875804/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/04/875804/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/04/875804/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/04/875804/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/04/875804/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/04/875804/5"}}},"commit":{"parents":[{"commit":"f346b72eb66c80dd4762fb5f9db1c4292fff8233","subject":"gerrit/acl : handle submit requirements in normalise tool","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/f346b72eb66c80dd4762fb5f9db1c4292fff8233"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2023-03-01 05:11:24.000000000","tz":660},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2023-03-07 22:21:27.000000000","tz":660},"subject":"gerrit/acl : submit-requirements for deprecated NoOp function","message":"gerrit/acl : submit-requirements for deprecated NoOp function\n\nThe submit functions are deprecated in Gerrit 3.7 and replaced with\nsubmit-requirements.\n\nThis starts at the replacement with ACL\u0027s currently using the NoOp\nfunction.\n\nThis implements the migrations steps encded with [1] upstream.  The\nfunction is changed to NoBlock, and a \"non-applicable\"\nsubmit-requirement of \"applicableIf \u003d is:false\" and \"submittableIf \u003d\nis:true\" is added, with the same name as the label.\n\nSince we are matching the upstream rules for idempotence -- a\nsubmit-requirement with the same name as the label, we will avoid\nfuture upgrades modifying our ACL\u0027s and getting them out of sync with\nwhat we have in project-config.\n\nFrom a user\u0027s point-of-view, this change itself should be a no-op.\n\n[1] https://gerrit-review.googlesource.com/c/gerrit/+/339542\n\nChange-Id: Ic43f561174ebf30474b1b54be2bed02695cebedc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/45a00c2f64acfe652f5b574607c7b93b9f2b280e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/45a00c2f64acfe652f5b574607c7b93b9f2b280e"}]},"branch":"refs/heads/master"},"dda3b6098ead3028379afb1ab1b0de9155726b70":{"kind":"REWORK","_number":6,"created":"2023-03-07 23:13:16.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/04/875804/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/04/875804/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/04/875804/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/04/875804/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/04/875804/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/04/875804/6"}}},"commit":{"parents":[{"commit":"f346b72eb66c80dd4762fb5f9db1c4292fff8233","subject":"gerrit/acl : handle submit requirements in normalise tool","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/f346b72eb66c80dd4762fb5f9db1c4292fff8233"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2023-03-01 05:11:24.000000000","tz":660},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2023-03-07 23:12:17.000000000","tz":660},"subject":"gerrit/acl : submit-requirements for deprecated NoOp function","message":"gerrit/acl : submit-requirements for deprecated NoOp function\n\nThe submit functions are deprecated in Gerrit 3.7 and replaced with\nsubmit-requirements.\n\nThis starts at the replacement with ACL\u0027s currently using the NoOp\nfunction.\n\nThis implements the migrations steps encded with [1] upstream.  The\nfunction is changed to NoBlock, and a \"non-applicable\"\nsubmit-requirement of \"applicableIf \u003d is:false\" and \"submittableIf \u003d\nis:true\" is added, with the same name as the label.\n\nSince we are matching the upstream rules for idempotence -- a\nsubmit-requirement with the same name as the label, we will avoid\nfuture upgrades modifying our ACL\u0027s and getting them out of sync with\nwhat we have in project-config.\n\nFrom a user\u0027s point-of-view, this change itself should be a no-op.\n\n[1] https://gerrit-review.googlesource.com/c/gerrit/+/339542\n\nChange-Id: Ic43f561174ebf30474b1b54be2bed02695cebedc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/dda3b6098ead3028379afb1ab1b0de9155726b70"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/dda3b6098ead3028379afb1ab1b0de9155726b70"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}