)]}'
{"id":"openstack%2Fproject-config~875997","triplet_id":"openstack%2Fproject-config~master~I971f626bd7dbee012dc93a5807145d206b645cfd","project":"openstack/project-config","branch":"master","topic":"copyCondition","attention_set":{},"removed_from_attention_set":{"7118":{"account":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"last_update":"2023-03-21 00:08:59.000000000","reason":"Change was submitted"},"5263":{"account":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"last_update":"2023-03-20 23:51:33.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I971f626bd7dbee012dc93a5807145d206b645cfd","subject":"gerrit/acl : check for function/s-r in normalize","status":"MERGED","created":"2023-03-02 00:18:18.000000000","updated":"2023-03-21 00:08:59.000000000","submitted":"2023-03-21 00:08:59.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"875997-copyCondition","meta_rev_id":"573466bc6cbf3cd7fec359b7f6878a292d6e7017","_number":875997,"virtual_id_number":875997,"owner":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-03-21 00:08:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"all":[{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":2,"date":"2023-03-20 23:51:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"all":[{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":1,"date":"2023-03-20 23:51:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-03-02 00:30:32.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-03-06 17:25:20.000000000","updated_by":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"reviewer":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"state":"CC"},{"updated":"2023-03-16 18:09:15.000000000","updated_by":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"reviewer":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"state":"REVIEWER"},{"updated":"2023-03-20 23:45:12.000000000","updated_by":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"reviewer":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"state":"CC"},{"updated":"2023-03-20 23:51:33.000000000","updated_by":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"reviewer":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"state":"REVIEWER"}],"messages":[{"id":"c650d9ff50b41fa1c64c3318dfebd69e6514601b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2023-03-02 00:18:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7c203f8ad00b26e1914b3185eb9bd4a11f5415bf","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-02 00:30:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/64c8476610f24df58d275f02e82f31df\n\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/c392c7398d394916b3554ea7c48ffe36 : SUCCESS in 3m 13s\n- openstack-zuul-jobs-linters https://zuul.opendev.org/t/openstack/build/d5bd703764e0484aa67919e774da53a5 : SUCCESS in 6m 28s","accounts_in_message":[],"_revision_number":1},{"id":"956bee37df47bc2e889fabbc8a05f50d5d97bec0","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2023-03-05 23:04:36.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"404de50c4e1068ce3176008f59e9e8c15a5a798c","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2023-03-06 17:25:20.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ce77014661e42a6ed3af729041cb648f0c68c517","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2023-03-16 01:58:55.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"824ddf1ac7bf4743e0fd96f5dd57b2bf1caf6c3b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-16 02:09:37.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/89b845ea41584efb9b2adff655a35c84\n\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/3224019326944a299b08e626cd4747d5 : SUCCESS in 3m 55s\n- openstack-zuul-jobs-linters https://zuul.opendev.org/t/openstack/build/326f694e2df240b4be029ecbf851290b : SUCCESS in 6m 32s","accounts_in_message":[],"_revision_number":2},{"id":"3df135f93f4612b7e1ce4a9ee39f17034ffc6527","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2023-03-16 02:38:11.000000000","message":"Uploaded patch set 3: New patch set was added with same tree, parent tree, and commit message as Patch Set 2.","accounts_in_message":[],"_revision_number":3},{"id":"fd5b7a9ef8afa68f16360ba2e81dcd1a406e82a0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-16 02:47:27.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/2a12371c57f744f6ae149816a74ea20b\n\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/49d40d19a9b54518b01a1ef8cc40e470 : SUCCESS in 2m 40s\n- openstack-zuul-jobs-linters https://zuul.opendev.org/t/openstack/build/bc76e394db2c429ab93a3e4edfe8c0a1 : SUCCESS in 6m 34s","accounts_in_message":[],"_revision_number":3},{"id":"744eb2370bdb0c4c92b3d88391e3c49acb2bff40","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2023-03-16 18:09:15.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"ae88ac9c4d559f4b020b1e6056b5d9151d685ffc","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2023-03-20 23:45:12.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"7ab8f534b1e3c5954a2694cb4efa2ec7b2f2ace1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2023-03-20 23:49:56.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"f4ef3a100432f90aa78c518b7b73c22e5d930485","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2023-03-20 23:50:14.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"f2f055cccc179d9dff5c594e5626449399fc329e","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2023-03-20 23:51:33.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"c4ebf1daeebaba307518f95e1208a1a83f490f60","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-20 23:57:27.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/73cb29e6ffe74d17b3ffb1a54a2a85c9\n\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/0d90f6fcdc63462ca0ed66076e2c4a3f : SUCCESS in 3m 32s\n- openstack-zuul-jobs-linters https://zuul.opendev.org/t/openstack/build/1b60de44638f429e9ede2b1cc1fc4493 : SUCCESS in 6m 03s","accounts_in_message":[],"_revision_number":4},{"id":"4d14d40da4d5629fb9764e64871bf5957b925ce6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-20 23:57:46.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"1001ce104d20920d45639e6f8a3798ab3e6aec9a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-21 00:08:58.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1ed86c8311f14f4aa042567798ded0d8\n\n- openstack-zuul-jobs-linters https://zuul.opendev.org/t/openstack/build/85364de9d20c43e7b80afcd4e12ea1b2 : SUCCESS in 6m 25s","accounts_in_message":[],"_revision_number":4},{"id":"573466bc6cbf3cd7fec359b7f6878a292d6e7017","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-21 00:08:59.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"a172d416d990a7cae7938050a683127c0c0adc35","revisions":{"1daab134434824a4f553b72dada077c1a8f338d9":{"kind":"REWORK","_number":1,"created":"2023-03-02 00:18:18.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/97/875997/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/97/875997/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/97/875997/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/97/875997/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/97/875997/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/97/875997/1"}}},"commit":{"parents":[{"commit":"411fef7c2932334a27c6f71a164b6f338c079220","subject":"gerrit/acl : Convert remaining AnyWithBlock to submit requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/411fef7c2932334a27c6f71a164b6f338c079220"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2023-03-02 00:17:23.000000000","tz":660},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2023-03-02 00:17:23.000000000","tz":660},"subject":"gerrit/acl : disallow \"function\"","message":"gerrit/acl : disallow \"function\"\n\nThis has been deprecated and is replaced with submit-requirements.  We\nshouldn\u0027t need this in our ACL files any more.\n\nChange-Id: I971f626bd7dbee012dc93a5807145d206b645cfd\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/1daab134434824a4f553b72dada077c1a8f338d9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/1daab134434824a4f553b72dada077c1a8f338d9"}]},"branch":"refs/heads/master"},"d400bbf5475e7caa6a015b69fd454bb042ae124e":{"kind":"REWORK","_number":2,"created":"2023-03-16 01:58:55.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/97/875997/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/97/875997/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/97/875997/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/97/875997/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/97/875997/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/97/875997/2"}}},"commit":{"parents":[{"commit":"ab7f4a2c6b15e503b4961e59e3360c823357859c","subject":"gerrit/acls : fix some missed NoOp functions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/ab7f4a2c6b15e503b4961e59e3360c823357859c"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2023-03-02 00:17:23.000000000","tz":660},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2023-03-16 01:58:32.000000000","tz":660},"subject":"gerrit/acl : check for function/s-r in normalize","message":"gerrit/acl : check for function/s-r in normalize\n\nThis ensures that labels only use \"function \u003d NoBlock\" and that every\nlabel has a corresponding submit-requirement section.\n\nWe don\u0027t really have unit tests for this, but the first check actually\nfound some missed functions in\nI557f3615d15eca899a262b0989986fb2754ac870.  I manually tested the\nsecond by removing some submit-requirements, and it correctly failed.\n\nChange-Id: I971f626bd7dbee012dc93a5807145d206b645cfd\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/d400bbf5475e7caa6a015b69fd454bb042ae124e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/d400bbf5475e7caa6a015b69fd454bb042ae124e"}]},"branch":"refs/heads/master"},"548f7beba41dc4c5feebaf6ee50cbadc128376c8":{"kind":"NO_CHANGE","_number":3,"created":"2023-03-16 02:38:11.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/97/875997/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/97/875997/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/97/875997/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/97/875997/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/97/875997/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/97/875997/3"}}},"commit":{"parents":[{"commit":"2182282f60f04f12c625beb2e9d46b0abd13c5fa","subject":"gerrit/acl : fix some missed NoOp functions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/2182282f60f04f12c625beb2e9d46b0abd13c5fa"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2023-03-02 00:17:23.000000000","tz":660},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2023-03-16 02:37:50.000000000","tz":660},"subject":"gerrit/acl : check for function/s-r in normalize","message":"gerrit/acl : check for function/s-r in normalize\n\nThis ensures that labels only use \"function \u003d NoBlock\" and that every\nlabel has a corresponding submit-requirement section.\n\nWe don\u0027t really have unit tests for this, but the first check actually\nfound some missed functions in\nI557f3615d15eca899a262b0989986fb2754ac870.  I manually tested the\nsecond by removing some submit-requirements, and it correctly failed.\n\nChange-Id: I971f626bd7dbee012dc93a5807145d206b645cfd\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/548f7beba41dc4c5feebaf6ee50cbadc128376c8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/548f7beba41dc4c5feebaf6ee50cbadc128376c8"}]},"branch":"refs/heads/master"},"a172d416d990a7cae7938050a683127c0c0adc35":{"kind":"REWORK","_number":4,"created":"2023-03-20 23:49:56.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/97/875997/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/97/875997/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/97/875997/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/97/875997/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/97/875997/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/97/875997/4"}}},"commit":{"parents":[{"commit":"2182282f60f04f12c625beb2e9d46b0abd13c5fa","subject":"gerrit/acl : fix some missed NoOp functions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/2182282f60f04f12c625beb2e9d46b0abd13c5fa"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2023-03-02 00:17:23.000000000","tz":660},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2023-03-20 23:49:19.000000000","tz":660},"subject":"gerrit/acl : check for function/s-r in normalize","message":"gerrit/acl : check for function/s-r in normalize\n\nThis ensures that labels only use \"function \u003d NoBlock\" and that every\nlabel has a corresponding submit-requirement section.\n\nWe don\u0027t really have unit tests for this, but the first check actually\nfound some missed functions in\nI557f3615d15eca899a262b0989986fb2754ac870.  I manually tested the\nsecond by removing some submit-requirements, and it correctly failed.\n\nChange-Id: I971f626bd7dbee012dc93a5807145d206b645cfd\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/a172d416d990a7cae7938050a683127c0c0adc35"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/a172d416d990a7cae7938050a683127c0c0adc35"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}