)]}'
{"id":"openstack%2Fproject-config~877721","triplet_id":"openstack%2Fproject-config~master~Idba8dcd1b1ee3a0865e785e220eef22f8c8f213d","project":"openstack/project-config","branch":"master","topic":"copyCondition","attention_set":{},"removed_from_attention_set":{"7118":{"account":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"last_update":"2023-05-01 03:33:21.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"Idba8dcd1b1ee3a0865e785e220eef22f8c8f213d","subject":"openstack/release : return to non-blocking submit rule","status":"ABANDONED","created":"2023-03-16 22:44:20.000000000","updated":"2023-05-01 03:33:21.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"762d2f86a2de2f6cb33a613f341701a8dca6dbfd","_number":877721,"virtual_id_number":877721,"owner":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"tag":"autogenerated:zuul:check","value":1,"date":"2023-03-20 23:56:14.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"all":[{"value":2,"date":"2023-03-20 23:49:56.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-03-16 22:55:53.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-03-16 23:04:03.000000000","updated_by":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"reviewer":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"state":"REVIEWER"},{"updated":"2023-04-03 17:09:29.000000000","updated_by":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"reviewer":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"state":"CC"},{"updated":"2023-04-13 07:09:11.000000000","updated_by":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"reviewer":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"state":"CC"}],"messages":[{"id":"ae998690afc4001718bd8087bc92c21413b3af94","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2023-03-16 22:44:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"37a9c01eeb20d8f8465b06065d5d0fa7a1d3f030","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-16 22:55:53.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/0c86607466aa408ea072133b47dbe9ac\n\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/e6de2944164f420c992504a1e07c984a : SUCCESS in 3m 07s\n- openstack-zuul-jobs-linters https://zuul.opendev.org/t/openstack/build/d3a3cf3c7bc743e2aada14e188a9f1de : SUCCESS in 6m 23s\n- project-config-gerrit https://zuul.opendev.org/t/openstack/build/c7e9aa60a0ad4c7b88a3e4a3b1f83287 : SUCCESS in 3m 43s","accounts_in_message":[],"_revision_number":1},{"id":"c4ca93a77484e2586dcd83c66d8e58635f0bc589","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2023-03-16 23:04:03.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"04e87491e4d8a4f9de875a57448b32bfc6e21834","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2023-03-20 23:49:56.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"f06ab0be2dc4deae9cffcfc1103bcdc755a5ef66","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-20 23:56:14.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/471e025313f64ebf872b17f2d5596baa\n\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/e78114213e824fd9a1d2c63af0fe01d5 : SUCCESS in 2m 30s\n- openstack-zuul-jobs-linters https://zuul.opendev.org/t/openstack/build/ffa7142e5b064935ac5b09aad532fb23 : SUCCESS in 4m 43s\n- project-config-gerrit https://zuul.opendev.org/t/openstack/build/babb62128c144bb5b94f896f0fd37909 : SUCCESS in 3m 04s","accounts_in_message":[],"_revision_number":2},{"id":"775e81b9048c01a28d3251186100cc99d5914df5","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2023-04-03 17:09:29.000000000","message":"Patch Set 2:\n\nExperimenting with I9d99ba7edb996e871e8bc8d2cc1c3db0197a4b9e instead, to get the column back onto the changes list with relevant satisfaction indicator.","accounts_in_message":[],"_revision_number":2},{"id":"a8bec681eb71d96e6067ba733e5a73eb17b898cd","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2023-04-13 07:09:11.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"762d2f86a2de2f6cb33a613f341701a8dca6dbfd","tag":"autogenerated:gerrit:abandon","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2023-05-01 03:33:21.000000000","message":"Abandoned\n\nI think this has been addressed recently when we found \u003eMIN doens\u0027t work","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"0155ec8bea83d0fdd62b2a5e7970e3a94cd655db","revisions":{"c056641f63e2e508182c75415cf5e9337f9bace5":{"kind":"REWORK","_number":1,"created":"2023-03-16 22:44:20.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/21/877721/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/21/877721/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/21/877721/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/21/877721/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/21/877721/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/21/877721/1"}}},"commit":{"parents":[{"commit":"309cdfe240729faf8e3ce73dcea8297c3132d7bd","subject":"gerrit/acl : check for capital booleans in normalize","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/309cdfe240729faf8e3ce73dcea8297c3132d7bd"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2023-03-16 22:24:04.000000000","tz":660},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2023-03-16 22:24:04.000000000","tz":660},"subject":"openstack/release : return to non-blocking submit rule","message":"openstack/release : return to non-blocking submit rule\n\nThe PTL-Approval vote is added by Zuul, which looks at who has voted\nand compares it to the PTL lists, and marks it with +1 if the project\nPTL has seen it.\n\nIt doesn\u0027t really have a -1 state; this was added with\nIdbf614be4b88db56258ed3b0e7725b581196a6fb to try and get the column to\nappear.\n\nAs discussed in [1] I don\u0027t believe this is the cause of the missing\ncolumn.  Basically the column will only show up if there is a\n*blocking* vote -- the assumption is I guess that if the change\ndoesn\u0027t have something stopping it merging, then it\u0027s not really\nrelevant for the overview.\n\nThis is a regression from 3.5 -- there *any* vote would make the\ncolumn appear.\n\nI think the thread [1] explains it -- to be frank I\u0027m not sure we have\na good answer.  The UI is very focused around this idea of\nblocking/non-blocking votes, rather than \"informational\" things like\nPTL-Approval.\n\nBut with this now being a submit-requirement of !\u003d-1, the UI is even\n*more* confusing because the PTL-Approval label *always* looks like it\nis valid.  Since 0/+1 are both satisfying the sr, it gets a green\ncircle tick on the overview page.  I think that by removing this, we\nat least won\u0027t show that in the UI, even though the original problem\nisn\u0027t really solved.\n\n[1] https://groups.google.com/g/repo-discuss/c/gYVD-iBR9Ow/m/p_i5L4_vAQAJ\n\nChange-Id: Idba8dcd1b1ee3a0865e785e220eef22f8c8f213d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/c056641f63e2e508182c75415cf5e9337f9bace5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/c056641f63e2e508182c75415cf5e9337f9bace5"}]},"branch":"refs/heads/master"},"0155ec8bea83d0fdd62b2a5e7970e3a94cd655db":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2023-03-20 23:49:56.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/21/877721/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/21/877721/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/21/877721/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/21/877721/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/21/877721/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/21/877721/2"}}},"commit":{"parents":[{"commit":"b0963776f16d1cc0be86e445b1ab29e497dd0216","subject":"gerrit/acl : check for capital booleans in normalize","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/b0963776f16d1cc0be86e445b1ab29e497dd0216"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2023-03-16 22:24:04.000000000","tz":660},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2023-03-20 23:49:23.000000000","tz":660},"subject":"openstack/release : return to non-blocking submit rule","message":"openstack/release : return to non-blocking submit rule\n\nThe PTL-Approval vote is added by Zuul, which looks at who has voted\nand compares it to the PTL lists, and marks it with +1 if the project\nPTL has seen it.\n\nIt doesn\u0027t really have a -1 state; this was added with\nIdbf614be4b88db56258ed3b0e7725b581196a6fb to try and get the column to\nappear.\n\nAs discussed in [1] I don\u0027t believe this is the cause of the missing\ncolumn.  Basically the column will only show up if there is a\n*blocking* vote -- the assumption is I guess that if the change\ndoesn\u0027t have something stopping it merging, then it\u0027s not really\nrelevant for the overview.\n\nThis is a regression from 3.5 -- there *any* vote would make the\ncolumn appear.\n\nI think the thread [1] explains it -- to be frank I\u0027m not sure we have\na good answer.  The UI is very focused around this idea of\nblocking/non-blocking votes, rather than \"informational\" things like\nPTL-Approval.\n\nBut with this now being a submit-requirement of !\u003d-1, the UI is even\n*more* confusing because the PTL-Approval label *always* looks like it\nis valid.  Since 0/+1 are both satisfying the sr, it gets a green\ncircle tick on the overview page.  I think that by removing this, we\nat least won\u0027t show that in the UI, even though the original problem\nisn\u0027t really solved.\n\n[1] https://groups.google.com/g/repo-discuss/c/gYVD-iBR9Ow/m/p_i5L4_vAQAJ\n\nChange-Id: Idba8dcd1b1ee3a0865e785e220eef22f8c8f213d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/0155ec8bea83d0fdd62b2a5e7970e3a94cd655db"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/0155ec8bea83d0fdd62b2a5e7970e3a94cd655db"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}