)]}'
{"zuul.d/pipelines.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b3a5d014d36f857a0758b47b977d63b69491f5a6","unresolved":true,"context_lines":[{"line_number":275,"context_line":"        - event: comment-added"},{"line_number":276,"context_line":"          username:"},{"line_number":277,"context_line":"            regex: ^zuul$"},{"line_number":278,"context_line":"            negate: true"},{"line_number":279,"context_line":"    success:"},{"line_number":280,"context_line":"      gerrit:"},{"line_number":281,"context_line":"        PTL-Approved: 1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8ece738a_a6dbe88f","line":278,"updated":"2023-09-05 07:14:13.000000000","message":"Note that this is an incomplete transformation of the original regex. I\u0027m not sure whether the \"\\S+\" is to guard against whitespace in names, empty names or both. A complete regex might be\n\nregex: ^(zuul|.*\\s.*|)$\n\nbut do we really need that? I think the only thing this is meant to guard against is that the comment which zuul adds after this pipeline finishes triggers another pipeline run, right?\n\nAlso I\u0027m not sure if the original regex is valid at all with the two ^ anchors.","commit_id":"7ee4aab6c653a93c828e009a65d77abd6675495d"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"ca980838dee96803da92b0759c383cb2b1c80d9e","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        - event: comment-added"},{"line_number":276,"context_line":"          username:"},{"line_number":277,"context_line":"            regex: ^zuul$"},{"line_number":278,"context_line":"            negate: true"},{"line_number":279,"context_line":"    success:"},{"line_number":280,"context_line":"      gerrit:"},{"line_number":281,"context_line":"        PTL-Approved: 1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"54dd6174_6bb2f81c","line":278,"updated":"2023-09-05 13:30:07.000000000","message":"Yes, \\S is the inverse of \\s in PCRE, so it looks like the pattern is intended to match a string consisting only of one or more non-whitespace characters which is not the sequence \"zuul\" so did in theory not match zero-length usernames and usernames with one or more whitespace characters in them. I agree it\u0027s probably unnecessary caution, though it may not hurt to check git history and see when the \\S was introduced, then check discussion around it (keeping in mind that the pattern may have been copied from another repo where the need for \\S got discussed earlier).","commit_id":"7ee4aab6c653a93c828e009a65d77abd6675495d"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"96c204bc30ddb0f6b68c77bb3f4462962769c45f","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        - event: comment-added"},{"line_number":276,"context_line":"          username:"},{"line_number":277,"context_line":"            regex: ^zuul$"},{"line_number":278,"context_line":"            negate: true"},{"line_number":279,"context_line":"    success:"},{"line_number":280,"context_line":"      gerrit:"},{"line_number":281,"context_line":"        PTL-Approved: 1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e775a5bb_75364cd2","line":278,"updated":"2023-09-05 13:28:18.000000000","message":"Yes, \\S is the inverse of \\s in PCRE, so it looks like the pattern is intended to match a string consisting only of one or more non-whitespace characters which is not the sequence \"zuul\" so did in theory not match zero-length usernames and usernames with one or more whitespace characters in them. I agree it\u0027s probably unnecessary caution, though it may not hurt to check git history and see when the \\S was introduced, then check discussion around it (keeping in mind that the pattern may have been copied from another repo where the need for \\S got discussed earlier).","commit_id":"7ee4aab6c653a93c828e009a65d77abd6675495d"}],"zuul.d/projects.yaml":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"ca980838dee96803da92b0759c383cb2b1c80d9e","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        - noop:"},{"line_number":121,"context_line":"            branches: master"},{"line_number":122,"context_line":"        - openafs-deb-package-build:"},{"line_number":123,"context_line":"            branches:"},{"line_number":124,"context_line":"              regex: ^master$"},{"line_number":125,"context_line":"              negate: true"},{"line_number":126,"context_line":"    gate:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"78f4a464_9f987cf1","line":123,"updated":"2023-09-05 13:30:07.000000000","message":"I think the original rejected any branches starting with \"master\" even if they had extra characters after them, but it was likely out of convenience in an attempt not to over-complicate the regex.","commit_id":"7ee4aab6c653a93c828e009a65d77abd6675495d"}]}