)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"da0f7c26afbdc2893eaf06177e37cadd180d10f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5c7482bf_1e4dc098","updated":"2024-02-29 15:53:30.000000000","message":"Glance currently has a non-core PTL.  It would be good for her to be able to do administrative activities on patches, like setting review priority, abandoning reviews, -2 on reviews that don\u0027t fit in with glance project plans, and -W in case something slips through.\n\nThe glance-ptl group has existed for a while now; it\u0027s been primarily used by glance-specs, where the PTL is the only person who can approve a spec.","commit_id":"dff31830f07da4b5affc40cd1dafd370f956b487"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"89f549479a1ba7210b207b64a2f62b1f09cac694","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0e90bf28_40eee848","updated":"2024-02-29 16:19:39.000000000","message":"maybe I\u0027m misled by the name but what is this group good for? shouldn\u0027t a PTL always have core powers by virtue of their position?","commit_id":"dff31830f07da4b5affc40cd1dafd370f956b487"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a5bcbdb639ce00d1597f21cb427408807a3e807b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f51c1cd7_3de6fb76","in_reply_to":"5c7482bf_1e4dc098","updated":"2024-02-29 16:22:09.000000000","message":"oh, I somehow missed this comment. I\u0027m fine with using that group for specs tasks, I still think a ptl should be added as core rather than having this complicated acl setup","commit_id":"dff31830f07da4b5affc40cd1dafd370f956b487"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4f1f26a85ee85e0fd784ab59ef6ad75bdda6b6f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e119cde7_683f7e96","updated":"2024-02-29 20:26:53.000000000","message":"@fungi: thanks for the normalization tip!\n\n@frickler: possibly, but I\u0027m not proposing this as a general model.  It just happens that the running-a-project skillset and the code-review-and-approval skillset don\u0027t always overlap, and just as you don\u0027t want to have an antisocial but excellent software engineer run a project, sometimes you have someone who can keep the project running smoothly but hasn\u0027tm yet developed the reviewing chops.","commit_id":"25bf7cc54de5d2846cb58301af98f6f39e791851"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"48590d7dc6cad37b64b759c54fd7028c6f45cfe6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"56eec3d3_94de4e70","updated":"2024-03-07 14:15:24.000000000","message":"I\u0027m going to +1 my own patch, but in my capacity as a glance core.","commit_id":"25bf7cc54de5d2846cb58301af98f6f39e791851"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"de4dbb0afc9d8d592ed67efbb549014a77b97a0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"30d2a4fc_0cedd928","updated":"2024-03-07 06:20:23.000000000","message":"I\u0027m still not convinced that this complicated setup is a good idea, but I also won\u0027t block it. It should however get ptl approval before getting merged.\n\nFor the record, as infra-root I would always act on a PTL request to add them to a relevant core group or to force-merge a change, so the only added protection that this gives would be against them accidentally submitting a stronger vote than they intended to","commit_id":"25bf7cc54de5d2846cb58301af98f6f39e791851"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"593341b9a8117ecbae705baa5802bba20ef166ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8bd053cd_6d9ea65e","updated":"2024-04-30 17:56:20.000000000","message":"Looks good to me.\n\nI asked a few questions which could be handled in a followup if needed.  I\u0027m holding off the +A until we get a +1 from the current PTL","commit_id":"25bf7cc54de5d2846cb58301af98f6f39e791851"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1c43d91aa5bc909144d269c8c3b7b127fec2ead0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"efddabce_d2dfc9f2","updated":"2024-05-15 13:39:49.000000000","message":"New PS up in a few minutes.","commit_id":"25bf7cc54de5d2846cb58301af98f6f39e791851"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"25f0663a4f34256e9864344d95df15f72069e6b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4197f0e8_19cf0565","updated":"2024-05-15 06:16:40.000000000","message":"Thanks!","commit_id":"25bf7cc54de5d2846cb58301af98f6f39e791851"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"1b5d9e9edd86649b3e4321747302d9786893d733","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a4f0f5cd_1449ae4d","updated":"2024-05-15 14:12:13.000000000","message":"Thanks Brian","commit_id":"389d7a4800ea2e6e0e24957881d0691ce9be62b4"}],"gerrit/acls/openstack/glance-specs.config":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"593341b9a8117ecbae705baa5802bba20ef166ad","unresolved":true,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[access \"refs/heads/*\"]"},{"line_number":5,"context_line":"\tabandon \u003d group glance-core"},{"line_number":6,"context_line":"\tlabel-Code-Review \u003d -2..0 group glance-ptl"},{"line_number":7,"context_line":"\tlabel-Code-Review \u003d -2..+2 group glance-core"},{"line_number":8,"context_line":"\tlabel-Workflow \u003d -1..+1 group glance-ptl"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-ini","patch_set":2,"id":"af3f2928_49c9fb81","line":6,"updated":"2024-04-30 17:56:20.000000000","message":"Do you want to give the PTL abandon here also?","commit_id":"25bf7cc54de5d2846cb58301af98f6f39e791851"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"5ea67d4b4157ff7373103bd8ced894b2ced04e0d","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[access \"refs/heads/*\"]"},{"line_number":5,"context_line":"\tabandon \u003d group glance-core"},{"line_number":6,"context_line":"\tlabel-Code-Review \u003d -2..0 group glance-ptl"},{"line_number":7,"context_line":"\tlabel-Code-Review \u003d -2..+2 group glance-core"},{"line_number":8,"context_line":"\tlabel-Workflow \u003d -1..+1 group glance-ptl"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-ini","patch_set":2,"id":"b741c0db_bfa9d3d1","line":6,"in_reply_to":"af3f2928_49c9fb81","updated":"2024-05-15 13:34:03.000000000","message":"The commit message seems to imply it\u0027s desired, so yes this is likely an oversight.","commit_id":"25bf7cc54de5d2846cb58301af98f6f39e791851"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1c43d91aa5bc909144d269c8c3b7b127fec2ead0","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[access \"refs/heads/*\"]"},{"line_number":5,"context_line":"\tabandon \u003d group glance-core"},{"line_number":6,"context_line":"\tlabel-Code-Review \u003d -2..0 group glance-ptl"},{"line_number":7,"context_line":"\tlabel-Code-Review \u003d -2..+2 group glance-core"},{"line_number":8,"context_line":"\tlabel-Workflow \u003d -1..+1 group glance-ptl"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-ini","patch_set":2,"id":"86579175_f2804379","line":6,"in_reply_to":"b741c0db_bfa9d3d1","updated":"2024-05-15 13:39:49.000000000","message":"Yep, it\u0027s an oversight.  Thanks for catching this!","commit_id":"25bf7cc54de5d2846cb58301af98f6f39e791851"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"93849484b4339c34c91b62c5e60aa92524c88114","unresolved":true,"context_lines":[{"line_number":4,"context_line":"[access \"refs/heads/*\"]"},{"line_number":5,"context_line":"\tabandon \u003d group glance-core"},{"line_number":6,"context_line":"\tabandon \u003d group glance-ptl"},{"line_number":7,"context_line":"\tlabel-Code-Review \u003d -2..+1 group glance-ptl"},{"line_number":8,"context_line":"\tlabel-Code-Review \u003d -2..+2 group glance-core"},{"line_number":9,"context_line":"\tlabel-Workflow \u003d -1..+1 group glance-ptl"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-ini","patch_set":3,"id":"8016da1a_3b68f8b0","line":7,"range":{"start_line":7,"start_character":25,"end_line":7,"end_character":27},"updated":"2024-05-15 13:49:05.000000000","message":"I had this at 0 on the previous patch sets, figuring that the PTL would have +1 code review powers in their capacity as a normal openstack contributor, but I think it\u0027s worth making it explicit (and consistent with the other glance acl files).","commit_id":"389d7a4800ea2e6e0e24957881d0691ce9be62b4"}],"gerrit/acls/openstack/glance.config":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"593341b9a8117ecbae705baa5802bba20ef166ad","unresolved":true,"context_lines":[{"line_number":5,"context_line":"\tabandon \u003d group glance-core"},{"line_number":6,"context_line":"\tabandon \u003d group glance-ptl"},{"line_number":7,"context_line":"\tabandon \u003d group glance-reviewbot"},{"line_number":8,"context_line":"\tlabel-Code-Review \u003d -2..+1 group glance-ptl"},{"line_number":9,"context_line":"\tlabel-Code-Review \u003d -2..+2 group glance-core"},{"line_number":10,"context_line":"\tlabel-Review-Priority \u003d -1..+2 group glance-core"},{"line_number":11,"context_line":"\tlabel-Review-Priority \u003d -1..+2 group glance-ptl"}],"source_content_type":"text/x-ini","patch_set":2,"id":"8fe9320c_b63bb8aa","line":8,"range":{"start_line":8,"start_character":24,"end_line":8,"end_character":28},"updated":"2024-04-30 17:56:20.000000000","message":"I\u0027m assuming this is deliberate but why only +1?","commit_id":"25bf7cc54de5d2846cb58301af98f6f39e791851"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"5ea67d4b4157ff7373103bd8ced894b2ced04e0d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"\tabandon \u003d group glance-core"},{"line_number":6,"context_line":"\tabandon \u003d group glance-ptl"},{"line_number":7,"context_line":"\tabandon \u003d group glance-reviewbot"},{"line_number":8,"context_line":"\tlabel-Code-Review \u003d -2..+1 group glance-ptl"},{"line_number":9,"context_line":"\tlabel-Code-Review \u003d -2..+2 group glance-core"},{"line_number":10,"context_line":"\tlabel-Review-Priority \u003d -1..+2 group glance-core"},{"line_number":11,"context_line":"\tlabel-Review-Priority \u003d -1..+2 group glance-ptl"}],"source_content_type":"text/x-ini","patch_set":2,"id":"61125bda_d422d5ce","line":8,"in_reply_to":"8fe9320c_b63bb8aa","updated":"2024-05-15 13:34:03.000000000","message":"It\u0027s alluded to in Brian\u0027s earlier review comments, but chiefly because \"Glance currently has a non-core PTL.\"","commit_id":"25bf7cc54de5d2846cb58301af98f6f39e791851"}]}