)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},"change_message_id":"a6f9e1913b9af9f0bf5e34305a459081e7978775","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d11ec202_6e49aeb4","updated":"2024-03-25 13:59:57.000000000","message":"@fungi yeah, to keep consistency with other projects I created the definitions similarly to those project.\nThis a good question, I don\u0027t have the history to be able to answer.\nPackstack is RHEL distro oriented whereas p-o-i supports RHEL, Debian and Ubuntu ones, it may be one of the reason.","commit_id":"2bae77b9467ea14c30828e06981c858260631356"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1a7513c5bd1132f6f779289be3fba4f5cd4c76bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fd1b59b7_f88bc37a","in_reply_to":"d11ec202_6e49aeb4","updated":"2024-04-02 09:36:54.000000000","message":"Actually I would prefer to not use this","commit_id":"2bae77b9467ea14c30828e06981c858260631356"},{"author":{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},"change_message_id":"9e67a58483bad5b4041bb2492663713b10b523ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"929f7e2d_cac58d2b","updated":"2024-04-03 15:42:59.000000000","message":"Thank you both for the reviews.\nI read the meeting minutes of the latest infra meeting [1].\nI\u0027m ok with the proposal, where should I request the dedicated Gerrit account ?\nWe\u0027ll run the job on RDO Zuul tenant [2\n\n[1] https://meetings.opendev.org/meetings/infra/2024/infra.2024-04-02-19.00.log.txt\n[2] https://review.rdoproject.org/zuul/status","commit_id":"eb883f60c5e5aa324d9eed69310787019e20ce05"}],"playbooks/proposal/generate_packstack_puppetfile.sh":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1a7513c5bd1132f6f779289be3fba4f5cd4c76bb","unresolved":true,"context_lines":[{"line_number":6,"context_line":"DIR\u003d\"${1:-packstack}\""},{"line_number":7,"context_line":"POI_PUPPETFILE\u003dpoi_puppetfile"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"curl -s -L https://raw.githubusercontent.com/openstack/puppet-openstack-integration/master/Puppetfile -o $POI_PUPPETFILE"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# header"},{"line_number":12,"context_line":"echo -e \"# Auto-generated Puppetfile for Packstack project\\n\" \u003e $DIR/Puppetfile"}],"source_content_type":"text/x-sh","patch_set":3,"id":"22017845_b8343ddd","line":9,"updated":"2024-04-02 09:36:54.000000000","message":"I\u0027m not sure relying on github is a good idea. Is there a reason not to use the opendev.org gitea site instead?","commit_id":"2bae77b9467ea14c30828e06981c858260631356"},{"author":{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},"change_message_id":"65ec3b23e8550777bd63c1efc9c08b11c4db6bd6","unresolved":false,"context_lines":[{"line_number":6,"context_line":"DIR\u003d\"${1:-packstack}\""},{"line_number":7,"context_line":"POI_PUPPETFILE\u003dpoi_puppetfile"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"curl -s -L https://raw.githubusercontent.com/openstack/puppet-openstack-integration/master/Puppetfile -o $POI_PUPPETFILE"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# header"},{"line_number":12,"context_line":"echo -e \"# Auto-generated Puppetfile for Packstack project\\n\" \u003e $DIR/Puppetfile"}],"source_content_type":"text/x-sh","patch_set":3,"id":"61092978_80111ddc","line":9,"in_reply_to":"22017845_b8343ddd","updated":"2024-04-02 11:29:31.000000000","message":"Right, let\u0027s use opendev.org gitea site instead","commit_id":"2bae77b9467ea14c30828e06981c858260631356"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"96f2d8bf5799cd82912f38161eb211596aa6ffd4","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    if [ ! -z \"$pin\" ]; then"},{"line_number":34,"context_line":"        git ls-remote --exit-code https://github.com/$namespace/$module $pin"},{"line_number":35,"context_line":"        if (($? \u003d\u003d 2)); then"},{"line_number":36,"context_line":"            if ! git ls-remote --exit-code https://github.com/$namespace/$module | grep -q $pin; then"},{"line_number":37,"context_line":"                echo \"Wrong pin: $pin does not exist in $module module.\""},{"line_number":38,"context_line":"                exit 1"},{"line_number":39,"context_line":"            else"}],"source_content_type":"text/x-sh","patch_set":4,"id":"33ccc28b_408504fb","line":36,"updated":"2024-04-02 11:48:57.000000000","message":"There are still other remote interactions with GitHub, such as this.","commit_id":"eb883f60c5e5aa324d9eed69310787019e20ce05"},{"author":{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},"change_message_id":"c6d61adbd57f08d452b5347280943b82cd43a416","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    if [ ! -z \"$pin\" ]; then"},{"line_number":34,"context_line":"        git ls-remote --exit-code https://github.com/$namespace/$module $pin"},{"line_number":35,"context_line":"        if (($? \u003d\u003d 2)); then"},{"line_number":36,"context_line":"            if ! git ls-remote --exit-code https://github.com/$namespace/$module | grep -q $pin; then"},{"line_number":37,"context_line":"                echo \"Wrong pin: $pin does not exist in $module module.\""},{"line_number":38,"context_line":"                exit 1"},{"line_number":39,"context_line":"            else"}],"source_content_type":"text/x-sh","patch_set":4,"id":"edd93ac0_436e00d5","line":36,"in_reply_to":"33ccc28b_408504fb","updated":"2024-04-02 12:49:16.000000000","message":"Yes but those puppet module repos are actually hosted only on Github (they are not under OpenStack governance).","commit_id":"eb883f60c5e5aa324d9eed69310787019e20ce05"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"96f2d8bf5799cd82912f38161eb211596aa6ffd4","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        # If the module is defined in puppet-openstack-integration, then we set the same reference"},{"line_number":47,"context_line":"        tag\u003d$(grep -A1 -e \"https://github.com/$namespace/$module\" $POI_PUPPETFILE| grep -e \":ref\" | cut -d\"\u0027\" -f2)"},{"line_number":48,"context_line":"        if [ -z \"$tag\" ]; then"},{"line_number":49,"context_line":"            git clone https://github.com/$namespace/$module modules/$module"},{"line_number":50,"context_line":"            tag\u003d$(cd modules/$module; git describe --tags $(git rev-list --tags --max-count\u003d1))"},{"line_number":51,"context_line":"            rm -rf modules/$module"},{"line_number":52,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1465fa68_fd9a5b78","line":49,"updated":"2024-04-02 11:48:57.000000000","message":"And here.","commit_id":"eb883f60c5e5aa324d9eed69310787019e20ce05"},{"author":{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},"change_message_id":"c6d61adbd57f08d452b5347280943b82cd43a416","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        # If the module is defined in puppet-openstack-integration, then we set the same reference"},{"line_number":47,"context_line":"        tag\u003d$(grep -A1 -e \"https://github.com/$namespace/$module\" $POI_PUPPETFILE| grep -e \":ref\" | cut -d\"\u0027\" -f2)"},{"line_number":48,"context_line":"        if [ -z \"$tag\" ]; then"},{"line_number":49,"context_line":"            git clone https://github.com/$namespace/$module modules/$module"},{"line_number":50,"context_line":"            tag\u003d$(cd modules/$module; git describe --tags $(git rev-list --tags --max-count\u003d1))"},{"line_number":51,"context_line":"            rm -rf modules/$module"},{"line_number":52,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"63439171_d2b2b0ba","line":49,"in_reply_to":"1465fa68_fd9a5b78","updated":"2024-04-02 12:49:16.000000000","message":"ditto","commit_id":"eb883f60c5e5aa324d9eed69310787019e20ce05"}],"zuul.d/projects.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1a7513c5bd1132f6f779289be3fba4f5cd4c76bb","unresolved":true,"context_lines":[{"line_number":6343,"context_line":"      - publish-to-pypi"},{"line_number":6344,"context_line":"    periodic:"},{"line_number":6345,"context_line":"      jobs:"},{"line_number":6346,"context_line":"        - propose-updates:"},{"line_number":6347,"context_line":"            branches: master"},{"line_number":6348,"context_line":"            vars:"},{"line_number":6349,"context_line":"              update_target: packstack-constraints"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a191229a_ea997279","line":6346,"updated":"2024-04-02 09:36:54.000000000","message":"This job uses a secret that according to my understanding is specifically made for updates of the openstack/requirements repo. I don\u0027t think that it is a good idea to allow projects that are not under openstack governance to use it.","commit_id":"2bae77b9467ea14c30828e06981c858260631356"},{"author":{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},"change_message_id":"65ec3b23e8550777bd63c1efc9c08b11c4db6bd6","unresolved":true,"context_lines":[{"line_number":6343,"context_line":"      - publish-to-pypi"},{"line_number":6344,"context_line":"    periodic:"},{"line_number":6345,"context_line":"      jobs:"},{"line_number":6346,"context_line":"        - propose-updates:"},{"line_number":6347,"context_line":"            branches: master"},{"line_number":6348,"context_line":"            vars:"},{"line_number":6349,"context_line":"              update_target: packstack-constraints"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f8572fde_a8021e3f","line":6346,"in_reply_to":"a191229a_ea997279","updated":"2024-04-02 11:29:31.000000000","message":"This secret is used for openstack/requirements updates, and for other projects [1]\nI do agree with your statement, is there a way to create an account just for packstack ? or better, a generic account for projects not under openstack governance ?\n\n[1] https://opendev.org/openstack/project-config/src/branch/master/playbooks/proposal/propose_update.sh#L31-L73","commit_id":"2bae77b9467ea14c30828e06981c858260631356"},{"author":{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},"change_message_id":"9e67a58483bad5b4041bb2492663713b10b523ce","unresolved":false,"context_lines":[{"line_number":6343,"context_line":"      - publish-to-pypi"},{"line_number":6344,"context_line":"    periodic:"},{"line_number":6345,"context_line":"      jobs:"},{"line_number":6346,"context_line":"        - propose-updates:"},{"line_number":6347,"context_line":"            branches: master"},{"line_number":6348,"context_line":"            vars:"},{"line_number":6349,"context_line":"              update_target: packstack-constraints"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"415f9752_c3821d8b","line":6346,"in_reply_to":"f8572fde_a8021e3f","updated":"2024-04-03 15:42:59.000000000","message":"Done","commit_id":"2bae77b9467ea14c30828e06981c858260631356"}]}