)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"bb24915b9591bf09e4b1a663a413f4d30bb3165e","unresolved":true,"context_lines":[{"line_number":21,"context_line":"  activities except the final workflow to land code"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"As a transition, I\u0027m leaving ironic-core group in the ACLs. Once the new"},{"line_number":24,"context_line":"group is created, populated, and working, we can retire the old one."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"I\u0027ve also, as a result of auditing the core groups for other Ironic"},{"line_number":27,"context_line":"projects and seeing some of them out of date, am unifying more"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fe1ef57_e3b85029","line":24,"updated":"2024-10-10 16:16:58.000000000","message":"Note that there isn\u0027t a way to truly retire gerrit groups. We can remove their users and stop including the group in acl files but the group will live on.\n\nOne way to mitigate this is to rename a group from one name to another. In this example I think we could rename ironic-core to ironic-reviewers but the coordination between gerrit and project-config to do that without accidentally recreating a group we don\u0027t want is probably not worth the effort.\n\nJust want to call that out to avoid any surprises later.","commit_id":"2ad10cfe8eae1919585b89b495111c3dd3f2cb6f"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f7f76651caf1bcc07bd01e892bf7124cd63dc9dd","unresolved":true,"context_lines":[{"line_number":21,"context_line":"  activities except the final workflow to land code"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"As a transition, I\u0027m leaving ironic-core group in the ACLs. Once the new"},{"line_number":24,"context_line":"group is created, populated, and working, we can retire the old one."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"I\u0027ve also, as a result of auditing the core groups for other Ironic"},{"line_number":27,"context_line":"projects and seeing some of them out of date, am unifying more"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0aa0ea45_517d8e57","line":24,"in_reply_to":"9fe1ef57_e3b85029","updated":"2024-10-10 16:24:25.000000000","message":"ack, makes sense, we can rename ironic-cores to zzz-retired-group-ironic-cores or similar","commit_id":"2ad10cfe8eae1919585b89b495111c3dd3f2cb6f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"bdb1d834ca1f40202aba25043d01ec5f96096f1e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f295a06_7f70b615","updated":"2024-10-09 21:31:04.000000000","message":"I should likely add bifrost to the list of repos we are consolidating.","commit_id":"2ad10cfe8eae1919585b89b495111c3dd3f2cb6f"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5c90ae6cc22359de458a24bc314f57b84d226004","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b2d96d94_75ae32e6","updated":"2024-10-10 06:57:11.000000000","message":"thanks Jay!","commit_id":"2ad10cfe8eae1919585b89b495111c3dd3f2cb6f"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"dd272f8b8f0b883880bb394961de8aa967bd428f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"27f339b4_9640b8c5","in_reply_to":"0d21f098_9b9d92e8","updated":"2024-10-10 14:56:10.000000000","message":"I thought we might intentionally want to keep sushy separate? If not I can do this.","commit_id":"2ad10cfe8eae1919585b89b495111c3dd3f2cb6f"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"944ea1b5b1ee6f9dc642c7eba37fe6765d63726a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"85f5496b_0eca5bab","in_reply_to":"27f339b4_9640b8c5","updated":"2024-10-10 22:59:00.000000000","message":"I did this. I give my +1 as a core to you just adjudicating any unique active membership of those groups properly between ironic-reviewers and ironic-approvers as needed.","commit_id":"2ad10cfe8eae1919585b89b495111c3dd3f2cb6f"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5c90ae6cc22359de458a24bc314f57b84d226004","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0d21f098_9b9d92e8","in_reply_to":"5f295a06_7f70b615","updated":"2024-10-10 06:57:11.000000000","message":"probably also metalsmith, sushy, sushy-oem-idrac, virtualbmc, virtualpdu","commit_id":"2ad10cfe8eae1919585b89b495111c3dd3f2cb6f"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"0c09577dc40cbdd62dcb80e8eec63342b971e151","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"24ad9409_b1724129","in_reply_to":"85f5496b_0eca5bab","updated":"2024-10-11 08:42:29.000000000","message":"I think this split supersedes the split we have between internal repos, so including sushy* should be fine\nIf in doubt we can clarify during the next meeting (or PTG)","commit_id":"2ad10cfe8eae1919585b89b495111c3dd3f2cb6f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"517833462e4bc902c177e13fe9e638cf69295573","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2855471b_c8b3d934","updated":"2024-10-16 13:01:13.000000000","message":"Do you really need to hardcode this policy in ACLs? IMHO it would work just as well to add \"junior\" cores and tell them to hold back from approving things for some time. This is what I\u0027ve seen happening for other repos a couple of times and it seems to work well without introducing extra load on the infra team for seeding the new groups and reviewing multiple patches like this one.\n\nIf you still think you need this, could one of the groups keep the name \"ironic-core\" for simplicity and consistency with other teams?\n\nI\u0027m also a bit sceptical that having a group named \"ironic-reviewers\" might give the impression that reviewers from people outside that group are not wanted/valued.","commit_id":"dd6c0bcd910a539ac2465ea683f118e55fc5f31a"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b66342663621228d97337e3efe325a38deec549d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"528350b0_42ec9d04","updated":"2024-10-16 21:10:11.000000000","message":"Going to note: from an Ironic perspective this is good to merge. It was mentioned at the Ironic meeting this week, cores gave no objection, and the mailing list has +1 from several Ironic cores including the PTL.","commit_id":"dd6c0bcd910a539ac2465ea683f118e55fc5f31a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"111fd4d778bb9bdaf6b67d9b426a15e512936611","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"df98a6af_fbb1fc6d","updated":"2024-10-17 18:45:24.000000000","message":"With \"you\" I was meaning to address the Ironic community, not you personally, sorry if that was unclear.\n\nIf this is what the community wants, so be it.","commit_id":"dd6c0bcd910a539ac2465ea683f118e55fc5f31a"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1a3d0d224474b77b01a95c9b0ab32b113766f7e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"061b68a7_3029eeb2","updated":"2024-10-17 08:44:09.000000000","message":"this was discussed and approved from the ironic community","commit_id":"dd6c0bcd910a539ac2465ea683f118e55fc5f31a"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"57ea931f1737982a63665c76154c5d4154b77b3c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6a5fa07b_383b1d53","in_reply_to":"2855471b_c8b3d934","updated":"2024-10-16 16:54:14.000000000","message":"First of all, I generally prefer a trust based model as you pitch, but that was not the consensus of the larger Ironic core team. I\u0027m reflecting team consensus with this patch and would strongly prefer not to reopen the discussion.\n\nSecondly, I explicitly do not want to name the team `ironic-core` as it will *not* increase simplicity as it will only appear to be consistent with other teams. I\u0027d rather not use the -core moniker if it doesn\u0027t mean the same it does elsewhere.\n\nFor the last point, I don\u0027t see our group names as externally facing to new contributors, generally. In fact, feedback I\u0027ve gotten from non-cores before have been that their reviews don\u0027t feel valuable, so making a move to allow an onboarding ramp is an improvement.","commit_id":"dd6c0bcd910a539ac2465ea683f118e55fc5f31a"}]}