)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8144b4c9bdcc1b833c917e1801b649f10a9665c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ed609497_74cdb6cd","updated":"2025-09-05 20:42:50.000000000","message":"I think I would like to see us set toggleWipState for Registered Users in the openstack meta project config so that all openstack projects allow this to be changed without extra config we have to remember to apply.\n\nI personally use workflow -1 instead of the built in wip button because it allows anyone to change the state out of WIP by pushing a new patchset. For this reason I\u0027m reasonably confident that allowing registered users to do this isn\u0027t a problem. The ultimate control still remains in the core group deciding whether or not to approve a change.","commit_id":"89a2660dd5f31b80668ac71c8ba28e2c3c41cd8b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1c731b57167fce96ec0a6fed37ddcfb74bebf7c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"473bb102_1d62d52b","in_reply_to":"ed609497_74cdb6cd","updated":"2025-09-05 20:49:19.000000000","message":"Thanks for sharing the reason here, and on #opendev [1]\nyou\u0027ve convinced me that this isn\u0027t allowing all users isn\u0027t going to be problematic because they have a way already by uploading a new patchset to the same change with the \"workflow\" button, which, in all honestly, i expected to be the same behavior with the WIP thing.\n\n[1] https://meetings.opendev.org/irclogs/%23opendev/%23opendev.2025-09-05.log.html#opendev.2025-09-05.log.html#t2025-09-05T20:31:29","commit_id":"89a2660dd5f31b80668ac71c8ba28e2c3c41cd8b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"882130f552335b7e3928df792b0ad73bfab4db2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ba011eb2_6b7d7558","updated":"2025-10-22 14:10:47.000000000","message":"As a lazy person, I am all in favor of this as it means I won\u0027t have to specifically change the cinder ACLs.  In any case, my vote is that we make this change and then revisit if it turns out that it\u0027s being abused.","commit_id":"a13d6cf498f9a14dd6ec033873a2f3231a284da0"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"f68e2eeb6be1451418b0c8185fe39b70b888197f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"40856276_23722355","updated":"2025-09-06 05:37:00.000000000","message":"I think that this is too loose permission, and not sure we should be allowing any register user to flip the flag or anyone else.\n\nBut let\u0027s discuss that:)","commit_id":"a13d6cf498f9a14dd6ec033873a2f3231a284da0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ccc6c735a2bb0d5a92e99540b009de88859f137c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"59535a9c_4abd300a","in_reply_to":"3679a842_e3954c5c","updated":"2026-03-25 21:18:50.000000000","message":"okay, we can disagree there and allow teams to override this. I favor consistency between the way \"Workflow\" and \"WIP\" toggling works today. This patch does that.","commit_id":"a13d6cf498f9a14dd6ec033873a2f3231a284da0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"df0eea402950d66b8f48b4443b2fd83636246d89","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"963e196d_887fe3dd","in_reply_to":"40856276_23722355","updated":"2025-09-08 20:27:16.000000000","message":"Hey Dmitriy, \n\nthanks for the feedback on the ML as well [1]. I\u0027ll respond here to keep the discussion on the implementation. Do take a look at Clark\u0027s reasoning in [2] wrt the changes needed in _every_ repo (including ones that will come after this), and the follow up comment by fungi on the ML. \n\nIn OpenStack, setting -1 Workflow was in effect a WIP indicator. However, newer gerrit UI interface offers this alternative way of indicating WIP. Allowing any registered user to unset the state will preserve the semantic we had with setting Workflow -1; any contributor is allowed to push up a change and unset the workflow vote. \n\nI initially felt that it was probably going to cause some confusion - i.e., if users fat fingered/unset WIP unintentionally or unset the WIP intentionally without agreement from the original author, it\u0027d be weird.\n\nHowever, how often are we going to see that problem? We could discourage bad actors through code review comments or ban them if necessary. Toggling WIP state isn\u0027t as serious an issue as abandoning a change for example. Core reviewers are always able to intervene and fix things up. WDYT?\n\n\n[1] https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/RWX6TEPAZDP5WZDEK3PX3UO5WQCVCSYI/#MO74FB7JXT56MFUFU5UWYEP2JGIBPS6J\n[2] https://meetings.opendev.org/irclogs/%23opendev/%23opendev.2025-09-05.log.html#opendev.2025-09-05.log.html#t2025-09-05T20:31:29","commit_id":"a13d6cf498f9a14dd6ec033873a2f3231a284da0"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5ddfe8e948b2d2a78f276d903ed79498ce5a4116","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5ef5c381_e589107b","in_reply_to":"59535a9c_4abd300a","updated":"2026-05-08 07:08:07.000000000","message":"I am fine agree to disagree here.\nIMO \"consistent\" is actually to keep current default, as I can not unset \"-1 Workflow\" as a core as of today.","commit_id":"a13d6cf498f9a14dd6ec033873a2f3231a284da0"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"456729d0759f06f2cfb06e3ea16ec33f2aeb304d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3679a842_e3954c5c","in_reply_to":"963e196d_887fe3dd","updated":"2025-10-23 10:58:34.000000000","message":"\u003e any contributor is allowed to push up a change and unset the workflow vote\n\nI\u0027m not sure if it\u0027s a good or intended behavior, it was just the best we had at a time.\n\nWhile I think that core teams are really fine to unset the -W/WIP, I\u0027m still not sure this should be available to everyone.","commit_id":"a13d6cf498f9a14dd6ec033873a2f3231a284da0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a08503e9dc701b1a0dd37722f43249061cbfa354","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0c031d21_2e5ea14b","updated":"2026-05-02 23:12:46.000000000","message":"I don\u0027t know if we\u0027ve stalled because @noonedeadpunk@gmail.com disagreed? :) \n\nDo I need to get this resolved somehow? \n\nI just hit a problem here: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/987009\n\nI want to merge @lazekteam@gmail.com\u0027s change.. and will comment that he unwip it.. but, I wish I could just do that myself, because it\u0027s possible this could have just been a mistake?\n\nI do wish we enforced the same standards as i noted earlier - a Workflow-1 vote can be unset by anyone by simply pushing up a change or hitting the \"rebase\" button. I want to trust our contributors rather than fearing that someone will unwip something and create irreparable damage to our software.","commit_id":"6ea145cb48188c1db84c93c1a6762c964dfdcad6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2f3fc24875ac2bd45f86f85bf769bc2e3d00ba53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"23d32f6e_bddb9958","updated":"2026-05-08 07:13:53.000000000","message":"Let\u0027s merge this and revisit if people abuse this.","commit_id":"6ea145cb48188c1db84c93c1a6762c964dfdcad6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d971b87d5a62cefea1d0190ed04ae252b21871c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c3a4509b_1bd67170","updated":"2025-10-22 16:56:13.000000000","message":"Rebased to get this some more attention","commit_id":"6ea145cb48188c1db84c93c1a6762c964dfdcad6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a9518a21140d5471f6d8fcdc5b4f3f05d2b74226","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2d19c344_6c4fc7df","updated":"2025-10-23 05:08:23.000000000","message":"what about per project acls allowing that for only core reviewer group - will the per project definitions ,,win’’?","commit_id":"6ea145cb48188c1db84c93c1a6762c964dfdcad6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a39aae2378aee2b3237fd7ba7e57d25aa43e34eb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"81e2ca54_7aa09f20","in_reply_to":"0bca5ef0_c8f009ee","updated":"2025-10-23 06:08:41.000000000","message":"So in my mind - either we enforce that new setting on all projects (i.e. remove their project-level toggleWipState setting in that patch) or make their local settings still work and notify them if they want to adapt - they should raise a patch to remove their project-level acls for WIP.","commit_id":"6ea145cb48188c1db84c93c1a6762c964dfdcad6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"488bc9ed17ab082683f72b6f3595d64855d4f3aa","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0bca5ef0_c8f009ee","in_reply_to":"2d19c344_6c4fc7df","updated":"2025-10-23 05:51:47.000000000","message":"Ah, good question\n\n`exclusiveGroupPermissions` can be used to override this in a project.. [1], the current overrides in the projects would be ineffective without this: https://codesearch.opendev.org/?q\u003dtoggleWipState\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d\n\nwdyt @cboylan@sapwetik.org?\n\n\n\n[1] https://gerrit-review.googlesource.com/Documentation/access-control.html","commit_id":"6ea145cb48188c1db84c93c1a6762c964dfdcad6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"acaad6114bceae1672a834a37f6cc1016ab57f18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6336e199_254e4f38","in_reply_to":"81e2ca54_7aa09f20","updated":"2026-05-08 05:21:33.000000000","message":"Done","commit_id":"6ea145cb48188c1db84c93c1a6762c964dfdcad6"}]}