)]}'
{"doc/source/open-development.rst":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b408c42341df96245d1b4c72378eeb4e30dc24b8","unresolved":false,"context_lines":[{"line_number":84,"context_line":"In general, reviewing code takes a lot of time and effort and it\u0027s important"},{"line_number":85,"context_line":"for every reviewer to dedicate as much time as needed to each review in order"},{"line_number":86,"context_line":"to provide better comments and quality. However, when it comes to style and"},{"line_number":87,"context_line":"subjective arguments, it\u0027s recommended not to be extremely nitpicky. Finding"},{"line_number":88,"context_line":"the right balance and evaluating trade-off is as important as verifying all the"},{"line_number":89,"context_line":"above points."},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_4ea43ca3","line":87,"updated":"2018-06-13 12:18:03.000000000","message":"I think this is what started it all :) Wondering if we should add a link in this paragraph too, to the new section.Or to point to the governance thing. I think we\u0027ve decided that it isn\u0027t only style \u0026 subjective things. Anyway, outside the scope of this patch.","commit_id":"1ffffc8a0f29815f67188a5505be6484ab43739e"}],"doc/source/review-the-openstack-way.rst":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"a3afc71bf59fce4cc1340654e1a3b6240a2eb337","unresolved":false,"context_lines":[{"line_number":10,"context_line":"keeping the process flowing. In all cases use your best judgement, but we offer"},{"line_number":11,"context_line":"these heuristics from the collective experience of the community to guide you."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"It\u0027s patch submitters who keep OpenStack moving forward. As a reviewer,"},{"line_number":14,"context_line":"remember that you\u0027re providing a service to submitters, not the other way"},{"line_number":15,"context_line":"around. As a submitter, remember that everyone is subject to the same rules:"},{"line_number":16,"context_line":"even the core reviewers voting on your patch put their changes through the same"},{"line_number":17,"context_line":"code review process."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_70c2df36","line":15,"range":{"start_line":13,"start_character":57,"end_line":15,"end_character":7},"updated":"2018-06-18 12:58:43.000000000","message":"yay!","commit_id":"1ffffc8a0f29815f67188a5505be6484ab43739e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b408c42341df96245d1b4c72378eeb4e30dc24b8","unresolved":false,"context_lines":[{"line_number":81,"context_line":"question is going to reveal a problem, this is preferable to voting -1 in the"},{"line_number":82,"context_line":"first instance. If it\u0027s been a while without an answer, or new patch sets are"},{"line_number":83,"context_line":"posted without anyone responding to your comments, that might be time to"},{"line_number":84,"context_line":"consider a -1."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. _code-review-minus-1:"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_49143641","line":84,"updated":"2018-06-13 12:18:03.000000000","message":"Was thinking. One of the problems with 0 is that people sometimes miss the comment because they don\u0027t see a review. Which may be why someone didn\u0027t respond.","commit_id":"1ffffc8a0f29815f67188a5505be6484ab43739e"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"c7576108d8416f008aa31d56476bbb2a2ad89d6e","unresolved":false,"context_lines":[{"line_number":81,"context_line":"question is going to reveal a problem, this is preferable to voting -1 in the"},{"line_number":82,"context_line":"first instance. If it\u0027s been a while without an answer, or new patch sets are"},{"line_number":83,"context_line":"posted without anyone responding to your comments, that might be time to"},{"line_number":84,"context_line":"consider a -1."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. _code-review-minus-1:"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_657272e5","line":84,"in_reply_to":"5f7c97a3_49143641","updated":"2018-06-13 15:45:48.000000000","message":"Yeah, that\u0027s definitely a thing that happens. Can you suggest a better way to handle it than wait a while and then change to -1? Or are you saying we just need call to out specifically \"hey, the submitter is not necessarily ignoring you, they probably just didn\u0027t see it\"?\n\nHappy to add this in a follow-up.","commit_id":"1ffffc8a0f29815f67188a5505be6484ab43739e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ae584f61f4b994184ddec1519bf5642ce187f6e5","unresolved":false,"context_lines":[{"line_number":81,"context_line":"question is going to reveal a problem, this is preferable to voting -1 in the"},{"line_number":82,"context_line":"first instance. If it\u0027s been a while without an answer, or new patch sets are"},{"line_number":83,"context_line":"posted without anyone responding to your comments, that might be time to"},{"line_number":84,"context_line":"consider a -1."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. _code-review-minus-1:"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_4472cfe4","line":84,"in_reply_to":"5f7c97a3_657272e5","updated":"2018-06-14 00:24:55.000000000","message":"Ideally, the Code-Review part at the URL should also show 0 \u003cnames\u003e, just like it shows who voted +1, +2, -1, -2. Assuming we can\u0027t get that fixed...\n\nI guess it would be good to\n- remind the submitter to pay attention to comments, because it isn\u0027t always obvious via the URL, to see whether anyone voted 0 and had left comments\n- and mention to the reviewer that the submitter may not be ignoring but may have missed the comment. They could try to ping them (which isn\u0027t always that easy) or put a -1 to hopefully bring it to their attention.\n\nI\u0027m not sure if that answers your question. I sometimes ping, -1, maybe ask others, maybe just forget about it and leave it for others to review. Maybe 1 (I don\u0027t remember). So I don\u0027t have a better suggestion than what you proposed. So yeah, maybe just call out that it is possible that the submitter didn\u0027t respond for a variety of reasons, one being missing the 0/comment.","commit_id":"1ffffc8a0f29815f67188a5505be6484ab43739e"}]}
