)]}'
{"doc/source/dependency-management.rst":[{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"3afdcb05e0d01061f63d3a1a92bedce67614a03a","unresolved":false,"context_lines":[{"line_number":372,"context_line":"- In stable branches, we usually only update constraints for projects managed"},{"line_number":373,"context_line":"  within the OpenStack community. Exceptions are made for dependencies of"},{"line_number":374,"context_line":"  OpenStack projects when there are gate issues. Those updates must be"},{"line_number":375,"context_line":"  proposed by hand and carefully reviewed and cross-checked with vendors."},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"- The requirements team also verifies the new version\u0027s requirements changes"},{"line_number":378,"context_line":"  line up with the requirements in the stable branch (GR and UC)."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_660a0e8b","line":375,"updated":"2019-05-23 02:33:02.000000000","message":"The exceptions effectively make it so that this is all deps managed via global-requirements.txt and maybe even all of upper-constraints.txt","commit_id":"8c050dcce6de73c5dd1d469141a8074739015b80"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"5bf496ed0f01e3a16f5e593f8afa10fb43945c64","unresolved":false,"context_lines":[{"line_number":372,"context_line":"- In stable branches, we usually only update constraints for projects managed"},{"line_number":373,"context_line":"  within the OpenStack community. Exceptions are made for dependencies of"},{"line_number":374,"context_line":"  OpenStack projects when there are gate issues. Those updates must be"},{"line_number":375,"context_line":"  proposed by hand and carefully reviewed and cross-checked with vendors."},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"- The requirements team also verifies the new version\u0027s requirements changes"},{"line_number":378,"context_line":"  line up with the requirements in the stable branch (GR and UC)."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_8177e2d4","line":375,"in_reply_to":"bfb3d3c7_164d7d99","updated":"2019-05-23 13:58:37.000000000","message":"My point is that it opens us up to updating openstack libs and non-openstack libs.  so isn\u0027t that just everything then?","commit_id":"8c050dcce6de73c5dd1d469141a8074739015b80"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"fbf9a7b14523864f74366309500c20be01616ac8","unresolved":false,"context_lines":[{"line_number":372,"context_line":"- In stable branches, we usually only update constraints for projects managed"},{"line_number":373,"context_line":"  within the OpenStack community. Exceptions are made for dependencies of"},{"line_number":374,"context_line":"  OpenStack projects when there are gate issues. Those updates must be"},{"line_number":375,"context_line":"  proposed by hand and carefully reviewed and cross-checked with vendors."},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"- The requirements team also verifies the new version\u0027s requirements changes"},{"line_number":378,"context_line":"  line up with the requirements in the stable branch (GR and UC)."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_164d7d99","line":375,"in_reply_to":"bfb3d3c7_660a0e8b","updated":"2019-05-23 07:26:14.000000000","message":"Matt -- I am not sure what is your point there? Could you clarify?","commit_id":"8c050dcce6de73c5dd1d469141a8074739015b80"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"870e6d79563773ea1dab1f3a01e4f8de25706813","unresolved":false,"context_lines":[{"line_number":372,"context_line":"- In stable branches, we usually only update constraints for projects managed"},{"line_number":373,"context_line":"  within the OpenStack community. Exceptions are made for dependencies of"},{"line_number":374,"context_line":"  OpenStack projects when there are gate issues. Those updates must be"},{"line_number":375,"context_line":"  proposed by hand and carefully reviewed and cross-checked with vendors."},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"- The requirements team also verifies the new version\u0027s requirements changes"},{"line_number":378,"context_line":"  line up with the requirements in the stable branch (GR and UC)."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_e8631a19","line":375,"in_reply_to":"bfb3d3c7_78fa9b75","updated":"2019-05-23 20:17:31.000000000","message":"Since this section remained the same in the next patchset I\u0027m going to comment here.\n\nIf that is our \u0027demarcation point\u0027 (bot proposed vs not) then we should call it out more fully.","commit_id":"8c050dcce6de73c5dd1d469141a8074739015b80"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"fa3a615e076973a633836b085006423e65c9b5db","unresolved":false,"context_lines":[{"line_number":372,"context_line":"- In stable branches, we usually only update constraints for projects managed"},{"line_number":373,"context_line":"  within the OpenStack community. Exceptions are made for dependencies of"},{"line_number":374,"context_line":"  OpenStack projects when there are gate issues. Those updates must be"},{"line_number":375,"context_line":"  proposed by hand and carefully reviewed and cross-checked with vendors."},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"- The requirements team also verifies the new version\u0027s requirements changes"},{"line_number":378,"context_line":"  line up with the requirements in the stable branch (GR and UC)."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_78fa9b75","line":375,"in_reply_to":"bfb3d3c7_8177e2d4","updated":"2019-05-23 17:46:14.000000000","message":"the difference is \"usually update openstack maintained packages\" vs \"exceptionally update openstack dependencies\". so yes, everything can be updated, but one is usual, one is unusal. Also, the \"openstack maintained packages\" are suggested by teh bot, and there are different review rules for bot changes than for manually suggested changes (those require more review).","commit_id":"8c050dcce6de73c5dd1d469141a8074739015b80"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"fbf9a7b14523864f74366309500c20be01616ac8","unresolved":false,"context_lines":[{"line_number":383,"context_line":"As of the OpenStack Rocky release, the purpose of Global-requirements no"},{"line_number":384,"context_line":"longer includes specifing minimum acceptable versions. Starting with Rocky"},{"line_number":385,"context_line":"the minimum required versions are tracked in the individual projects"},{"line_number":386,"context_line":"instead. Global-requirements still specifiers the \"excluded\" versions"},{"line_number":387,"context_line":"of a particular given dependency."},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"For releases older than OpenStack Rocky, global-reqirements used to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_3650c132","line":386,"range":{"start_line":386,"start_character":35,"end_line":386,"end_character":45},"updated":"2019-05-23 07:26:14.000000000","message":"specify","commit_id":"8c050dcce6de73c5dd1d469141a8074739015b80"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"fa3a615e076973a633836b085006423e65c9b5db","unresolved":false,"context_lines":[{"line_number":383,"context_line":"As of the OpenStack Rocky release, the purpose of Global-requirements no"},{"line_number":384,"context_line":"longer includes specifing minimum acceptable versions. Starting with Rocky"},{"line_number":385,"context_line":"the minimum required versions are tracked in the individual projects"},{"line_number":386,"context_line":"instead. Global-requirements still specifiers the \"excluded\" versions"},{"line_number":387,"context_line":"of a particular given dependency."},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"For releases older than OpenStack Rocky, global-reqirements used to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_983aef31","line":386,"range":{"start_line":386,"start_character":35,"end_line":386,"end_character":45},"in_reply_to":"bfb3d3c7_3650c132","updated":"2019-05-23 17:46:14.000000000","message":"Done","commit_id":"8c050dcce6de73c5dd1d469141a8074739015b80"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"3afdcb05e0d01061f63d3a1a92bedce67614a03a","unresolved":false,"context_lines":[{"line_number":388,"context_line":""},{"line_number":389,"context_line":"For releases older than OpenStack Rocky, global-reqirements used to"},{"line_number":390,"context_line":"track excluded and minimum acceptable versions, and in some cases upper"},{"line_number":391,"context_line":"caps as well."},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"Changing the effectively used version for a dependency"},{"line_number":394,"context_line":"is only acceptable during `Maintained Phase`, and only due to security issues."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_86f4e287","line":391,"updated":"2019-05-23 02:33:02.000000000","message":"We still have some caps in global-requirements.txt past rocky.","commit_id":"8c050dcce6de73c5dd1d469141a8074739015b80"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"fbf9a7b14523864f74366309500c20be01616ac8","unresolved":false,"context_lines":[{"line_number":388,"context_line":""},{"line_number":389,"context_line":"For releases older than OpenStack Rocky, global-reqirements used to"},{"line_number":390,"context_line":"track excluded and minimum acceptable versions, and in some cases upper"},{"line_number":391,"context_line":"caps as well."},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"Changing the effectively used version for a dependency"},{"line_number":394,"context_line":"is only acceptable during `Maintained Phase`, and only due to security issues."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_d614c550","line":391,"in_reply_to":"bfb3d3c7_86f4e287","updated":"2019-05-23 07:26:14.000000000","message":"side topic: I suppose those are to not repeat ourselves on long series, but shouldn\u0027t those be removed if we want to have more opportunities/force ourselves to work with different upstream communities?\n\nAnyway... Matt\u0027s clarification could be done in a separate paragraph inside this section.","commit_id":"8c050dcce6de73c5dd1d469141a8074739015b80"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"fa3a615e076973a633836b085006423e65c9b5db","unresolved":false,"context_lines":[{"line_number":388,"context_line":""},{"line_number":389,"context_line":"For releases older than OpenStack Rocky, global-reqirements used to"},{"line_number":390,"context_line":"track excluded and minimum acceptable versions, and in some cases upper"},{"line_number":391,"context_line":"caps as well."},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"Changing the effectively used version for a dependency"},{"line_number":394,"context_line":"is only acceptable during `Maintained Phase`, and only due to security issues."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_584b17af","line":391,"in_reply_to":"bfb3d3c7_d614c550","updated":"2019-05-23 17:46:14.000000000","message":"upper caps are definitly not the preference as they\u0027re super painful to adjust or get rid of (a longer \"change cap\", \"re-release everyting\", \"update to everything that got released\", sometimes \"fix cap again\")","commit_id":"8c050dcce6de73c5dd1d469141a8074739015b80"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"fbf9a7b14523864f74366309500c20be01616ac8","unresolved":false,"context_lines":[{"line_number":391,"context_line":"caps as well."},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"Changing the effectively used version for a dependency"},{"line_number":394,"context_line":"is only acceptable during `Maintained Phase`, and only due to security issues."},{"line_number":395,"context_line":""},{"line_number":396,"context_line":".. _Maintained Phase: https://docs.openstack.org/project-team-guide/stable-branches.html#maintenance-phases"},{"line_number":397,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_2903860f","line":394,"range":{"start_line":394,"start_character":62,"end_line":394,"end_character":77},"updated":"2019-05-23 07:26:14.000000000","message":"``security issues in an openstack project``? (As, according to the ML, we don\u0027t track every single security issues in the deps of deps?) I think clarification would be welcomed, but it\u0027s hard to really draw a line.","commit_id":"8c050dcce6de73c5dd1d469141a8074739015b80"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"fa3a615e076973a633836b085006423e65c9b5db","unresolved":false,"context_lines":[{"line_number":391,"context_line":"caps as well."},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"Changing the effectively used version for a dependency"},{"line_number":394,"context_line":"is only acceptable during `Maintained Phase`, and only due to security issues."},{"line_number":395,"context_line":""},{"line_number":396,"context_line":".. _Maintained Phase: https://docs.openstack.org/project-team-guide/stable-branches.html#maintenance-phases"},{"line_number":397,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_78db7bec","line":394,"range":{"start_line":394,"start_character":62,"end_line":394,"end_character":77},"in_reply_to":"bfb3d3c7_094ec26e","updated":"2019-05-23 17:46:14.000000000","message":"Right I wanted to ahve the \"new\" things in the other review. this one is supposed to just clarify existing state, not change it.","commit_id":"8c050dcce6de73c5dd1d469141a8074739015b80"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"72d650233ee39d58d680ddbf15672039d7007c0b","unresolved":false,"context_lines":[{"line_number":391,"context_line":"caps as well."},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"Changing the effectively used version for a dependency"},{"line_number":394,"context_line":"is only acceptable during `Maintained Phase`, and only due to security issues."},{"line_number":395,"context_line":""},{"line_number":396,"context_line":".. _Maintained Phase: https://docs.openstack.org/project-team-guide/stable-branches.html#maintenance-phases"},{"line_number":397,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_094ec26e","line":394,"range":{"start_line":394,"start_character":62,"end_line":394,"end_character":77},"in_reply_to":"bfb3d3c7_2903860f","updated":"2019-05-23 07:28:23.000000000","message":"Oh, I suppose I have to read: https://review.opendev.org/#/c/660855","commit_id":"8c050dcce6de73c5dd1d469141a8074739015b80"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"8490af1811249fed3f53efd8a7a69e388e1ab459","unresolved":false,"context_lines":[{"line_number":381,"context_line":""},{"line_number":382,"context_line":"These should be few and far between on stable branches, mainly masking known"},{"line_number":383,"context_line":"bad versions or in extreme adding a maximum version allowable for a package."},{"line_number":384,"context_line":"We work to remove these caps as well.  Raising effective minimums is only"},{"line_number":385,"context_line":"acceptable during `Phase I`, and only due to security issues."},{"line_number":386,"context_line":""},{"line_number":387,"context_line":".. _Phase I: https://docs.openstack.org/project-team-guide/stable-branches.html#support-phases"},{"line_number":388,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_ea31caa3","side":"PARENT","line":385,"range":{"start_line":384,"start_character":39,"end_line":385,"end_character":61},"updated":"2019-05-24 03:59:16.000000000","message":"This is a different issue that the one we\u0027re facing with request et.al.  This needs to remain and be *explicit* about minimum versions.  We probably need to take it it of the global-requirements section as it\u0027s now a project-team issue but we need to have something to point at that says minimum bumps on stable are a \"big deal\" and need to be done in conjunction with stable, release, and requirements teams","commit_id":"42c2fff08f799276e6fdd62e606ae4377b767c37"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"1e7f88acc82cf726bb0cd7731e77a1b4836b5eec","unresolved":false,"context_lines":[{"line_number":381,"context_line":""},{"line_number":382,"context_line":"These should be few and far between on stable branches, mainly masking known"},{"line_number":383,"context_line":"bad versions or in extreme adding a maximum version allowable for a package."},{"line_number":384,"context_line":"We work to remove these caps as well.  Raising effective minimums is only"},{"line_number":385,"context_line":"acceptable during `Phase I`, and only due to security issues."},{"line_number":386,"context_line":""},{"line_number":387,"context_line":".. _Phase I: https://docs.openstack.org/project-team-guide/stable-branches.html#support-phases"},{"line_number":388,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_0db16747","side":"PARENT","line":385,"range":{"start_line":384,"start_character":39,"end_line":385,"end_character":61},"in_reply_to":"bfb3d3c7_ea31caa3","updated":"2019-06-14 15:20:29.000000000","message":"so you\u0027re saying the project\u0027s *requirements file should not see changes on stable/ that change the effective minimums? or that they can be done in conjunction with stable/release/requirements teams? is that the existing policy? how would that work? we wait for explit reviews ?","commit_id":"42c2fff08f799276e6fdd62e606ae4377b767c37"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"7dcf1656fe7266b747cf24cf2f73afcf26140ce5","unresolved":false,"context_lines":[{"line_number":380,"context_line":"Global-requirements"},{"line_number":381,"context_line":"+++++++++++++++++++"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"The scope of global-requirements.txt has slightly changed over time."},{"line_number":384,"context_line":"Starting with Rocky the minimum required versions are tracked individually"},{"line_number":385,"context_line":"in the individual OpenStack projects.  Global-requirements still specify"},{"line_number":386,"context_line":"the \"excluded\" versions of a particular given dependency as well as"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_04cfe757","line":383,"range":{"start_line":383,"start_character":13,"end_line":383,"end_character":36},"updated":"2019-06-17 15:03:51.000000000","message":"``global-requirements.txt`` (formatting, please)","commit_id":"935e83c1edb9d783f69684135439a7eb4314bda5"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"7dcf1656fe7266b747cf24cf2f73afcf26140ce5","unresolved":false,"context_lines":[{"line_number":381,"context_line":"+++++++++++++++++++"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"The scope of global-requirements.txt has slightly changed over time."},{"line_number":384,"context_line":"Starting with Rocky the minimum required versions are tracked individually"},{"line_number":385,"context_line":"in the individual OpenStack projects.  Global-requirements still specify"},{"line_number":386,"context_line":"the \"excluded\" versions of a particular given dependency as well as"},{"line_number":387,"context_line":"upper bounds (\"caps\"), should they be needed."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_24cc6b60","line":384,"range":{"start_line":384,"start_character":13,"end_line":384,"end_character":20},"updated":"2019-06-17 15:03:51.000000000","message":"Rocky, the minimum*","commit_id":"935e83c1edb9d783f69684135439a7eb4314bda5"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"7dcf1656fe7266b747cf24cf2f73afcf26140ce5","unresolved":false,"context_lines":[{"line_number":382,"context_line":""},{"line_number":383,"context_line":"The scope of global-requirements.txt has slightly changed over time."},{"line_number":384,"context_line":"Starting with Rocky the minimum required versions are tracked individually"},{"line_number":385,"context_line":"in the individual OpenStack projects.  Global-requirements still specify"},{"line_number":386,"context_line":"the \"excluded\" versions of a particular given dependency as well as"},{"line_number":387,"context_line":"upper bounds (\"caps\"), should they be needed."},{"line_number":388,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_c4d8ef1f","line":385,"range":{"start_line":385,"start_character":37,"end_line":385,"end_character":38},"updated":"2019-06-17 15:03:51.000000000","message":"remove extra whitespace","commit_id":"935e83c1edb9d783f69684135439a7eb4314bda5"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"7dcf1656fe7266b747cf24cf2f73afcf26140ce5","unresolved":false,"context_lines":[{"line_number":383,"context_line":"The scope of global-requirements.txt has slightly changed over time."},{"line_number":384,"context_line":"Starting with Rocky the minimum required versions are tracked individually"},{"line_number":385,"context_line":"in the individual OpenStack projects.  Global-requirements still specify"},{"line_number":386,"context_line":"the \"excluded\" versions of a particular given dependency as well as"},{"line_number":387,"context_line":"upper bounds (\"caps\"), should they be needed."},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"For releases older than OpenStack Rocky, global-requirements is also used to"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_84043780","line":386,"range":{"start_line":386,"start_character":4,"end_line":386,"end_character":14},"updated":"2019-06-17 15:03:51.000000000","message":"remove inverted commas","commit_id":"935e83c1edb9d783f69684135439a7eb4314bda5"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c1e847aef33c0f193445eb7d774ea5976d91af4d","unresolved":false,"context_lines":[{"line_number":389,"context_line":"For releases older than OpenStack Rocky, global-requirements is also used to"},{"line_number":390,"context_line":"track excluded and globally defined minimum required versions."},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"Changing the effectively used version for any OpenStack dependency"},{"line_number":393,"context_line":"is only acceptable during `Maintained Phase`, and only due to security issues."},{"line_number":394,"context_line":""},{"line_number":395,"context_line":".. _Maintained Phase: https://docs.openstack.org/project-team-guide/stable-branches.html#maintenance-phases"},{"line_number":396,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_93c17083","line":393,"range":{"start_line":392,"start_character":0,"end_line":393,"end_character":78},"updated":"2019-05-23 18:05:16.000000000","message":"Does this \"match reality\"? I thought that was the current debate on changing requests.\n\nI still think we need a separate policy defined for handling those situations, then if that is acceptable we can add this part. But I don\u0027t think this should be included at this point.","commit_id":"935e83c1edb9d783f69684135439a7eb4314bda5"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"8490af1811249fed3f53efd8a7a69e388e1ab459","unresolved":false,"context_lines":[{"line_number":389,"context_line":"For releases older than OpenStack Rocky, global-requirements is also used to"},{"line_number":390,"context_line":"track excluded and globally defined minimum required versions."},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"Changing the effectively used version for any OpenStack dependency"},{"line_number":393,"context_line":"is only acceptable during `Maintained Phase`, and only due to security issues."},{"line_number":394,"context_line":""},{"line_number":395,"context_line":".. _Maintained Phase: https://docs.openstack.org/project-team-guide/stable-branches.html#maintenance-phases"},{"line_number":396,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_aa2bd22d","line":393,"range":{"start_line":392,"start_character":0,"end_line":393,"end_character":78},"updated":"2019-05-24 03:59:16.000000000","message":"I disagree with this.  You\u0027ve covered this off with the section in upper-constraints:\n\n  Those updates must be proposed by hand and carefully reviewed and cross-checked with vendors.","commit_id":"935e83c1edb9d783f69684135439a7eb4314bda5"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"c5d64d7698758aa053d73e635326329c77ed045d","unresolved":false,"context_lines":[{"line_number":390,"context_line":"track excluded and globally defined minimum required versions."},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"Changing the effectively used version for any OpenStack dependency"},{"line_number":393,"context_line":"is only acceptable during `Maintained Phase`, and only due to security issues."},{"line_number":394,"context_line":""},{"line_number":395,"context_line":".. _Maintained Phase: https://docs.openstack.org/project-team-guide/stable-branches.html#maintenance-phases"},{"line_number":396,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_5b746e68","line":393,"range":{"start_line":393,"start_character":26,"end_line":393,"end_character":44},"updated":"2019-05-23 20:42:53.000000000","message":"Missing an underscore after `Maintained Phase` to make it a link.","commit_id":"935e83c1edb9d783f69684135439a7eb4314bda5"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"1e7f88acc82cf726bb0cd7731e77a1b4836b5eec","unresolved":false,"context_lines":[{"line_number":389,"context_line":"For releases older than OpenStack Rocky, global-requirements is also used to"},{"line_number":390,"context_line":"track excluded and globally defined minimum required versions."},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"Changing the effectively used version for any OpenStack dependency"},{"line_number":393,"context_line":"is only acceptable during `Maintained Phase`, and only due to security issues."},{"line_number":394,"context_line":""},{"line_number":395,"context_line":".. _Maintained Phase: https://docs.openstack.org/project-team-guide/stable-branches.html#maintenance-phases"},{"line_number":396,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_4d7c3f71","line":393,"range":{"start_line":392,"start_character":0,"end_line":393,"end_character":78},"in_reply_to":"bfb3d3c7_93c17083","updated":"2019-06-14 15:20:29.000000000","message":"I just moved the text from above and updated teh Phase 1 to maintained phase. I did not modify intention of it or clarify it further as far as I can see.","commit_id":"935e83c1edb9d783f69684135439a7eb4314bda5"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"870e6d79563773ea1dab1f3a01e4f8de25706813","unresolved":false,"context_lines":[{"line_number":389,"context_line":"For releases older than OpenStack Rocky, global-requirements is also used to"},{"line_number":390,"context_line":"track excluded and globally defined minimum required versions."},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"Changing the effectively used version for any OpenStack dependency"},{"line_number":393,"context_line":"is only acceptable during `Maintained Phase`, and only due to security issues."},{"line_number":394,"context_line":""},{"line_number":395,"context_line":".. _Maintained Phase: https://docs.openstack.org/project-team-guide/stable-branches.html#maintenance-phases"},{"line_number":396,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_a89f6201","line":393,"range":{"start_line":392,"start_character":0,"end_line":393,"end_character":78},"in_reply_to":"bfb3d3c7_93c17083","updated":"2019-05-23 20:17:31.000000000","message":"I think the main part of the confusion, at least in my head, is that it\u0027s not doc\u0027d.\n\nIs having a section for \u0027security updates during maintained phase\u0027 what you are looking for?","commit_id":"935e83c1edb9d783f69684135439a7eb4314bda5"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"1e7f88acc82cf726bb0cd7731e77a1b4836b5eec","unresolved":false,"context_lines":[{"line_number":389,"context_line":"For releases older than OpenStack Rocky, global-requirements is also used to"},{"line_number":390,"context_line":"track excluded and globally defined minimum required versions."},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"Changing the effectively used version for any OpenStack dependency"},{"line_number":393,"context_line":"is only acceptable during `Maintained Phase`, and only due to security issues."},{"line_number":394,"context_line":""},{"line_number":395,"context_line":".. _Maintained Phase: https://docs.openstack.org/project-team-guide/stable-branches.html#maintenance-phases"},{"line_number":396,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_cd8fcf72","line":393,"range":{"start_line":392,"start_character":0,"end_line":393,"end_character":78},"in_reply_to":"bfb3d3c7_aa2bd22d","updated":"2019-06-14 15:20:29.000000000","message":"you mean in the other review depending on this review? what is the change that you\u0027re suggesting for this review? sorry I can not follow atm.","commit_id":"935e83c1edb9d783f69684135439a7eb4314bda5"}]}