)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"99596cc6d7c20812f247f2058b1acb54894f6adf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e53d217f_17e36c03","updated":"2024-03-25 08:45:35.000000000","message":"that\u0027s a soft -1 mostly for discussing about my thought, I think we can merge that patch here and have another change for explaining how to get the logs.","commit_id":"46230c71621228522363f7d43ab4d933c2cbbab4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"db7bceffeb85063e4c5fac513ff13c72ebc275b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"952124ab_2ddc814e","updated":"2024-03-26 19:11:24.000000000","message":"lgtm, thanks. Leaving it open for a couple of days in case any other member have feedback else I will (or any other member can) approve if no objection or so.","commit_id":"6885a4d80df469de9eb389a8c9816f80f14619b8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8e91d28eea8ddc658ad1e949e2671dfbbaf96046","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1b6e4a13_8913c2db","updated":"2024-05-13 05:38:41.000000000","message":"recheck build expired, want to check formatting","commit_id":"6885a4d80df469de9eb389a8c9816f80f14619b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"48b863ff749f192ca4c321f8072c06721a6c5149","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7ff45338_29989e82","updated":"2024-05-31 19:08:49.000000000","message":"Thanks Slawek.. i think this has waited a while; and i see frickler\u0027s comments addressed.. so assuming he won\u0027t mind me letting this in :) We can address any fall outs in subsequent patches","commit_id":"7f07719c6ccb008c447d98de961d00a68bdf30c2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"89c3cfbf7e72b9929eb2f157d945242c6b2ce61f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e52ec56f_92f403b3","updated":"2024-05-29 17:10:00.000000000","message":"lgtm. as frickler had some comments, I am leaving +A to him.","commit_id":"7f07719c6ccb008c447d98de961d00a68bdf30c2"}],"doc/source/testing.rst":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"99596cc6d7c20812f247f2058b1acb54894f6adf","unresolved":true,"context_lines":[{"line_number":116,"context_line":"          failed or some other info about what and in which job/test case"},{"line_number":117,"context_line":"          went wrong."},{"line_number":118,"context_line":"          Please try to avoid comments like ``recheck - unrelated failure`` as"},{"line_number":119,"context_line":"          such comments are almost the same as simply ``recheck`` without any"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"It is important that before you request a recheck, you adhere to the"},{"line_number":122,"context_line":"following guidelines:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d480f45f_18eb50bc","line":119,"updated":"2024-03-25 08:45:35.000000000","message":"I can see that we provide examples below, which is nice (but maybe we could say \u0027look at the examples below\u0027 here).\n\nThat said, I have one thought : AFAICS, we don\u0027t explain how to examine the logs and which even logs we can check (I mean, clicking on the job, going to Zuul and finding what link to look at).\n\nIf people don\u0027t even think to click on the log, and at least try to look at the main log, they are not able to tell what\u0027s the root cause.\n\nCould we maybe try to provide a new paragraph for that here ? Do we maybe need to provide an example ?","commit_id":"46230c71621228522363f7d43ab4d933c2cbbab4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"063b2aecb50afab5b5c4c6363f9098df05950c14","unresolved":true,"context_lines":[{"line_number":116,"context_line":"          failed or some other info about what and in which job/test case"},{"line_number":117,"context_line":"          went wrong."},{"line_number":118,"context_line":"          Please try to avoid comments like ``recheck - unrelated failure`` as"},{"line_number":119,"context_line":"          such comments are almost the same as simply ``recheck`` without any"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"It is important that before you request a recheck, you adhere to the"},{"line_number":122,"context_line":"following guidelines:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b5faa669_1df9acad","line":119,"in_reply_to":"3e850b82_9baeaf57","updated":"2024-03-26 10:19:13.000000000","message":"@Sylvain I added info about examples below, I hope that this will be ok for You.\n@Sean: good point, I just proposed it in https://review.opendev.org/c/openstack/project-config/+/914189","commit_id":"46230c71621228522363f7d43ab4d933c2cbbab4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a2afff1499a525420baaab1a091f4cbc40af8727","unresolved":false,"context_lines":[{"line_number":116,"context_line":"          failed or some other info about what and in which job/test case"},{"line_number":117,"context_line":"          went wrong."},{"line_number":118,"context_line":"          Please try to avoid comments like ``recheck - unrelated failure`` as"},{"line_number":119,"context_line":"          such comments are almost the same as simply ``recheck`` without any"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"It is important that before you request a recheck, you adhere to the"},{"line_number":122,"context_line":"following guidelines:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d9c072f7_262974e3","line":119,"in_reply_to":"b5faa669_1df9acad","updated":"2024-03-27 12:45:57.000000000","message":"Acknowledged","commit_id":"46230c71621228522363f7d43ab4d933c2cbbab4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fd7bc3783ead75155db0ba8b966fb834a682d6fa","unresolved":true,"context_lines":[{"line_number":116,"context_line":"          failed or some other info about what and in which job/test case"},{"line_number":117,"context_line":"          went wrong."},{"line_number":118,"context_line":"          Please try to avoid comments like ``recheck - unrelated failure`` as"},{"line_number":119,"context_line":"          such comments are almost the same as simply ``recheck`` without any"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"It is important that before you request a recheck, you adhere to the"},{"line_number":122,"context_line":"following guidelines:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3e850b82_9baeaf57","line":119,"in_reply_to":"d480f45f_18eb50bc","updated":"2024-03-25 17:27:44.000000000","message":"if we are updating this and we expect peopel to read this we shoudl refrence it here\nhttps://github.com/openstack/project-config/blob/master/zuul.d/pipelines.yaml#L10","commit_id":"46230c71621228522363f7d43ab4d933c2cbbab4"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8e91d28eea8ddc658ad1e949e2671dfbbaf96046","unresolved":true,"context_lines":[{"line_number":117,"context_line":"          went wrong."},{"line_number":118,"context_line":"          Please try to avoid comments like ``recheck - unrelated failure`` as"},{"line_number":119,"context_line":"          such comments are almost the same as simply ``recheck`` without any."},{"line_number":120,"context_line":"          Please check below examples of the good recheck commands."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"It is important that before you request a recheck, you adhere to the"},{"line_number":123,"context_line":"following guidelines:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"66413ab8_dda9c499","line":120,"range":{"start_line":120,"start_character":58,"end_line":120,"end_character":66},"updated":"2024-05-13 05:38:41.000000000","message":"\"comments\"?","commit_id":"6885a4d80df469de9eb389a8c9816f80f14619b8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f28daf79c6ccfa6d3a29ba55b60a1fb0e2b95aca","unresolved":false,"context_lines":[{"line_number":117,"context_line":"          went wrong."},{"line_number":118,"context_line":"          Please try to avoid comments like ``recheck - unrelated failure`` as"},{"line_number":119,"context_line":"          such comments are almost the same as simply ``recheck`` without any."},{"line_number":120,"context_line":"          Please check below examples of the good recheck commands."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"It is important that before you request a recheck, you adhere to the"},{"line_number":123,"context_line":"following guidelines:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"318c6455_5f62d227","line":120,"range":{"start_line":120,"start_character":58,"end_line":120,"end_character":66},"in_reply_to":"66413ab8_dda9c499","updated":"2024-05-14 11:13:05.000000000","message":"Done","commit_id":"6885a4d80df469de9eb389a8c9816f80f14619b8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4282f65d4cfaecc2a3ef079ca178be129b307ecf","unresolved":true,"context_lines":[{"line_number":157,"context_line":"   it is also pretty clear that it was not related to the patch, you can also"},{"line_number":158,"context_line":"   add name of the failed test to the recheck command, like for example"},{"line_number":159,"context_line":"   ``recheck - failed test"},{"line_number":160,"context_line":"   tempest.api.compute.servers.test_attach_interfaces.AttachInterfacesTestJSON.test_reassign_port_between_servers``"},{"line_number":161,"context_line":"#. If a recheck results in a similar failure on the subsequent run, it"},{"line_number":162,"context_line":"   would be best to reach out (via the mailing list or IRC) to the"},{"line_number":163,"context_line":"   project team responsible for the service you think is failing and"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bd639976_47c09e7e","line":160,"updated":"2024-05-13 07:21:51.000000000","message":"This overflows not only this line but also the resulting output. Can we find some shorter example or just reduce to maybe \"tempest.api.compute.servers.test_class.test_example\"?","commit_id":"6885a4d80df469de9eb389a8c9816f80f14619b8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f28daf79c6ccfa6d3a29ba55b60a1fb0e2b95aca","unresolved":false,"context_lines":[{"line_number":157,"context_line":"   it is also pretty clear that it was not related to the patch, you can also"},{"line_number":158,"context_line":"   add name of the failed test to the recheck command, like for example"},{"line_number":159,"context_line":"   ``recheck - failed test"},{"line_number":160,"context_line":"   tempest.api.compute.servers.test_attach_interfaces.AttachInterfacesTestJSON.test_reassign_port_between_servers``"},{"line_number":161,"context_line":"#. If a recheck results in a similar failure on the subsequent run, it"},{"line_number":162,"context_line":"   would be best to reach out (via the mailing list or IRC) to the"},{"line_number":163,"context_line":"   project team responsible for the service you think is failing and"}],"source_content_type":"text/x-rst","patch_set":2,"id":"006b026b_90855959","line":160,"in_reply_to":"bd639976_47c09e7e","updated":"2024-05-14 11:13:05.000000000","message":"Done","commit_id":"6885a4d80df469de9eb389a8c9816f80f14619b8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4282f65d4cfaecc2a3ef079ca178be129b307ecf","unresolved":true,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"For more information on how to deal with integration test failures,"},{"line_number":228,"context_line":"see the `Developer\u0027s Guide"},{"line_number":229,"context_line":"\u003chttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\u003e`_."},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"Zuul v3 native jobs"},{"line_number":232,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"99cb3722_59ccaaaa","line":229,"updated":"2024-05-13 07:21:51.000000000","message":"This section seems to no longer be correct, there are no automated comments any more, so we can drop it completely?","commit_id":"6885a4d80df469de9eb389a8c9816f80f14619b8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f28daf79c6ccfa6d3a29ba55b60a1fb0e2b95aca","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"For more information on how to deal with integration test failures,"},{"line_number":228,"context_line":"see the `Developer\u0027s Guide"},{"line_number":229,"context_line":"\u003chttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\u003e`_."},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"Zuul v3 native jobs"},{"line_number":232,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"a7ff1eef_e53e3f38","line":229,"in_reply_to":"99cb3722_59ccaaaa","updated":"2024-05-14 11:13:05.000000000","message":"done in follow up patch https://review.opendev.org/c/openstack/project-team-guide/+/919559","commit_id":"6885a4d80df469de9eb389a8c9816f80f14619b8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4282f65d4cfaecc2a3ef079ca178be129b307ecf","unresolved":true,"context_lines":[{"line_number":255,"context_line":"It is worth noting that, while the goal focuses on the fixing the jobs"},{"line_number":256,"context_line":"used in Victoria (and future releases), backporting the converted jobs"},{"line_number":257,"context_line":"to the older branches where they are still in use is recommended"},{"line_number":258,"context_line":"for maintenance reasons in the long run."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fd93f091_d933d0ab","line":258,"updated":"2024-05-13 07:21:51.000000000","message":"Victoria is EOL so I think this section is also obsolete by now and can be deleted?\n\nIMO it would help focus on important topics","commit_id":"6885a4d80df469de9eb389a8c9816f80f14619b8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f28daf79c6ccfa6d3a29ba55b60a1fb0e2b95aca","unresolved":false,"context_lines":[{"line_number":255,"context_line":"It is worth noting that, while the goal focuses on the fixing the jobs"},{"line_number":256,"context_line":"used in Victoria (and future releases), backporting the converted jobs"},{"line_number":257,"context_line":"to the older branches where they are still in use is recommended"},{"line_number":258,"context_line":"for maintenance reasons in the long run."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ed12953b_45d43a3b","line":258,"in_reply_to":"fd93f091_d933d0ab","updated":"2024-05-14 11:13:05.000000000","message":"done in follow up patch https://review.opendev.org/c/openstack/project-team-guide/+/919559","commit_id":"6885a4d80df469de9eb389a8c9816f80f14619b8"},{"author":{"_account_id":15993,"name":"Amy Marrich","display_name":"Amy Marrich (spotz)","email":"amy@demarco.com","username":"amarrich"},"change_message_id":"569439b3411fdc933ab76cec6acf9e379438d292","unresolved":true,"context_lines":[{"line_number":110,"context_line":"tests."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":".. note:: Please do not **EVER** simply ``recheck`` without a"},{"line_number":113,"context_line":"          reason. Please always *attempt* to determine the reason for the"},{"line_number":114,"context_line":"          failure and give some meaningful reason of why recheck needs to"},{"line_number":115,"context_line":"          be done. It can be something like name of the test(s) which have"},{"line_number":116,"context_line":"          failed or some other info about what and in which job/test case"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7b879e6b_714e88e3","line":113,"updated":"2024-05-14 13:35:20.000000000","message":"Change this to cause so you don\u0027t have multiple \u0027reason\u0027 in the same sentance","commit_id":"7b6466658922f3dedda3de29051183da4df041ef"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"269623650a51384400d615a442cfd13be872716f","unresolved":false,"context_lines":[{"line_number":110,"context_line":"tests."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":".. note:: Please do not **EVER** simply ``recheck`` without a"},{"line_number":113,"context_line":"          reason. Please always *attempt* to determine the reason for the"},{"line_number":114,"context_line":"          failure and give some meaningful reason of why recheck needs to"},{"line_number":115,"context_line":"          be done. It can be something like name of the test(s) which have"},{"line_number":116,"context_line":"          failed or some other info about what and in which job/test case"}],"source_content_type":"text/x-rst","patch_set":3,"id":"282aae71_2309f9e3","line":113,"in_reply_to":"7b879e6b_714e88e3","updated":"2024-05-29 07:11:32.000000000","message":"Done","commit_id":"7b6466658922f3dedda3de29051183da4df041ef"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c554f25abe71531c7f32a9b8035a8251ccbb3b24","unresolved":true,"context_lines":[{"line_number":116,"context_line":"          failed or some other info about what and in which job/test case"},{"line_number":117,"context_line":"          went wrong."},{"line_number":118,"context_line":"          Please try to avoid comments like ``recheck - unrelated failure`` as"},{"line_number":119,"context_line":"          such comments are almost the same as simply ``recheck`` without any."},{"line_number":120,"context_line":"          Please check below examples of the good recheck comments."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"It is important that before you request a recheck, you adhere to the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"8e945704_5428288c","line":119,"range":{"start_line":119,"start_character":66,"end_line":119,"end_character":77},"updated":"2024-05-14 12:00:46.000000000","message":"delete?\n\ni think you ment to saem \n\n\"same as simply ``recheck`` without any reason.\"\n\nbut i think you can just delete the last two words.","commit_id":"7b6466658922f3dedda3de29051183da4df041ef"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"269623650a51384400d615a442cfd13be872716f","unresolved":false,"context_lines":[{"line_number":116,"context_line":"          failed or some other info about what and in which job/test case"},{"line_number":117,"context_line":"          went wrong."},{"line_number":118,"context_line":"          Please try to avoid comments like ``recheck - unrelated failure`` as"},{"line_number":119,"context_line":"          such comments are almost the same as simply ``recheck`` without any."},{"line_number":120,"context_line":"          Please check below examples of the good recheck comments."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"It is important that before you request a recheck, you adhere to the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"e481b5e2_66217049","line":119,"range":{"start_line":119,"start_character":66,"end_line":119,"end_character":77},"in_reply_to":"8e945704_5428288c","updated":"2024-05-29 07:11:32.000000000","message":"Done","commit_id":"7b6466658922f3dedda3de29051183da4df041ef"},{"author":{"_account_id":15993,"name":"Amy Marrich","display_name":"Amy Marrich (spotz)","email":"amy@demarco.com","username":"amarrich"},"change_message_id":"569439b3411fdc933ab76cec6acf9e379438d292","unresolved":true,"context_lines":[{"line_number":153,"context_line":"#. In some cases, it may be entirely unclear why something failed. In"},{"line_number":154,"context_line":"   this case, you may need to recheck with a reason of \"Not sure what"},{"line_number":155,"context_line":"   failed, rechecking to get another data point.\""},{"line_number":156,"context_line":"#. In case if it is not clear what was exactly the root cause of the issue but"},{"line_number":157,"context_line":"   it is also pretty clear that it was not related to the patch, you can also"},{"line_number":158,"context_line":"   add name of the failed test to the recheck command, like for example"},{"line_number":159,"context_line":"   ``recheck - failed test tempest.api.network.test_ports.test_example``"}],"source_content_type":"text/x-rst","patch_set":3,"id":"8ad90cbe_3d0d707b","line":156,"range":{"start_line":156,"start_character":3,"end_line":156,"end_character":61},"updated":"2024-05-14 13:35:20.000000000","message":"In the case of the root cause not being clear for the issue","commit_id":"7b6466658922f3dedda3de29051183da4df041ef"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"269623650a51384400d615a442cfd13be872716f","unresolved":false,"context_lines":[{"line_number":153,"context_line":"#. In some cases, it may be entirely unclear why something failed. In"},{"line_number":154,"context_line":"   this case, you may need to recheck with a reason of \"Not sure what"},{"line_number":155,"context_line":"   failed, rechecking to get another data point.\""},{"line_number":156,"context_line":"#. In case if it is not clear what was exactly the root cause of the issue but"},{"line_number":157,"context_line":"   it is also pretty clear that it was not related to the patch, you can also"},{"line_number":158,"context_line":"   add name of the failed test to the recheck command, like for example"},{"line_number":159,"context_line":"   ``recheck - failed test tempest.api.network.test_ports.test_example``"}],"source_content_type":"text/x-rst","patch_set":3,"id":"228478c6_4ae6f0cb","line":156,"range":{"start_line":156,"start_character":3,"end_line":156,"end_character":61},"in_reply_to":"8ad90cbe_3d0d707b","updated":"2024-05-29 07:11:32.000000000","message":"Done","commit_id":"7b6466658922f3dedda3de29051183da4df041ef"}]}