)]}'
{"manifests/auth.pp":[{"author":{"_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"},"change_message_id":"eed865716f4179e17e9ed5f585be811bd01da54a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#    Optional. Defaults to undef."},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"#  [*auth_cacert*]"},{"line_number":29,"context_line":"#    Certificate chain for SSL validation. Optional; Defaults to \u0027None\u0027"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"#  [*auth_endpoint_type*]"},{"line_number":32,"context_line":"#    Type of endpoint in Identity service catalog to use for"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"1a26ad4f_bafc693f","line":29,"updated":"2015-10-28 06:07:31.000000000","message":"Default to undef","commit_id":"b73f26cbb13d3d3efddc8e8631d4bce2480b2a57"},{"author":{"_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"},"change_message_id":"eed865716f4179e17e9ed5f585be811bd01da54a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  $auth_endpoint_type \u003d undef,"},{"line_number":45,"context_line":") {"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  if ! $auth_cacert {"},{"line_number":48,"context_line":"    aodh_config { \u0027service_credentials/os_cacert\u0027: ensure \u003d\u003e absent }"},{"line_number":49,"context_line":"  } else {"},{"line_number":50,"context_line":"    aodh_config { \u0027service_credentials/os_cacert\u0027: value \u003d\u003e $auth_cacert }"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"1a26ad4f_daf9254f","line":47,"updated":"2015-10-28 06:07:31.000000000","message":"it\u0027s possible to inverse this if (why you use a negation here?)","commit_id":"b73f26cbb13d3d3efddc8e8631d4bce2480b2a57"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c56127bab8fe382098361849050eb0d918a0e7a8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  $auth_endpoint_type \u003d undef,"},{"line_number":45,"context_line":") {"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  if ! $auth_cacert {"},{"line_number":48,"context_line":"    aodh_config { \u0027service_credentials/os_cacert\u0027: ensure \u003d\u003e absent }"},{"line_number":49,"context_line":"  } else {"},{"line_number":50,"context_line":"    aodh_config { \u0027service_credentials/os_cacert\u0027: value \u003d\u003e $auth_cacert }"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"fa80f949_0d31c20b","line":47,"updated":"2015-11-03 14:51:32.000000000","message":"Gael, why did you upload a new patchset ??? This change was on purpose...","commit_id":"997948b987694bc538be80583d2940f6dafb4e7f"}],"manifests/db/sync.pp":[{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"488ff7aa525a9e05cce4c4b648dc171625c7c5f8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# [*user*]"},{"line_number":5,"context_line":"#   (optional) User to run dbsync command."},{"line_number":6,"context_line":"#   Defaults to \u0027aodh\u0027"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"class aodh::db::sync ("},{"line_number":9,"context_line":"  $user \u003d \u0027aodh\u0027,"}],"source_content_type":"text/x-puppet","patch_set":25,"id":"fa80f949_194eaf6f","line":6,"updated":"2015-11-04 17:31:17.000000000","message":"I dont see us doing this on the other sync classes, how does the aodh user get created? package?","commit_id":"9510ce46e4d9d59a44fdb4e60a072d6577992bf7"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c9573acaeb001801e4b693571ba4e890bb799184","unresolved":false,"context_lines":[{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# [*user*]"},{"line_number":5,"context_line":"#   (optional) User to run dbsync command."},{"line_number":6,"context_line":"#   Defaults to \u0027aodh\u0027"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"class aodh::db::sync ("},{"line_number":9,"context_line":"  $user \u003d \u0027aodh\u0027,"}],"source_content_type":"text/x-puppet","patch_set":25,"id":"fa80f949_f9b96b7a","line":6,"in_reply_to":"fa80f949_194eaf6f","updated":"2015-11-04 17:49:22.000000000","message":"that\u0027s an optional parameter that is used for creating the database. It allows anyone to use another user, depending of which packaging they\u0027re using.\nWe\u0027re pushing this parameter in other modules too.","commit_id":"9510ce46e4d9d59a44fdb4e60a072d6577992bf7"}]}
