)]}'
{"manifests/init.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ad8af267457c71a2ec1e3c5ded39b7b74dc8201c","unresolved":false,"context_lines":[{"line_number":229,"context_line":"  $use_syslog                         \u003d undef,"},{"line_number":230,"context_line":"  $use_stderr                         \u003d undef,"},{"line_number":231,"context_line":"  $log_facility                       \u003d undef,"},{"line_number":232,"context_line":"  $log_dir                            \u003d \u0027/var/log/aodh\u0027,"},{"line_number":233,"context_line":"  $notification_driver                \u003d undef,"},{"line_number":234,"context_line":"  $notification_topics                \u003d \u0027notifications\u0027,"},{"line_number":235,"context_line":"  $database_connection                \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a8ffd7b_394e9c6f","line":232,"updated":"2015-12-03 06:24:31.000000000","message":"This should be undef, as the aodh::logging specifies this path and uses pick against this then the logging value. So the log_dir in init should be undef, and log_dir in aodh::logging should be /var/log/aodh for consistency","commit_id":"058b7a96a2adbfaf8fe3320aab02b16ad4c0aec9"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e465e2e6b7599fd9078d0c1f02fc77a202cf9661","unresolved":false,"context_lines":[{"line_number":229,"context_line":"  $use_syslog                         \u003d undef,"},{"line_number":230,"context_line":"  $use_stderr                         \u003d undef,"},{"line_number":231,"context_line":"  $log_facility                       \u003d undef,"},{"line_number":232,"context_line":"  $log_dir                            \u003d \u0027/var/log/aodh\u0027,"},{"line_number":233,"context_line":"  $notification_driver                \u003d undef,"},{"line_number":234,"context_line":"  $notification_topics                \u003d \u0027notifications\u0027,"},{"line_number":235,"context_line":"  $database_connection                \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7a740942_a003b472","line":232,"in_reply_to":"9a8ffd7b_394e9c6f","updated":"2015-12-04 10:10:30.000000000","message":"Agree with Alex.","commit_id":"058b7a96a2adbfaf8fe3320aab02b16ad4c0aec9"}]}