)]}'
{"manifests/db.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4e6fcf23a10587c6640377fd11c3995d51d56db1","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  if $database_connection_real {"},{"line_number":61,"context_line":"    case $database_connection_real {"},{"line_number":62,"context_line":"      /^mongodb:\\/\\//: {"},{"line_number":63,"context_line":"        $backend_package \u003d $::aodh::params::pymongo_package_name"},{"line_number":64,"context_line":"      }"},{"line_number":65,"context_line":"      /^mysql:\\/\\//: {"},{"line_number":66,"context_line":"        $backend_package \u003d false"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a740942_19fcf76e","line":63,"updated":"2015-12-08 12:01:15.000000000","message":"we already have it.","commit_id":"2f587531e283f6251d781dd9c7e1a3ffa29286b0"},{"author":{"_account_id":19663,"name":"Tom Verdaat","email":"tom@server.biz","username":"toMeloos"},"change_message_id":"0cb343b8b5abff0dfda7def4ee6b9518062be546","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  if $database_connection_real {"},{"line_number":61,"context_line":"    case $database_connection_real {"},{"line_number":62,"context_line":"      /^mongodb:\\/\\//: {"},{"line_number":63,"context_line":"        $backend_package \u003d $::aodh::params::pymongo_package_name"},{"line_number":64,"context_line":"      }"},{"line_number":65,"context_line":"      /^mysql:\\/\\//: {"},{"line_number":66,"context_line":"        $backend_package \u003d false"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a740942_fc8d59d3","line":63,"in_reply_to":"7a740942_19fcf76e","updated":"2015-12-08 12:25:02.000000000","message":"Very sorry, I see my work has crossed paths with change I3542d01e2b294506d6d311a3e996a5f9ed4b9953. This is no longer needed.","commit_id":"2f587531e283f6251d781dd9c7e1a3ffa29286b0"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4e6fcf23a10587c6640377fd11c3995d51d56db1","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  if $sync_db {"},{"line_number":102,"context_line":"    include ::aodh::db::sync"},{"line_number":103,"context_line":"  }"},{"line_number":104,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a740942_9966a728","line":102,"updated":"2015-12-08 12:01:15.000000000","message":"i guess it should be in init.pp. Also add please include aodh::db to init.pp","commit_id":"2f587531e283f6251d781dd9c7e1a3ffa29286b0"},{"author":{"_account_id":19663,"name":"Tom Verdaat","email":"tom@server.biz","username":"toMeloos"},"change_message_id":"0cb343b8b5abff0dfda7def4ee6b9518062be546","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  if $sync_db {"},{"line_number":102,"context_line":"    include ::aodh::db::sync"},{"line_number":103,"context_line":"  }"},{"line_number":104,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a740942_bc9b5117","line":102,"in_reply_to":"7a740942_9966a728","updated":"2015-12-08 12:25:02.000000000","message":"This is how it\u0027s done in puppet-ceilometer. Is there a guideline on this and can we then make all modules consistent?","commit_id":"2f587531e283f6251d781dd9c7e1a3ffa29286b0"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"0e90b5cbbcd9a55516e23f4797c787b33accce65","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  if $sync_db {"},{"line_number":102,"context_line":"    include ::aodh::db::sync"},{"line_number":103,"context_line":"  }"},{"line_number":104,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a740942_9fca071a","line":102,"in_reply_to":"7a740942_bc9b5117","updated":"2015-12-08 12:38:26.000000000","message":"Yeah, for ceilo we have sync_db here, because main class init.pp didn\u0027t have had ever db parameters. Some historical reasons i guess:\n\nhttps://github.com/openstack/puppet-ceilometer/commit/4ae12d7905a6ea43e9c97a40b56fe5a6e13a3565\n\nBut for aodh we have db parameters in main class. So you need move this under init.pp. So, if main (init.pp, api.pp - whatever if we have pick for db parameters here) class doesn\u0027t contain db parameters then you can use db_sync here.\n\nI believe, that Ceilo just exception from our rules.","commit_id":"2f587531e283f6251d781dd9c7e1a3ffa29286b0"}]}
