)]}'
{"manifests/evaluator.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ce72c1ed09a00aa73f0cf787f9924b26cbaafb58","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  include ::aodh::params"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  if ($coordination_url \u003d~ /redis/ ) {"},{"line_number":31,"context_line":"    ensure_packages(\u0027python-redis\u0027, {"},{"line_number":32,"context_line":"      ensure \u003d\u003e present,"},{"line_number":33,"context_line":"      name   \u003d\u003e $::aodh::params::redis_package_name,"},{"line_number":34,"context_line":"      tag    \u003d\u003e \u0027openstack\u0027,"},{"line_number":35,"context_line":"    })"},{"line_number":36,"context_line":"  }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  if $coordination_url {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa31d9ce_64b2f195","line":35,"range":{"start_line":31,"start_character":0,"end_line":35,"end_character":6},"updated":"2017-02-14 22:32:44.000000000","message":"use:\n\nensure_resource(\u0027package\u0027, \u0027python-redis\u0027, {\n  name \u003d\u003e $...,\n  tag \u003d\u003e [\u0027openstack\u0027] \n}) \n\nensure_packages automatically adds the ensure\u003d\u003e present which isn\u0027t overridable. To be friendly to operators we try and use ensure_resource instead which can allow the operators to pin to specific versions or do something like ensure \u003d\u003e latest (for automagic upgrades)","commit_id":"838ecdd3eb41d35107957195ecfcd64d1b1fee9a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ea3d964a6199bb9ca29761a7bb616dc038cfd0cf","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  include ::aodh::deps"},{"line_number":28,"context_line":"  include ::aodh::params"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  if ($coordination_url \u003d~ /redis/ ) {"},{"line_number":31,"context_line":"    ensure_resource(\u0027package\u0027, \u0027python-redis\u0027, {"},{"line_number":32,"context_line":"      name   \u003d\u003e $::aodh::params::redis_package_name,"},{"line_number":33,"context_line":"      tag    \u003d\u003e \u0027openstack\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa31d9ce_3acd74b7","line":30,"updated":"2017-02-14 23:10:47.000000000","message":"probably should be /^redis/ but this is probably ok","commit_id":"d387a4ff5728ed28fe60f02a184f16d37f95ee75"}],"spec/classes/aodh_evaluator_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8acf50cab4a459e4e0617b3571225abbdd9c972c","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        case facts[:osfamily]"},{"line_number":106,"context_line":"        when \u0027Debian\u0027"},{"line_number":107,"context_line":"          { :evaluator_package_name \u003d\u003e \u0027aodh-evaluator\u0027,"},{"line_number":108,"context_line":"            :evaluator_service_name \u003d\u003e \u0027aodh-evaluator\u0027 }"},{"line_number":109,"context_line":"        when \u0027RedHat\u0027"},{"line_number":110,"context_line":"          { :evaluator_package_name \u003d\u003e \u0027openstack-aodh-evaluator\u0027,"},{"line_number":111,"context_line":"            :evaluator_service_name \u003d\u003e \u0027openstack-aodh-evaluator\u0027 }"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa31d9ce_355bc5f7","line":108,"updated":"2017-02-14 23:42:04.000000000","message":"You forgot to define :redis_package_name here","commit_id":"d387a4ff5728ed28fe60f02a184f16d37f95ee75"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"589c99cb1f24518787f2d0ba57a42ca81525a70f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"      it \u0027installs python-redis package\u0027 do"},{"line_number":25,"context_line":"        is_expected.to contain_package(platform_params[:redis_package_name]).with("},{"line_number":26,"context_line":"          :name \u003d\u003e platform_params[:redis_package_name],"},{"line_number":27,"context_line":"\t  :tag  \u003d\u003e \u0027openstack\u0027"},{"line_number":28,"context_line":"        )"},{"line_number":29,"context_line":"      end"},{"line_number":30,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa31d9ce_dfea7c73","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":1},"updated":"2017-02-15 08:23:10.000000000","message":"please use white spaces here","commit_id":"0336cd100876b0e9730b15a613b3f070a3ade4fd"}]}