)]}'
{"id":"openstack%2Fpuppet-aodh~720002","triplet_id":"openstack%2Fpuppet-aodh~master~I74b9bdaeefee1ed3bbb836d3a45e20e5609f0a8b","project":"openstack/puppet-aodh","branch":"master","topic":"notification-driver-list","hashtags":[],"change_id":"I74b9bdaeefee1ed3bbb836d3a45e20e5609f0a8b","subject":"Fix broken unit tests because of list in notification drivers","status":"MERGED","created":"2020-04-14 15:09:18.000000000","updated":"2020-04-14 16:22:51.000000000","submitted":"2020-04-14 16:22:51.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"720002-1586881371720-69063b05","meta_rev_id":"2deb6bf38e2c9bc879a672fb2cd7ff37b8004fc9","_number":720002,"virtual_id_number":720002,"owner":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-04-14 16:22:51.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-04-14 16:02:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":2,"date":"2020-04-14 15:52:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-04-14 16:02:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-04-14 15:52:55.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"},{"updated":"2020-04-14 16:22:51.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3fc68e7a7fbad7435ede49e59a0032ba73e6c4bf","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-04-14 15:09:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a48ab863a5fc200209b08dba810e8fe592bc3fa4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-14 15:35:40.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/836253b6b7d54d20bbce52c2aba35839 : SUCCESS in 6m 26s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/ee7e24bcef3e4ddb963d589f242a18b3 : SUCCESS in 5m 31s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/1b5a4772d81940e7980b0be48ee84e0c : SUCCESS in 4m 52s\n- puppet-openstack-unit-5.5-centos-8 https://zuul.opendev.org/t/openstack/build/34f1fc493c6844089ecfa899b7ee6eea : SUCCESS in 14m 17s\n- puppet-openstack-unit-6.11-centos-8 https://zuul.opendev.org/t/openstack/build/ecc778cc3a93411185bf3d796746b1f4 : SUCCESS in 15m 33s\n- puppet-openstack-unit-6.11-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/bf5481cc191542ecb5713ad6c38b6352 : SUCCESS in 9m 36s\n- puppet-openstack-unit-latest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/36b3bb9b9a2243df91e54eee4667a060 : SUCCESS in 10m 06s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"aab674081b4ebe87cf9317281f0f3860c289262b","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2020-04-14 15:52:55.000000000","message":"Patch Set 1: Code-Review+2\n\nOptimally all this type of testing should just make it contains the oslo::messaging::notifications resource with proper parameters and not that the config option gets set that should be tested in puppet-oslo.\n\nWe can merge all these to get it fixed right away, you can push them through yourself since it\u0027s only testing","accounts_in_message":[],"_revision_number":1},{"id":"92393512aff855b86b0128aca2000233e2c8e309","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-04-14 16:02:24.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nThank you, Tobias, for your feedback.\n\nI agree that we shouldn\u0027t test the behavior of puppet-oslo in each modules, and at least we should avoid to test all parameter patterns to test some logics inside puppet-oslo.\n\nI\u0027ll go ahead to merge curent fixes by myself, but I\u0027ll review current test codes and submit some update about them. (at least we can remove the tests currently failing, IMO)","accounts_in_message":[],"_revision_number":1},{"id":"afe2fd94e630b227d0769e7a3da3f88756002d3e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-14 16:02:36.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"43f70d862c28f5f1a417c0fc568c9b1c0e201cad","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-14 16:22:51.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"b1e92a59ec70a9d94e1841460a51dba7172a6b49","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-14 16:22:51.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f6108999a63a4bc582c05217c0066f08 : SUCCESS in 4m 58s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/5d53537cc48f4649a130084d6fece5f7 : SUCCESS in 4m 45s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/07246ccf825e493b998eaea1fe2a535d : SUCCESS in 4m 29s\n- puppet-openstack-unit-5.5-centos-8 https://zuul.opendev.org/t/openstack/build/80fb176805634d3292dbab9a40ba8a65 : SUCCESS in 14m 44s\n- puppet-openstack-unit-6.11-centos-8 https://zuul.opendev.org/t/openstack/build/7a099ac3626e445685fe8d655e740e93 : SUCCESS in 14m 36s\n- puppet-openstack-unit-6.11-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/b92fc8df778d40bc851f82477315f502 : SUCCESS in 9m 06s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f07abdbffcf877e433ee4a02906fb35846d01d99","revisions":{"f07abdbffcf877e433ee4a02906fb35846d01d99":{"kind":"REWORK","_number":1,"created":"2020-04-14 15:09:18.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/02/720002/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-aodh","ref":"refs/changes/02/720002/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-aodh refs/changes/02/720002/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-aodh refs/changes/02/720002/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-aodh refs/changes/02/720002/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-aodh refs/changes/02/720002/1"}}},"commit":{"parents":[{"commit":"013426b97e9cc848241fe15539bb19b0375ea155","subject":"Prepare Ussuri M3 again","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-aodh/commit/013426b97e9cc848241fe15539bb19b0375ea155"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2020-04-14 15:09:05.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2020-04-14 15:09:05.000000000","tz":540},"subject":"Fix broken unit tests because of list in notification drivers","message":"Fix broken unit tests because of list in notification drivers\n\nBecause the value for oslo_messaging_notifications/driver is now\na list[1], we should expect that a list is set when multiple drivers\nare given.\n\n[1] c7b0cc82fac79b47c3dd9a625cbd5a1eb192ed00\n\nChange-Id: I74b9bdaeefee1ed3bbb836d3a45e20e5609f0a8b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-aodh/commit/f07abdbffcf877e433ee4a02906fb35846d01d99"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-aodh/commit/f07abdbffcf877e433ee4a02906fb35846d01d99"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}