)]}'
{"manifests/expirer.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"60a8cce908f8cfa0675210ac53587e60c0d23656","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#    Defaults to 0."},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"class aodh::expirer ("},{"line_number":35,"context_line":"  $enable_cron \u003d true,"},{"line_number":36,"context_line":"  $minute      \u003d 1,"},{"line_number":37,"context_line":"  $hour        \u003d 0,"},{"line_number":38,"context_line":"  $monthday    \u003d \u0027*\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9f560f44_6b08db27","line":35,"range":{"start_line":35,"start_character":3,"end_line":35,"end_character":14},"updated":"2020-08-14 09:10:35.000000000","message":"Why enable_cron? cant we just have \"ensure\" and then enforce values","commit_id":"f286cfc9095eeb2beebdbd584c11c751c8cb099b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1867ce64d74019ff931e553b23c97207700813f6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#    Defaults to 0."},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"class aodh::expirer ("},{"line_number":35,"context_line":"  $enable_cron \u003d true,"},{"line_number":36,"context_line":"  $minute      \u003d 1,"},{"line_number":37,"context_line":"  $hour        \u003d 0,"},{"line_number":38,"context_line":"  $monthday    \u003d \u0027*\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9f560f44_ebab4b72","line":35,"range":{"start_line":35,"start_character":3,"end_line":35,"end_character":14},"in_reply_to":"9f560f44_6b08db27","updated":"2020-08-14 10:10:20.000000000","message":"Actually this is based on the existing implementation in panko::expirer .\nI think using ensure parameter would be better. I\u0027ll submit a patch to puppet-panko as well to make sure that we have the consistent parameters in puppet-aodh and puppet-panko.","commit_id":"f286cfc9095eeb2beebdbd584c11c751c8cb099b"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"60a8cce908f8cfa0675210ac53587e60c0d23656","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  include aodh::params"},{"line_number":45,"context_line":"  include aodh::deps"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  if $enable_cron {"},{"line_number":48,"context_line":"    $ensure \u003d \u0027present\u0027"},{"line_number":49,"context_line":"  } else {"},{"line_number":50,"context_line":"    $ensure \u003d \u0027absent\u0027"},{"line_number":51,"context_line":"  }"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  if $maxdelay \u003d\u003d 0 {"},{"line_number":54,"context_line":"    $sleep \u003d \u0027\u0027"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9f560f44_4b0d1736","line":51,"range":{"start_line":47,"start_character":0,"end_line":51,"end_character":3},"updated":"2020-08-14 09:10:35.000000000","message":"we could skip all this then","commit_id":"f286cfc9095eeb2beebdbd584c11c751c8cb099b"}]}